From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id CCE342C60; Wed, 22 Aug 2018 16:10:23 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Aug 2018 07:10:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,274,1531810800"; d="scan'208";a="83543930" Received: from silpixa00399468.ir.intel.com (HELO silpixa00399468.ger.corp.intel.com.) ([10.237.223.133]) by fmsmga001.fm.intel.com with ESMTP; 22 Aug 2018 07:10:00 -0700 From: Brian Archbold To: Wenzhuo Lu , Jingjing Wu , Bernard Iremonger Cc: dev@dpdk.org, brian.archbold@intel.com, stable@dpdk.org Date: Wed, 22 Aug 2018 07:05:06 +0100 Message-Id: <20180822060506.7025-1-brian.archbold@intel.com> X-Mailer: git-send-email 2.9.5 Subject: [dpdk-dev] [PATCH] app/testpmd: fix duplicate exit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Aug 2018 14:10:24 -0000 In interactive mode, when the "quit" command is issued, pmd_test_exit() is being called twice, once through the "quit" command and the other after termination of prompt. Remove duplicated exit routine by removing call from "quit" command. Steps to reproduce: - Run testpmd in interactive mode. - type "quit". Fixes: af75078fece3 ("first public release") Cc: stable@dpdk.org Signed-off-by: Brian Archbold --- app/test-pmd/cmdline.c | 1 - 1 file changed, 1 deletion(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 589121d..76b7cc1 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -7573,7 +7573,6 @@ static void cmd_quit_parsed(__attribute__((unused)) void *parsed_result, struct cmdline *cl, __attribute__((unused)) void *data) { - pmd_test_exit(); cmdline_quit(cl); } -- 2.9.5