DPDK patches and discussions
 help / color / mirror / Atom feed
From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
To: "Rao, Nikhil" <nikhil.rao@intel.com>,
	jerin.jacob@caviumnetworks.com, olivier.matz@6wind.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 4/4] eventdev: add auto test for eth Tx adapter
Date: Wed, 22 Aug 2018 21:53:09 +0530	[thread overview]
Message-ID: <20180822162307.GA18299@ltp-pvn> (raw)
In-Reply-To: <6cd55ea9-fb68-73a4-43bd-dcd6772247cf@intel.com>

On Wed, Aug 22, 2018 at 09:43:02PM +0530, Rao, Nikhil wrote:
> > > +       ev_qid = qcnt;
> > > +       qconf.nb_atomic_flows = dev_info.max_event_queue_flows;
> > > +       qconf.nb_atomic_order_sequences = 32;
> > > +       qconf.schedule_type = RTE_SCHED_TYPE_ATOMIC;
> > > +       qconf.priority = RTE_EVENT_DEV_PRIORITY_HIGHEST;
> > > +       qconf.event_queue_cfg = RTE_EVENT_QUEUE_CFG_SINGLE_LINK;
> > > +       err = rte_event_queue_setup(TEST_DEV_ID, ev_qid, &qconf);
> > > +       TEST_ASSERT_SUCCESS(err, "Failed to setup queue %u", ev_qid);
> >
> > On reconfigure, setup all the ports and queues so that the newly configured
> > values are seen by them.
>
> Is that required since dev_conf matches dev_info except for the number
> of queues ?

Some drivers require this as without port setup newly configured queues might
not be visible.

>
> >
> > > +
> > > +       err = rte_event_port_link(TEST_DEV_ID, ev_port, &ev_qid, NULL, 1);
> > > +       TEST_ASSERT(err == 1, "Failed to link queue port %u",
> > > +                   ev_port);
> > > +
> > > +       err = rte_event_eth_tx_adapter_start(TEST_INST_ID);
> > > +       TEST_ASSERT(err == 0, "Expected 0 got %d", err);
> > > +
> > > +       err = rte_event_dev_service_id_get(0, &eid);
> > > +       TEST_ASSERT(err == 0, "Expected 0 got %d", err);
> >
> > An event device might not be needing a service core, check the capabilities
> > before requesting service id above.
> >
>
> The internal_port capability is checked at the beginning of the
> function, if its not set, I think its Ok to assume that we need a
> service core ?

That check is to see if TX adapter requires service core, the above one is
checking if eventdev requires serivce core.

>
> Thanks,
> Nikhil
>

Regards,
Pavan.

  reply	other threads:[~2018-08-22 16:26 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-17  4:20 [dpdk-dev] [PATCH v2 1/4] eventdev: add eth Tx adapter APIs Nikhil Rao
2018-08-17  4:20 ` [dpdk-dev] [PATCH v2 2/4] eventdev: add caps API and PMD callbacks for eth Tx adapter Nikhil Rao
2018-08-19 10:45   ` Jerin Jacob
2018-08-21  8:52     ` Rao, Nikhil
2018-08-21  9:11       ` Jerin Jacob
2018-08-22 13:34         ` Rao, Nikhil
2018-08-17  4:20 ` [dpdk-dev] [PATCH v2 3/4] eventdev: add eth Tx adapter implementation Nikhil Rao
2018-08-17  4:20 ` [dpdk-dev] [PATCH v2 4/4] eventdev: add auto test for eth Tx adapter Nikhil Rao
2018-08-17 11:55   ` Pavan Nikhilesh
2018-08-22 16:13     ` Rao, Nikhil
2018-08-22 16:23       ` Pavan Nikhilesh [this message]
2018-08-23  1:48         ` Rao, Nikhil
2018-08-19 10:19 ` [dpdk-dev] [PATCH v2 1/4] eventdev: add eth Tx adapter APIs Jerin Jacob
2018-08-31  5:41 ` [dpdk-dev] [PATCH v3 1/5] " Nikhil Rao
2018-08-31  5:41   ` [dpdk-dev] [PATCH v3 2/5] eventdev: add caps API and PMD callbacks for eth Tx adapter Nikhil Rao
2018-08-31  5:41   ` [dpdk-dev] [PATCH v3 3/5] eventdev: add eth Tx adapter implementation Nikhil Rao
2018-08-31  5:41   ` [dpdk-dev] [PATCH v3 4/5] eventdev: add auto test for eth Tx adapter Nikhil Rao
2018-09-17 14:00     ` Jerin Jacob
2018-08-31  5:41   ` [dpdk-dev] [PATCH v3 5/5] doc: add event eth Tx adapter guide Nikhil Rao
2018-09-17 13:56     ` Jerin Jacob
2018-09-20 17:41   ` [dpdk-dev] [PATCH v4 1/5] eventdev: add eth Tx adapter APIs Nikhil Rao
2018-09-20 17:41     ` [dpdk-dev] [PATCH v4 2/5] eventdev: add caps API and PMD callbacks for eth Tx adapter Nikhil Rao
2018-09-20 17:41     ` [dpdk-dev] [PATCH v4 3/5] eventdev: add eth Tx adapter implementation Nikhil Rao
2018-09-20 17:41     ` [dpdk-dev] [PATCH v4 4/5] eventdev: add auto test for eth Tx adapter Nikhil Rao
2018-09-20 17:41     ` [dpdk-dev] [PATCH v4 5/5] doc: add event eth Tx adapter guide Nikhil Rao
2018-09-21  5:04     ` [dpdk-dev] [PATCH v4 1/5] eventdev: add eth Tx adapter APIs Jerin Jacob
2018-09-28 10:05     ` Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180822162307.GA18299@ltp-pvn \
    --to=pbhagavatula@caviumnetworks.com \
    --cc=dev@dpdk.org \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=nikhil.rao@intel.com \
    --cc=olivier.matz@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).