From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0069.outbound.protection.outlook.com [104.47.41.69]) by dpdk.org (Postfix) with ESMTP id 713043772 for ; Wed, 22 Aug 2018 18:26:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rwITfg9o3oNQioHjulOJd+zb2nKZ6j5TkA3vN+rdygU=; b=a6l5Br8+MkNNDVX7PQhP+7mf0K00AVBJxRCIJCgaG4YAT26RCj9zFWaoUdDcVMGbD8dMg08xuinIjtzsU0l28dyI2spS3KAd8d8Il0BhogXea/Lb0mctxs2SaozNvEhbOESkSZcCKw9zatTxPgOnp/5+NQNl5T0ImtDusRZLV3E= Received: from ltp-pvn (12.108.191.226) by BYAPR07MB4965.namprd07.prod.outlook.com (2603:10b6:a03:5b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1059.23; Wed, 22 Aug 2018 16:23:42 +0000 Date: Wed, 22 Aug 2018 21:53:09 +0530 From: Pavan Nikhilesh To: "Rao, Nikhil" , jerin.jacob@caviumnetworks.com, olivier.matz@6wind.com Cc: dev@dpdk.org Message-ID: <20180822162307.GA18299@ltp-pvn> References: <1534479652-80182-1-git-send-email-nikhil.rao@intel.com> <1534479652-80182-4-git-send-email-nikhil.rao@intel.com> <20180817115515.GA4360@ltp-pvn> <6cd55ea9-fb68-73a4-43bd-dcd6772247cf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6cd55ea9-fb68-73a4-43bd-dcd6772247cf@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Originating-IP: [12.108.191.226] X-ClientProxiedBy: BM1PR0101CA0009.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:18::19) To BYAPR07MB4965.namprd07.prod.outlook.com (2603:10b6:a03:5b::14) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 913c3f5d-0c07-4872-c141-08d6084ba315 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:BYAPR07MB4965; X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB4965; 3:xjBslwlbv3dzYhqBJ3Kd+mPpQhAev7Nyg7Gw4yxIJ5CcdeyeIt4+jbln7D0PPIjtWfYKEN5c8mw2GrOBx5envgiHRLq17OcC4tm+RyDRXbGavEJAH5hkWrkhyBM/Fs/uUBy4YFC/iJQkmUXbm4q6AF5D9M8ChJ/mX8xgO+LxYxXISH0dF7BTKLn5vzLUdvuGm+ZRq2NrSD9L9zT5uXQm0Z3X9aSbgDvHztZA7CcoVo9HHOQ1+/2AWlrvAltyorWZ; 25:XI/XQmIHj18tAOfZWqOPm14F7822KABOYDOtDKNdXaI0VzGvRfUgARoGrCGzpffL78fJJZRzP8OFTUX4wdc+rZULeD9DxwdWgf6ZvmJkOwumrA2q7AdOnSbDPJas/h9vhfPA3W2j6WuggF4Yog2mgF9ZHg2F6HJLVvFvvdc9zMedn7NBarlFZH8LDUvChC9XK8MiGyq6vmDz7lgRjpxYPHcc3wzudRonws0COs5ni6U3NF/k+Du8WQhhLFPrIgE0WWoKOQAUPGqELPRrvUr0+LHavaOv0/86vX6ia0fD3C6DRaEDJei+QgFTMayza63uQywNI0fjgyKjyH8BIE9RsA==; 31:BPDmJkLO4NkfToM6+S/t949NLwIYjrMAf0hI8aA/sKRT7KIgD4IHRvUUfakzyEBPt6wCQjYnxB0+S90Can74EnKQVo25zs3Y6mBpuEIHqzsbiPV/xztvGsfFhE4ZYLhIvpY6I7M06qc0y9iY4X5jIp6f843AXEXaXL7Vw5e8UwhoWY++K9ncYf560EntNL8Q0Pz5RItQ/1694RLu1J98HegId5e056gKfvYR20uQOSE= X-MS-TrafficTypeDiagnostic: BYAPR07MB4965: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB4965; 20:IPIzkuZOUYNy6RYERiA5uUAEVO7MwgOC3jel5VP8Axb9MEWDV+Z53iPoEccq/ujL6vnyV6Yw8M1uWNcc6xhIsEzTccU2zUb5H6M6isJCRIWQPkvbUMvu6Zq+T1RX4OWbPEOkGDzpaQ6kYkvaOKaUtzLQeSrdWkK/zIPAOFMd4unxL5GqopvRpCjvw9mgqXK7RvnSM9KDH7hzLAVfxbJZcZH5uQLPUHm9eOgW/dW+nMUzQqHCNI2d9doJ4caiN9UafV6gh9A2We/A6X1s6IQCbFvnfJ0/RJaPZNmG4idSBGGEK5Hj+MeEjho1u6wNosQuQQfWvG73NfZhtrZ4wMwKHV5eyH/1bW8lYg783eKdlach8L1wHmAKSgChmeUJyBN3xPk0drbFZAyg1fqnp++rqg5hh0UjLMQle7WcafgiKRgtNqxMiEGznjAr7pNjDGKQWFX04p1Fu5LUcE0Zo+7UcclshEKQK9gg375ZThOugFBCr1nhsCRthBJr3tPtZetmnZgy0Ere5Fcde4NUylGpHKjecDueb/EyIga6cVTCCs2MbnzKuL6+ZFHyH92XXR3/UXEosIUTEM7O85gD+gCiZ9H6DRGcg6CDfkRZ5C4Tr30=; 4:2M62lJxYDqn6Rha7l1hK4yHn6erKr5nUi5zx7dSpZavvsXlFEHVLXjo6iZrMR4YBuxZyHcU5kGsxuCQXOQ1YVoxlcbR2tQcSI4TYAl9t94trPKTBjCL3qkuWiFopQMSZWokzWU9Q78QucD1DiHNTuZZlfaptK1FQumGgHn0mS4PDAMsw0yMyEt9p4WdKNoR/nRa2tcieLqv2G+2ZxRfKv/deDt64p6FqUtbm50ZwCi5d5JqX97c1VrkdaR3leRVrtr+r8Km6qYHe5VtN6t3ijw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(823301075)(3231311)(944501410)(52105095)(10201501046)(93006095)(3002001)(149027)(150027)(6041310)(20161123562045)(20161123558120)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(201708071742011)(7699016); SRVR:BYAPR07MB4965; BCL:0; PCL:0; RULEID:; SRVR:BYAPR07MB4965; X-Forefront-PRVS: 0772E5DAD5 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39850400004)(396003)(366004)(346002)(136003)(376002)(199004)(189003)(81166006)(33656002)(33716001)(8676002)(47776003)(23726003)(50466002)(72206003)(105586002)(16586007)(81156014)(6666003)(316002)(4326008)(58126008)(3846002)(25786009)(386003)(6116002)(106356001)(1076002)(66066001)(5660300001)(6246003)(11346002)(446003)(476003)(76176011)(33896004)(956004)(16526019)(14444005)(486006)(478600001)(52116002)(6496006)(229853002)(55016002)(68736007)(305945005)(2906002)(53936002)(186003)(8936002)(9686003)(7736002)(97736004)(42882007)(93886005)(26005)(18370500001)(107986001)(42262002); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR07MB4965; H:ltp-pvn; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BYAPR07MB4965; 23:YaZf5cOM9l1Cwd88kU8EbkiLK4iXMy0Nm6CBQ9uDs?= =?us-ascii?Q?r0n6yZF4wVlQZ3gLIwoDR3euOA8txdBixVNo3bMzcKDYjlLKVNi2pHMe18r8?= =?us-ascii?Q?emO4b61yRUZEG3CIWNFKsGpa3VdQG4jTKgiaagCNqTG5u6WJ8HS9C50IpZ5f?= =?us-ascii?Q?zZSWQuIxom4hPGJn/Iwmqn+PmP0EzvAH3LB1WA8ubMOIZh38LEyJiP8c4wDl?= =?us-ascii?Q?4sTrQzKLXPx7HLoj147p0J/8M85i5uBwFspOkV6XSH74NiFnsyIZ19LksF+1?= =?us-ascii?Q?F+3EzR1kVkzNCMd6tvFwenexxDvWQWjzIKuOPdbHn7ChgU7J70+5k2w9Dqdh?= =?us-ascii?Q?RT2zeWqbwAKf7PLtcZGiTKI8jfBKB0XsmtcGgWrzSMTBn7vvTbxae370HGk2?= =?us-ascii?Q?J7W5CnqJTb8KPDN2NkRENJaJmFxo6MCifPY5FwMjDCUTyHEiFsmyuH308yH4?= =?us-ascii?Q?tTEf5zThArdD5BUk3i0RUCwoCzncH3EfzJjaqcaEH81YcxFksG9gp3G9SUah?= =?us-ascii?Q?mHYUlVi+QVo7UHayLuxWrMnHiyD6boOxYOgDIc4PzzYLwc9QQiLYqdZ3q4Bt?= =?us-ascii?Q?E5NkFC03A8rwcn/6Wvd/ci6VQKMQsch/HOk4lOeJjhggEzGD9cjWt5m55SK2?= =?us-ascii?Q?t6S/uSUi1FB+NB46X5fySiEI92cTtFJ4oZ/T2IbsyGFpvlHe/LFMI2sAXgkg?= =?us-ascii?Q?5nbGATYQC/txhRwSOMepAtT98n4fMDg+R/D6GN6Db+6xQrFJw8JbiimkMrgv?= =?us-ascii?Q?MkGeXcJMjLU6z1r8TuyGpz9LBILvtsUqXwsg7xiVb95WNTEz4TRhB8f8dXxL?= =?us-ascii?Q?em7cpDWKLryi/H83bn/zDbzO9dMzwmkZR7XjasxyRHa4Dur6/hXrQyow+06p?= =?us-ascii?Q?IXYHZMofRYT0xrOQuU/djOmXC9lgdfyZhZ+SeoPyv1iu5Oaf1O3HlJySlvEy?= =?us-ascii?Q?dVvs2ja6XjWuTt/xevbXktTKylVXrcm3VPUlE15B3gpw76zflQ/7rfNZAB9+?= =?us-ascii?Q?cmgjU57gFs25LJogNGAVCMxLLFXfHjim7GS/k/S6/W0IIFRpSHtFPKPDC8Xw?= =?us-ascii?Q?ex/B4GP6HQMJ5e4SwrgnfxKLH/FuP1umB763V+EPR5uERTAERTze7RqKN1Ww?= =?us-ascii?Q?tSbXCEkN/oxoT7vN4QaYG3s0WHfKiTMVwheiXWATyN4eBqxzVM9MvKUUA7TB?= =?us-ascii?Q?ZxSiMz1Zo/VC8dDcvw/ykoSewJMxS6TD/lR4o6DWRxz+v4pIhPhKJZQlg/bs?= =?us-ascii?Q?UlGVWI2jVAUQqccHorQS1es8jZinLzjwlXBZe2n8s2N/pLdH8FWiYmuTtZ/o?= =?us-ascii?Q?Pm9CaUWT3A+Pow4ErEl1ujNTZ45sIXYuPOEtIyNWKTYmsF5I8nKR0WYnErWZ?= =?us-ascii?Q?xOweQ=3D=3D?= X-Microsoft-Antispam-Message-Info: Ml1/4IBgKj2jKXxQT+VKFLcB0viYynLkJcs1tz3eGf8t+JGCY6LWTdHVjqJw5Er1G0vgyXQL+U/aIXWn/ZjenWnR/NP5z3YfXvXZnqTgNLgqxY4mD1KWPmy9v2VaNXQZlCErrWI9IqmjL5sZ+VZMPVY11NMc2RYD3pSOSEFnpZrpFEP2/M/fWLVEq6bbq2B56+DVlpJU+sM5Ac3qzemJ7LHw4SOlaniXI8eXM+yCOIOUXtZEKyA1L7pMxEm55Up+D78ioGVq+vUP3e60+36bwvYx+TyOKigpQYNRmWkhT3tk4gY8fteMtmcLRYci5kNBqw4XLAYDn/PEh76FYlOcwUKyTocTjCDpB8GNM7LOUFM= X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB4965; 6:GlWod/ybxXydQ9Hc6Nduzkpjc7Q6CAr/CsA5MvYJ8wnrXmdlZtIwTw1yT4B/4Oz638o/6iWXdCjOLAL8eZve3X+VaQ4xeaS3x+aAiT/J8TXFavVi+za8ez60WWX8YUSdqfQ7ZbNQO6zPxooQpdCvL1KqJZaj7KHZRSFg2lGha4PM7o7cq0XaChA5oyz04CyHqdiAMTtPAZmtnV5jRmlv75nsCZCPA0hq/woHH9kWUTrj38aiL3f5uu+kqKByz6aVM2a46wfMm3qCkOG4Q3IY42DfosddlJA/mz4XXmuk72Wdzx+LLwGBHlFBd2WscoUW+tER4ahH9QR0xYh3NRF22/fPGPYvwpRVJXBiDI1DIw0sNrRGissjhhpM8qPKZN1ULOenjrhr0s7lCvc2BG52tLhkQCAlnnbcn+KFP07ook7m3cB8jrFPCN1k0bg8o+QySGG90VDs05//rVI/GaGb8g==; 5:fqUNaqnM77p4XMiHA2hYPxVqzWoiZXTLNf4l5kHWK4d+Y2oaX/QUEvE/VypNzooO3J6hZfKEloph85ayP+rrGCaaEWEeKh9tUNClvQgdcF7LG+RUbG8dA8Fd8cUWOdqtUTBqD65r322hJKNiphF9bCTW44WlMafl1KciafTr1NE=; 7:RbLuXOBrTVtc2TEU34+ul8swZ65mQUDLBwrJHREhUDmlE08TgO2LRbHx0lAdAcBKogC51TtobA5YbATCe1k9CL6L2by3Ns/Fot0v6mTwOfpaRFnVKjNbf46C1D1PGxOTH713V10YHjCRBgUidppBKi9IE0HSee62DatEf4aTz1j5nU9ALht1j46QIXix9pda3W0WpgegeVms3T+9fiJBYUnCOCp3wa22WnRxdIrHvD05AruWSjremIpaUmvqRY0s SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2018 16:23:42.0559 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 913c3f5d-0c07-4872-c141-08d6084ba315 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB4965 Subject: Re: [dpdk-dev] [PATCH v2 4/4] eventdev: add auto test for eth Tx adapter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Aug 2018 16:26:27 -0000 On Wed, Aug 22, 2018 at 09:43:02PM +0530, Rao, Nikhil wrote: > > > + ev_qid = qcnt; > > > + qconf.nb_atomic_flows = dev_info.max_event_queue_flows; > > > + qconf.nb_atomic_order_sequences = 32; > > > + qconf.schedule_type = RTE_SCHED_TYPE_ATOMIC; > > > + qconf.priority = RTE_EVENT_DEV_PRIORITY_HIGHEST; > > > + qconf.event_queue_cfg = RTE_EVENT_QUEUE_CFG_SINGLE_LINK; > > > + err = rte_event_queue_setup(TEST_DEV_ID, ev_qid, &qconf); > > > + TEST_ASSERT_SUCCESS(err, "Failed to setup queue %u", ev_qid); > > > > On reconfigure, setup all the ports and queues so that the newly configured > > values are seen by them. > > Is that required since dev_conf matches dev_info except for the number > of queues ? Some drivers require this as without port setup newly configured queues might not be visible. > > > > > > + > > > + err = rte_event_port_link(TEST_DEV_ID, ev_port, &ev_qid, NULL, 1); > > > + TEST_ASSERT(err == 1, "Failed to link queue port %u", > > > + ev_port); > > > + > > > + err = rte_event_eth_tx_adapter_start(TEST_INST_ID); > > > + TEST_ASSERT(err == 0, "Expected 0 got %d", err); > > > + > > > + err = rte_event_dev_service_id_get(0, &eid); > > > + TEST_ASSERT(err == 0, "Expected 0 got %d", err); > > > > An event device might not be needing a service core, check the capabilities > > before requesting service id above. > > > > The internal_port capability is checked at the beginning of the > function, if its not set, I think its Ok to assume that we need a > service core ? That check is to see if TX adapter requires service core, the above one is checking if eventdev requires serivce core. > > Thanks, > Nikhil > Regards, Pavan.