From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com
 [209.85.215.194]) by dpdk.org (Postfix) with ESMTP id 3148A2C60
 for <dev@dpdk.org>; Fri, 24 Aug 2018 01:17:09 +0200 (CEST)
Received: by mail-pg1-f194.google.com with SMTP id b129-v6so3366227pga.13
 for <dev@dpdk.org>; Thu, 23 Aug 2018 16:17:09 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=PygUNkASrKVs4h9RNpBnUXTFbNJTAYnff8aU8/WYO6I=;
 b=SaYO2+Nq0Y1cfxeJCLdv6Iyc0E6DkTmO8bKBBIGfCztpGAXMlH886xTzRh2zojgZP2
 HZqCGF8vHOB2JA2hXONCie9iuoL2fSS2VD4aWFKI1NZB7+TTA5GjJYdvO+0PSpWy38BI
 cVu23SkWdGQYFt6N4K1EH7JwSSix4m/xJ1CMLKUHvrTATAcAbW31rknWM52kmHK8RAqA
 2HBsDBj3q0YOz2sTbhAwrNZrkr13opFGobfIAUkNc9DZo4vI0ZaMBcLlTih0Fu9Sw95V
 NbfG/XO5KrTQjyyMTsMloQT98Qi2OHmVhEEW76CR9ySZuTQW6NDEOch0aoy8fNf1wkbC
 f5Mw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=PygUNkASrKVs4h9RNpBnUXTFbNJTAYnff8aU8/WYO6I=;
 b=QUnhHMbO7WT4gHPLtCaWSaqtLMimYm3b8/o3yrYqu/ITqe69abB2YO9jV8JlYZSu0b
 R2PJ/iX8Y5S7MW8ho0j4BYSHSZ4cvy2/eG13hwDfwrAD5gb7gjAixG/QT2MvZrV+0mgL
 Mx8gV+wrQUf4AKrAXMq5gOzbnFCO7WVJihrDZt1bSJyBZWY+Nj7hGRbo5U291+MFQL9K
 aocg5WLGjQCmnI8KajJMVcYwlRAJJk8xkPgOneEtqiNg81tDUPU3LgrVn+pyNkt94Kty
 CLtvroCnxVaYyOxm7gB557R6+XehvcOYzcaIL4Sj7im/G9jYCNFE8ETfpxshudJtqWjN
 m9ig==
X-Gm-Message-State: AOUpUlE2yqWX2LuW2znmdiyuWDuXHBxbUYFEbZyqXzzs6sULL7QE2S7X
 6Bf6DdF7sRYqoHhYX7tllh2uEA==
X-Google-Smtp-Source: AA+uWPxUtPs+ZRKGvVvtT0pJjkzjg5mmI3celNSoxUOVh1pW2Tc0i6i+qCFXxN1ul9IlnmFyBLvvyA==
X-Received: by 2002:a62:9c17:: with SMTP id
 f23-v6mr65087669pfe.209.1535066228409; 
 Thu, 23 Aug 2018 16:17:08 -0700 (PDT)
Received: from xeon-e3 (204-195-22-127.wavecable.com. [204.195.22.127])
 by smtp.gmail.com with ESMTPSA id l3-v6sm7374722pff.8.2018.08.23.16.17.08
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Thu, 23 Aug 2018 16:17:08 -0700 (PDT)
Date: Thu, 23 Aug 2018 16:17:06 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Ciara Power <ciara.power@intel.com>
Cc: harry.van.haaren@intel.com, brian.archbold@intel.com,
 emma.kenny@intel.com, dev@dpdk.org
Message-ID: <20180823161706.601ffde5@xeon-e3>
In-Reply-To: <1535026093-101872-2-git-send-email-ciara.power@intel.com>
References: <1535026093-101872-1-git-send-email-ciara.power@intel.com>
 <1535026093-101872-2-git-send-email-ciara.power@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 01/11] telemetry: initial telemetry
 infrastructure
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 23 Aug 2018 23:17:09 -0000

On Thu, 23 Aug 2018 13:08:03 +0100
Ciara Power <ciara.power@intel.com> wrote:

> +
> +static int
> +telemetry_probe(struct rte_vdev_device *vdev)
> +{
> +	int ret;
> +
> +	RTE_SET_USED(vdev);
> +	ret = rte_telemetry_init(rte_socket_id());
> +	if (ret < 0) {
> +		printf("Error - Telemetry initialisation failed\n");
> +		return -1;
> +	}
> +	return 0;
> +}
> +
> +static int
> +telemetry_remove(struct rte_vdev_device *vdev)
> +{
> +	const char *name;
> +	name = rte_vdev_device_name(vdev);
> +	printf("Uninitialising the device: %s\n", name);

Please use DPDK (rte) logging for all messages.