From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by dpdk.org (Postfix) with ESMTP id 344FC98 for ; Fri, 24 Aug 2018 01:27:41 +0200 (CEST) Received: by mail-pg1-f195.google.com with SMTP id t14-v6so3405214pgf.0 for ; Thu, 23 Aug 2018 16:27:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=or6zFUNXM0OqcOx5t6Ln/8JDiIQaYVcn0/ncWUpwNb0=; b=DvVelnLUMuxqdll/O2AgEpc6Vc+iK5qtiz7JyE1a6nPkGT2yuVPsznE3GBXwcV3CjK C40cu8WB1UhR2IEdK9zLWGAUYT0TK+QwXRbHrT7rPZanxbTnr33ckS1negW7+JhHE/EW QL3f8K9RTpRPfUESixQsk9tO2lNua5lnBt4+U1LtAH7+fCsLymoA8qjDy+as5I9RleOY 1yM85qTEzxmZJxa9Sohta7dlIxYhjwAyb1SEtOz8FjFhqpZ7S/AeV4c0t9OThPjk5jIX MxYR7l24ZFYcXLCny0ky8yJOJV7DDXlc5GeZ3ZWijvA99NaqoHLIRxZ/HJ9uPF//ikBg rvcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=or6zFUNXM0OqcOx5t6Ln/8JDiIQaYVcn0/ncWUpwNb0=; b=C28EG9ufoMnwyq78imZw2n0VljHnlE5i/Ox1MhVCOD5lAQum8WkaPcUTclkmTbPmbK YibRsqDPVms45HjXGTN3jzhjcRliFOSh2TdnRP+a9Ghcas4TbCd8JeoIQG8HGFJL9key 7MFn+p6bIxHVRr0aAIkXtdIKic3tMVUl03y8QDdJvGhQp38UV00tYuof8ooxNjEFb50W 7aRzAapSae+eQ5TbvjEVgDNzNHPQyzt+CV/7II3bSkmcM2mr5eRBontLnh0tTAgPpRG2 a+pKiOZkKYunBWrKeaGfKmKT8I3dMhKr8ZMxh8JZvheuzLKRqyX0L02lCT9iZCx4MZux mXCQ== X-Gm-Message-State: AOUpUlGW7gpEREb4nyi/SsDIqLS6ysZr3yIxbm/Y2MQUXjHCXGOseXO1 KGwA3w2NrG6usbAcV1sVMAyNlg== X-Google-Smtp-Source: AA+uWPwvC3ramDrsrzQFPC5Z6ziJeXry3CJYzgSXmFTP9X5xLrZi6CWr+qqQe+4CfLZZKLMTjDGqLQ== X-Received: by 2002:a62:4dc1:: with SMTP id a184-v6mr64438430pfb.5.1535066860310; Thu, 23 Aug 2018 16:27:40 -0700 (PDT) Received: from xeon-e3 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id j16-v6sm17505280pfk.125.2018.08.23.16.27.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 23 Aug 2018 16:27:40 -0700 (PDT) Date: Thu, 23 Aug 2018 16:27:33 -0700 From: Stephen Hemminger To: Ciara Power Cc: harry.van.haaren@intel.com, brian.archbold@intel.com, emma.kenny@intel.com, dev@dpdk.org Message-ID: <20180823162733.78507eeb@xeon-e3> In-Reply-To: <1535026093-101872-4-git-send-email-ciara.power@intel.com> References: <1535026093-101872-1-git-send-email-ciara.power@intel.com> <1535026093-101872-4-git-send-email-ciara.power@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 03/11] telemetry: add client feature and sockets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Aug 2018 23:27:41 -0000 On Thu, 23 Aug 2018 13:08:05 +0100 Ciara Power wrote: > This patch introduces clients to the telemetry API. > > When a client makes a connection through the initial telemetry > socket, they can send a message through the socket to be > parsed. Register messages are expected through this socket, to > enable clients to register and have a client socket setup for > future communications. > > A TAILQ is used to store all clients information. Using this, the > client sockets are polled for messages, which will later be parsed > and dealt with accordingly. > > Functionality that make use of the client sockets were introduced > in this patch also, such as writing to client sockets, and sending > error responses. > > Signed-off-by: Ciara Power > Signed-off-by: Brian Archbold Rather than using the rather heavyweight jansson library and creating an additional dependency on an external library; may I recommend reusing the json_writer library (I wrote) that is part of iproute2 and much simpler. https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/tree/lib/json_writer.c