From: Stephen Hemminger <stephen@networkplumber.org>
To: Alejandro Lucero <alejandro.lucero@netronome.com>
Cc: dev@dpdk.org, stable@dpdk.org, ferruh.yigit@intel.com
Subject: Re: [dpdk-dev] [PATCH v3 0/2] support MAC changes when no live changes allowed
Date: Fri, 24 Aug 2018 07:46:27 -0700 [thread overview]
Message-ID: <20180824074627.3415e05b@xeon-e3> (raw)
In-Reply-To: <1535120736-785-1-git-send-email-alejandro.lucero@netronome.com>
On Fri, 24 Aug 2018 15:25:34 +0100
Alejandro Lucero <alejandro.lucero@netronome.com> wrote:
> The original patch assumes all NICs can safely change or set the MAC
> in any case. However, this is not always true. NFP depends on the firmware
> capabilities and this is not always supported. There are other NICs with
> this same limitation, although, as far as I know, not in DPDK. Linux kernel
> has a IFF_LIVE_ADDR_CHANGE flag and two NICs are checking this flag for
> allowing or not live MAC changes
The semantic in Linux is different than what I think you are trying to do.
Some devices can not change MAC address at all because of hardware or hypervisor
restrictions. Other devices can not change address while device is up (started
in DPDK API).
With Linux the policy was to assume by default device could change address while up.
And then let a few virtual devices allow it.
next prev parent reply other threads:[~2018-08-24 14:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-24 14:25 Alejandro Lucero
2018-08-24 14:25 ` [dpdk-dev] [PATCH v3 1/2] ethdev: fix MAC changes when live change not supported Alejandro Lucero
2018-08-24 15:04 ` Ferruh Yigit
2018-08-24 14:25 ` [dpdk-dev] [PATCH v3 2/2] net/nfp: fix live MAC changes " Alejandro Lucero
2018-08-24 14:46 ` Stephen Hemminger [this message]
2018-08-27 12:37 ` [dpdk-dev] [PATCH v3 0/2] support MAC changes when no live changes allowed Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180824074627.3415e05b@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=alejandro.lucero@netronome.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).