Re: [dpdk-dev] [PATCH v2 2/6] net/mvpp2: use common code to initialize DMA

[Tomasz Duszynski <tdu@semihalf.com>]

On Fri, Aug 24, 2018 at 05:46:21PM +0100, Ferruh Yigit wrote:
> On 8/24/2018 3:54 PM, Tomasz Duszynski wrote:
> > From: Liron Himi <lironh@marvell.com>
> >
> > Use common code to initialize MUSDK DMA memory buffers.
> >
> > Signed-off-by: Liron Himi <lironh@marvell.com>
> > Reviewed-by: Natalie Samsonov <nsamsono@marvell.com>
>
> <...>
>
> > @@ -2653,24 +2651,17 @@ rte_pmd_mrvl_probe(struct rte_vdev_device *vdev)
> >  	if (mrvl_dev_num)
> >  		goto init_devices;
> >
> > -	MRVL_LOG(INFO, "Perform MUSDK initializations");
> > -	/*
> > -	 * ret == -EEXIST is correct, it means DMA
> > -	 * has been already initialized (by another PMD).
> > -	 */
> > -	ret = mv_sys_dma_mem_init(MRVL_MUSDK_DMA_MEMSIZE);
> > -	if (ret < 0) {
> > -		if (ret != -EEXIST)
> > -			goto out_free_kvlist;
> > -		else
> > -			MRVL_LOG(INFO,
> > -				"DMA memory has been already initialized by a different driver.");
> > -	}
> > +	MRVL_LOG(INFO, "Perform MUSDK initializations\n");
>
> MRVL_LOG already adding "\n", no need to change original log, a few more below.

Good catch.

--
- Tomasz Duszyński