From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by dpdk.org (Postfix) with ESMTP id 455852B92 for ; Tue, 28 Aug 2018 13:46:50 +0200 (CEST) Received: by mail-wm0-f67.google.com with SMTP id y2-v6so1598739wma.1 for ; Tue, 28 Aug 2018 04:46:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=LdKKRe9PQYv447graDhSpWklpOdcg/ZwWzxjmBE3TF4=; b=IiStqO1dgP6bb9d5tQkMtFTUSMG/QwMHoVejNy06EpWeVq7dy6ItTwDdce2s/gY57q rJA0ZOybjAVMgIKG8afaLtTTIoYEn0goVwrtEUVrMdTfgqwdcc0FSYhYFDQd4tIkHdJc l2eNXrjbHIZBto2WJ+ccHkhMcddl7ZYEyrq7aO1A6YYtHd8EwbqmbHPFOjmq0q29TFPm 2wZqeZX905T4b/3Tyr95axpaVoDmVtZ92jpQRnyOwQg6TXRULL7ufnjscrKJnUraSgCY zcACENGfhjPKii1EI8oMnT1BwfqxHfByUFpJFTFwkL0oWle1LvbJQpEyocEUjaKmmdMw B7hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=LdKKRe9PQYv447graDhSpWklpOdcg/ZwWzxjmBE3TF4=; b=BXyVF8pETNnqsvpMjQyoSoBQvdVkF0UwnVx8n9FfVvoOzeRGjalwETNuWOQOQZX1yt VIVk+AdJVJCthu6eiv7zIxo+Q0LUtofhm2S7UPugUmKpJLBT4CqjrpYhyKdEoE6EZs4o VfaqiM5AAFejLIjP2/xNwku1gFrRsA3VQj43UxPcOsrl3jWGg+JyIaUvo2N/W7WKUW8T jWshtjuo/p2B6mFHr0JbbTGiqWELfl1AXQAQZoF7a876Hoiy04CHLhlrgj602EecwGb1 /ryXrdVIIHDyfTieyv6fw+9XtJXqvtOafOxV5yy0RK8jbW4WAI+1Oa8rslzzd700pjRY CNGA== X-Gm-Message-State: APzg51AoqHMJ5uiloGDQ3Ek1DeaBT7ESXkRNHgIDIYQRlPeyva1p533v KQAx8sHAk0ZGwNLFNMrWtI8xwg== X-Google-Smtp-Source: ANB0VdavW3YOeNkiQauPkCpawipt06fICHXbqR7zEJrwYnADbmLts1LQeliVl2q7zNDlxN0E1zx9PA== X-Received: by 2002:a1c:b9cf:: with SMTP id j198-v6mr1146017wmf.93.1535456809887; Tue, 28 Aug 2018 04:46:49 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id c15-v6sm726087wmb.2.2018.08.28.04.46.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 28 Aug 2018 04:46:48 -0700 (PDT) Date: Tue, 28 Aug 2018 13:46:33 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Ciara Power Cc: harry.van.haaren@intel.com, brian.archbold@intel.com, emma.kenny@intel.com, dev@dpdk.org Message-ID: <20180828114633.vky27x53tu7eyag2@bidouze.vm.6wind.com> References: <1535026093-101872-1-git-send-email-ciara.power@intel.com> <1535026093-101872-2-git-send-email-ciara.power@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1535026093-101872-2-git-send-email-ciara.power@intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH 01/11] telemetry: initial telemetry infrastructure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Aug 2018 11:46:50 -0000 Hi Ciara, On Thu, Aug 23, 2018 at 01:08:03PM +0100, Ciara Power wrote: > This patch adds the infrastructure and initial code for the > telemetry library. > > A virtual device is used for telemetry, which is included in > this patch. To use telemetry, a command-line argument must be > used - "--vdev=telemetry". > Why use a virtual device? It seems that you are only using the device semantic as a way to carry around a tag telling the DPDK framework to init your library once it has finished its initialization. I guess you wanted to avoid having to add the call to rte_telemetry_init to all applications. In the absence of a proper EAL option framework, you can workaround by adding a --telemetry EAL parameter, setting a flag on, and checking this flag from librte_telemetry, within a routine declared with RTE_INIT_PRIO. I only see afterward the selftest being triggered via kvargs. I haven't yet looked at the testing done, but if it is only unit test, the "test" app would be better suited. If it is integration testing to verify the behavior of the library with other PMDs, you probably need specific context, thus selftest being insufficient on its own and useless for other users. > Control threads are used to get CPU cycles for telemetry, which > are configured in this patch also. > > Signed-off-by: Ciara Power > Signed-off-by: Brian Archbold Regards, -- Gaëtan Rivet 6WIND