From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com
 [209.85.214.195]) by dpdk.org (Postfix) with ESMTP id BB941231E
 for <dev@dpdk.org>; Wed, 29 Aug 2018 17:31:17 +0200 (CEST)
Received: by mail-pl1-f195.google.com with SMTP id u11-v6so2454322plq.5
 for <dev@dpdk.org>; Wed, 29 Aug 2018 08:31:17 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=EmidhoyFoXyqQJmbDk35srj38yJASbI5u4aKvGyJHyU=;
 b=QLHqgwK/fHYwbSF0azSs41MjI3OuS11BIXH5UbIWgxH90OT+/hEH/FlKpE6TUQP6he
 kNhjQ3qzNFIi+Gs3Nics3grm3MOZZ9wCmw2ok1ALpYwellRGwR9V+pQ08xOQKa4+JR/g
 KTfTLj8OtvdxOUgYMQ3kWqYZUscKswfz+z1mjbYxVrziVJtYBiVfB2EO1f/2gIPAgnHt
 jMqYKX+aVbNjFj+jUanSt3Py0nt2xY9LuZlbeVHrR0S36iwtf1cjvWH4G8eD2dsUJw9R
 Qlid/N+TR+CMrS2wkW7K5rHNnZHh3uLmtjgxtuq5V2/wWpG4kbkA0Nr6Ti9zrSiDv4v/
 1GZg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=EmidhoyFoXyqQJmbDk35srj38yJASbI5u4aKvGyJHyU=;
 b=odEvW74BLiOHV3UcWTjyJxFsBm9pX3PPd3oA4We76WeMFTGP2oLqI7+FCN6ANcvgcL
 UlQ+FqCj4L42iyvDuGfpCxfWQtO+B8c0gsp5nsFVvyQVkeFG+cJItyXQl9XujlS8rOL/
 nzq0FERCYSGFHNoQ5itmWXFJpyaEN9+/K95eO5qPALifrfZ6cnuCiefSPepVrmfX03M/
 vFR1IDpYDkwEio0rnP13Iu6YFXHl2zf3TrN1Tb6b2E0ArLcTW4K7I9rCQV282R0MxihF
 crqVy7/Gm9Db9QHjrUgyY6mdvw1AE0XsWx1VHxiWD+mpsNhLB1CZhR2N+ieDRJTmYCEq
 Nh/A==
X-Gm-Message-State: APzg51A+TTIRGLFkzkVTF4usTN4EIRxQAdSJYlwiN3AVXHhZx8P1hJaM
 dIxL89t/ffRL4irs2b64iUiCtQ==
X-Google-Smtp-Source: ANB0VdbM3fMqBB/YuldbYPWSFHF6zhQC36uOe6rrVaDmNmlo3C3sEsrWT34Oqw37dVWiCTMYQes+VA==
X-Received: by 2002:a17:902:6684:: with SMTP id
 e4-v6mr2699118plk.50.1535556676882; 
 Wed, 29 Aug 2018 08:31:16 -0700 (PDT)
Received: from xeon-e3 (204-195-22-127.wavecable.com. [204.195.22.127])
 by smtp.gmail.com with ESMTPSA id u83-v6sm21722128pfj.37.2018.08.29.08.31.16
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Wed, 29 Aug 2018 08:31:16 -0700 (PDT)
Date: Wed, 29 Aug 2018 08:31:10 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Cc: dev@dpdk.org, olivier.matz@6wind.com
Message-ID: <20180829083110.42d85024@xeon-e3>
In-Reply-To: <20180827123835.27531-1-jerin.jacob@caviumnetworks.com>
References: <20180827123835.27531-1-jerin.jacob@caviumnetworks.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] mbuf: add IGMP packet type
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Aug 2018 15:31:18 -0000

On Mon, 27 Aug 2018 18:08:35 +0530
Jerin Jacob <jerin.jacob@caviumnetworks.com> wrote:

> Add support for IGMP packet type.
> 
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

Could you add logic to recoginize IGMP to the software packet type identification
rte_net_get_ptype used by drivers that don't have hardware support.

Also shouldn't this bit be part of RTE_PTYPE_L4_MASK?