From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by dpdk.org (Postfix) with ESMTP id C5404F11 for ; Wed, 29 Aug 2018 18:39:00 +0200 (CEST) Received: by mail-pl1-f196.google.com with SMTP id ba4-v6so2528199plb.11 for ; Wed, 29 Aug 2018 09:39:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LReDp+nhLcewyIRK314IgJoCQhZt8HELjAPLudqlBYw=; b=EsFMgL1yH4cyt0Hye7PhOwqmUTmlVeKYgKfr/tmATOCWCjbEv2n1Yff8ZRz/5aTL1a yWN7aOKzrJOxpXNv9L91ZxMp1kcqWMrV+9SlC73Z7vgRswxjB+7xwl8o1vfaPSHBiLN4 y9mvYOTcrRMjzh/PQN8/UYSaME6hm2G8oH0SQ70j4VNMWbGxkBZLhP5ITvuVHZjkGSh+ LF42wh6eY/wKbMSdGHsYke0nh+TJ1Zwip7Lapk2svyWisxNEgl/kYPnmT5K39t/jTLSp FPigh+39g1XJrohyI/kuGMYWsQaw8aH0Vrrl+08AfITmvYQHy/z833GJ+FucEhU4vQCG yoMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LReDp+nhLcewyIRK314IgJoCQhZt8HELjAPLudqlBYw=; b=sbM2Uxo39p5lvfm9/4Rd31/oMxzEG5/Eg4IDdwHyHc94goN4uXNO1ToAlEUFyNe25B cC1LDzu6D1lSR7nFuok3I1oDKtATRk5mPwOuNiofblW9bWHTLRYzgyKRIQ4pBB5m0qHS 5KYucefL0YF8xZwDcfz4pjyKyseX9tbXtYWnb4/eMrGJrCQYEG/2tHSKJ9HQD5GLQF0o AY6Sh4NJM3TinmH4Q3SOcSPyDq7IJWaZIXjHC5sq80KuH3YiLOLcbzkUCO2wh17heHxd QJbcoYylcVZ2E7uhHAEt6s3DY5ELoNhz48RVEfvr882l9RMsOOjmqIjiVEpPvspLrXRQ HC6w== X-Gm-Message-State: APzg51C8jURF/R89LHEQFywLLTm/i8IS8GDonsK0ZBLR+IP/KsSnz9YH 0qVRhgkuj/1y0RApNN8yZb6tya0GEUDutg== X-Google-Smtp-Source: ANB0VdZRXF+mHYi63SG0fh21Y6quxaGq3DLfKMZKwd0a6crMjXpdxsyRDP8zv9+gHa94OY8tmbKIFw== X-Received: by 2002:a17:902:4601:: with SMTP id o1-v6mr6799840pld.202.1535560739935; Wed, 29 Aug 2018 09:38:59 -0700 (PDT) Received: from xeon-e3 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id g5-v6sm7555771pfc.77.2018.08.29.09.38.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 29 Aug 2018 09:38:59 -0700 (PDT) Date: Wed, 29 Aug 2018 09:38:53 -0700 From: Stephen Hemminger To: Jerin Jacob Cc: dev@dpdk.org, olivier.matz@6wind.com Message-ID: <20180829093853.5f866760@xeon-e3> In-Reply-To: <20180829155904.GA7133@jerin> References: <20180827123835.27531-1-jerin.jacob@caviumnetworks.com> <20180829083110.42d85024@xeon-e3> <20180829155904.GA7133@jerin> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] mbuf: add IGMP packet type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Aug 2018 16:39:01 -0000 On Wed, 29 Aug 2018 21:29:05 +0530 Jerin Jacob wrote: > -----Original Message----- > > Date: Wed, 29 Aug 2018 08:31:10 -0700 > > From: Stephen Hemminger > > To: Jerin Jacob > > Cc: dev@dpdk.org, olivier.matz@6wind.com > > Subject: Re: [dpdk-dev] [PATCH] mbuf: add IGMP packet type > > > > External Email > > > > On Mon, 27 Aug 2018 18:08:35 +0530 > > Jerin Jacob wrote: > > > > > Add support for IGMP packet type. > > > > > > Signed-off-by: Jerin Jacob > > > > Could you add logic to recoginize IGMP to the software packet type identification > > rte_net_get_ptype used by drivers that don't have hardware support. > > If everyone agrees then I can do it as adding IGMP support will reduce > the performance of rte_net_get_ptype() and most of the NIC may not need it. Since IGMP is an IP protocol field and the code is already looking for TCP and UDP, how could adding another else slow it down in any observable way.