From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by dpdk.org (Postfix) with ESMTP id 858792B92 for ; Wed, 29 Aug 2018 18:47:06 +0200 (CEST) Received: by mail-pl1-f195.google.com with SMTP id s17-v6so2539951plp.7 for ; Wed, 29 Aug 2018 09:47:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xh+sLd/dv4w7Spld1/a3CQewYBRS5xiCF63H+loHDAA=; b=RtTRn/sRCmBwJaxr8OWVZ2jpd8ydzdtZtqvrl4e9RHfvQcuyvqWAoTl8p8nkQZnkFT O+BLK8/K8QdbfE9e+mOyJVSFXbexfeumya5T5NBPdD63T0+WnqHQnUxz95w9J9UQdBg0 ZVKR+h9enxolXs/EJUpwEDJWxjbDpJE3ZGOLelODy6l9CGAxQ89f3JdFolCkrWIInrLP JO4IW2X2WIkn+PR+pYemQg4Mdk2aeSdrnF0s31a5bDXzdDGkpSrtjkCb6C7elqYYaOAc R1rqNhguXn0X9mfvNPuYYiAIA69fziuYa3YJUQm3COO+PAp8m5+tndjXFHdf6IboAmJF jkfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xh+sLd/dv4w7Spld1/a3CQewYBRS5xiCF63H+loHDAA=; b=ceA269vnLPUV9Uu00KKIxKiORGSaEoj9g79grDn08uILFjMNaGSc1TfKpmpGnmZovJ 3iWfOu1hEu+JbRliln/fu5nrU0mcO1FqBm1vfN4TQu++at2wHLN2zENqgUKdUtRAT9yw Y4QPJc5bqev+d1/fNyE2YxzJI9eE94EmFK0AMFqIIxqLeSSXgVAA/211qOIBCJoAAb3c EdZS6pz4lWXEh3zNQ85Y0wAWrwQN4notszhYQJFBgyczGEIq++j62tX6zl51o5fH9GXr FzehLMixQg6yk+Ol8wD56DGZc6WokaInstJCDFO05GI+qDX0Xw/OizOlLTdSgAEnod9I cgmw== X-Gm-Message-State: APzg51A+4zsa299XWhoGzoG0KDtx/AonrsJjAQ1KTBbo5oq1m0hB1u2m YFES9Qs83I05tdbh5KmURD6y8g== X-Google-Smtp-Source: ANB0VdZODa8VlIG62WzZUJ6eIuPllx91g9p5xn6OLcFiwxl3tsmozKAY/YAfF/7PNQ0dK/CLx+24uQ== X-Received: by 2002:a17:902:6684:: with SMTP id e4-v6mr2960766plk.50.1535561225673; Wed, 29 Aug 2018 09:47:05 -0700 (PDT) Received: from xeon-e3 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id w131-v6sm3476249pfd.152.2018.08.29.09.47.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 29 Aug 2018 09:47:05 -0700 (PDT) Date: Wed, 29 Aug 2018 09:47:03 -0700 From: Stephen Hemminger To: "Burakov, Anatoly" Cc: Bruce Richardson , dev@dpdk.org, dpdk@stormmq.com Message-ID: <20180829094703.392988fc@xeon-e3> In-Reply-To: <8f3e6994-f509-c885-7f3c-6e791d04dee3@intel.com> References: <4f7ac27b4fe1561fd3e3358a89f89ce025a7a128.1535543250.git.anatoly.burakov@intel.com> <20180829123926.GB39260@bricha3-MOBL.ger.corp.intel.com> <8f3e6994-f509-c885-7f3c-6e791d04dee3@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 7/7] eal: improve musl compatibility X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Aug 2018 16:47:07 -0000 On Wed, 29 Aug 2018 15:09:47 +0100 "Burakov, Anatoly" wrote: > On 29-Aug-18 1:39 PM, Bruce Richardson wrote: > > On Wed, Aug 29, 2018 at 12:56:21PM +0100, Anatoly Burakov wrote: > >> Musl complains about pthread id being of wrong size. Fix it by > >> casting to 64-bit and printing 64-bit hex unconditionally. > >> > >> Signed-off-by: Anatoly Burakov > >> --- > > Given that on linux pthread_t is a pointer type, will this not give other > > warnings of casting from pointer to integer of a different type when > > compiling 32-bit? For safety I suggest casting to long or uintptr_t > > instead, to ensure we always get an int of the right size. > > > > /Bruce > > > > Sure, will fix. > > -- > Thanks, > Anatoly Maybe use gettid() to get thread id which is actually way more useful than the pointer value. Of course, glibc doesn't want to provide a syscall wrapper for this.