From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM04-SN1-obe.outbound.protection.outlook.com (mail-eopbgr700056.outbound.protection.outlook.com [40.107.70.56]) by dpdk.org (Postfix) with ESMTP id A10535A for ; Wed, 29 Aug 2018 17:59:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D5LTsAvfSmDm2wMRjgMEXW5CPknpnZrS6seEomO1aRU=; b=mJP2lz4SJSmwvIg/h0LWZRPwluBcODGVQR77xPeWsSfhfdchxb9y7zQj/zuL6+NllDmoEfi9Fy3+ng3WR3pVuqYj6jLQyeap6TdimjsZapeTgttjr7Ex/j9pHEhZHL83vj3vgn/+zZ2geOzJNgM74uZIGdmsgNAbJyb5jINRqAk= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (223.226.45.236) by BYAPR07MB5000.namprd07.prod.outlook.com (2603:10b6:a03:5b::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1080.14; Wed, 29 Aug 2018 15:59:19 +0000 Date: Wed, 29 Aug 2018 21:29:05 +0530 From: Jerin Jacob To: Stephen Hemminger Cc: dev@dpdk.org, olivier.matz@6wind.com Message-ID: <20180829155904.GA7133@jerin> References: <20180827123835.27531-1-jerin.jacob@caviumnetworks.com> <20180829083110.42d85024@xeon-e3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180829083110.42d85024@xeon-e3> User-Agent: Mutt/1.10.1 (2018-07-13) X-Originating-IP: [223.226.45.236] X-ClientProxiedBy: BM1PR01CA0071.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:1::11) To BYAPR07MB5000.namprd07.prod.outlook.com (2603:10b6:a03:5b::25) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: eb1888b0-a125-4461-16c9-08d60dc861da X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:BYAPR07MB5000; X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB5000; 3:j0szwkpuWROq2BvhQ4sjheLa5h4JgH+oQkVlLrrNBUmvxKoAeOcnbIS5LSv6P5Xox+5vxWX2BMr63/OgzfxP/KcM22pgZaBkYHcwSW76K3zHXH3mKNHAbA2219qKmoxP2mw4sP5p6VBX3/IUBYYn9urEtm1zCusfzPA2kjvpU3/fR7b1C2nQ6TVOnTM52z4oyzwbpIUUZ2CLja3W/tt2qduMa2pdKGobC2p8hadEryTDKQr9s3KxJa/NIEKjRGyr; 25:4N684sWQIi1TDGO48Twdbn0hZseIWOD8qDSO/IS7TftWnZpJ2lE1w7GUdYXVNteYqVf0ULIASMkI/k982RmHrvomSpSAyyd8yIuPP6HK7jJgya7iHK7MCYRQcMNKDFcVgQwpPex1QpOcMnKx9m118aUJuRvrOmlBplmHIs7Q+xAgVOwc1LKotfzIkVbzydo+fz9qyJhoQjbC+BooSHVDdeJI21BXH7lkNFr1ObOLLARDcZlj8pwyOI6/fQuA5TeTPlgXXOI3aLt1BPWD+zQG3vhp0a7WHjFyTFYHPwJovS44SPRXu8/Qv8d0GUH02IIn3RlxFCAzsjKRcowvnaMXfw==; 31:vmLQuU8wTLzOZw/VkTvgB6stoEbWHpyAaWfsTK6PCp03GtsocRpBPM00pIasha7O4s3JB7R//8oL2N8xm6nQPxjvLImgwk8B9AX15Mc3qRa+WYrpbg1dTZWx0Jte4G6zQy38YESpm3p3YqXZ8bfxiBOrqNRREtu4IllANMqKhThjfnbP/OiAlwZfnrDauMEGJHo4b4DLIpqwrXgJFAOBRmTvnuJb0bCg5jPGslXGzIo= X-MS-TrafficTypeDiagnostic: BYAPR07MB5000: X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB5000; 20:KHWoOZc+dlEhNfdbsWTEPHY/RFxgU6T3eqzEzEwpXyopYELJ/l1vyGcfHo04fMi49hO7A69MqtZHR76Ms75G6f+mpQgOW8jvbtZCAMc9JbjtC223DM3OhQ/8YtdzEt+syf94Kx2QAC2IJ19etdeVSgilzMPdlG3Y+X+GlAC8X/JrgvTJb8Ly738zBIxGe5USft6pxs4xd3r9kKH5UqE6hH79KtoAdBWCDeEYtyM9lnh+IzJ6w38H4dQZrvR7KD6XABWNr/Q/paQ2VoVlq1KasgHNma1ZYsbT5hVOblOU/HJol86m4rhCGrIrJEv1Juzc/LMXBLZxpgkmkyLwViLfxYHAR9rmqTDiHbCqJlmJZyNCGSA+dBJXOYdDOg5/3H6Oku2zfzrOLdMqeyFRAk+qLJDdeKv+2NqVR5eSWx81kZ9Pv9d4cPizK7V1Z+DS6wshmej/V5EOHzP9wlTId64rUfw9RvTGaEwOis8On0jNmcHOhgtdrxhiDrp9VKieQwwUVi06x4KG3PttUgEVjHA4EcPVEtptTzt/4T50RRod3TglALVGeuOkjITiNak43KYItA7ZxZ/O1aJiLId8e0/wDX1p57ACTKRpsPGfsd3DhVM=; 4:uwtoWW/+ycdgENxFce4cFCUWcduJ4K2dAeW9X9OAEEEapv6ck0K4CKeSbiQP6jsSSEGNPVmaiSbOjzzmnv8PJ8uxLY8KqU+Pyl3EP1JLxGer7kF/QRmLTKHWK7dhdDIs5pAVbPad5NbhMo6E8ioe4cUvUnDjRkXMjBBkFe4zcDRN1ygUsBd/OvI4p+03bHof19JfsKA8WfJxt7x3mndhvpWeVAYBu8FUh1srn3rZb+6kio9CH7f8u7rsQGCwlpqyVoR96CPXUa40LWebcCImeA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(3231311)(944501410)(52105095)(10201501046)(3002001)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201708071742011)(7699016); SRVR:BYAPR07MB5000; BCL:0; PCL:0; RULEID:; SRVR:BYAPR07MB5000; X-Forefront-PRVS: 077929D941 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(376002)(136003)(396003)(39860400002)(346002)(13464003)(189003)(199004)(6496006)(76176011)(25786009)(23726003)(68736007)(6116002)(8676002)(2906002)(6246003)(4326008)(3846002)(50466002)(81156014)(81166006)(1076002)(97736004)(8936002)(33656002)(52116002)(42882007)(72206003)(53936002)(476003)(106356001)(105586002)(33716001)(478600001)(229853002)(47776003)(44832011)(186003)(16586007)(305945005)(55016002)(66066001)(11346002)(6666003)(33896004)(956004)(6916009)(5660300001)(55236004)(58126008)(486006)(316002)(9686003)(386003)(446003)(7736002)(16526019)(26005)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR07MB5000; H:jerin; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BYAPR07MB5000; 23:4U/IlApiep0wJsy5y9j9g7NIrOyJwMEerao/b3ZgT?= =?us-ascii?Q?iy1Tc6eQVXsNKpwbCulZUSVXZWaKAVVrn0hUKq6UGmElP54g4hajHpkoWwhi?= =?us-ascii?Q?l6IIQdHqLa7dNUsGHHofpy3HEhiQBHiuqA/C2Pr79Cxn6zYiJ6V4JgzGvLgW?= =?us-ascii?Q?17BP9arN/lFWpAM4m4DwtbMIpdtv36inMdS9LvqXJ3g32L34tIrMbvpzgnJn?= =?us-ascii?Q?RuXSoM+Dhl35/r+eRikp2XO9605B9lhMBb1giaNQQf3EBhCJq3YhCXn+kjlX?= =?us-ascii?Q?2H25TVQhWlzQvuPi/u0CE/AUdtTrJ9SjjfJzNHthivmU7msHO8sqJMpc5E1i?= =?us-ascii?Q?679+Kn+nzK9SR5lLW56EH3RA41uEpBYTbEuVPC2UHFVQbvW7Vpq6wCde2hO9?= =?us-ascii?Q?/+LcIS7jxMFPZ61jvfv0xBZk8KDfWdlgtLCc0gQSR9FdTfNDS5fRGCe6utfS?= =?us-ascii?Q?M7GYHY70M6+y+HyvyoRdLsnMm7Z0khDjL9+K3WNMxOI9t9GMXnHF7NIIGnaf?= =?us-ascii?Q?gD1ClOHT4lQvW4mkgfn9Zxkg36tNpvQ2qU0qLX5sL0mpmIfbcK1AMUad8zjJ?= =?us-ascii?Q?rqs4683hj0/Z4IMK6D7m2Wpd6zyfkTf4NAFN9MgLsnC04C0JL0DZeaycfy8h?= =?us-ascii?Q?sUgk41zLxncmjbebiB4sqU1Bi4ro0f9Q2nWSkAaMTg96Q3lxZqQXFYyp5tjA?= =?us-ascii?Q?t0EQQDxHNMVoPUQ3/x90wDgcZsRToJPAOjqMVY1YMkMZQQs4peeebuK51GvF?= =?us-ascii?Q?YsofuojO/eimarzm5yphJzSSPMrV5otOXuu779SeBYr8byJueVNGxC97z8SL?= =?us-ascii?Q?YuWrl6i5E0b1Kfx+Ok82NxVrAY+ZINoQFxylUkuyxmigX2ZCLh734F5Mu3Nl?= =?us-ascii?Q?nMSOGVv5BR0kBpUeBAv0Mb+Ql4VmcoOG5OIt/2pE1v/s6OabtFri/T6YInDq?= =?us-ascii?Q?ON+XX33npjcQPnfRVJZJY/5knmoaTuDtu1lxDjsoEqqdpShjJbhCWrLnNR2e?= =?us-ascii?Q?mc4eBM8HwHCK4oQGTzpQ+N2P1Iit7+X/q+pBitS4Smg1ABt5DUGnG52giOwn?= =?us-ascii?Q?uFfjUsIyMJqApir0GEv63ImFNISa9LLMjTVQQogkl9j78odv+IDv2ZA40EWe?= =?us-ascii?Q?tZJ/7IQh+UtFr9In8vjiQWX1+H67GA2jYEJZnVBvyd8n0VfaXs23IVFy03VW?= =?us-ascii?Q?WcMHEdLihPfBcXOVllI6B4JAOpMXNsWHVfqkDrxSZdkMolnyqlZO5LgvmBUg?= =?us-ascii?Q?pPrYOvET7/1RBDue8IpTTtfaA4HzjAZYlcvW1Lef/G5sV/YFnIQ6H9s7w2N0?= =?us-ascii?Q?yhRl0FvU6rhuHYPjWdZJcrF1kswj6xOEkvnAzeUfBMX?= X-Microsoft-Antispam-Message-Info: tafEcP+vYFgrlVNC0qF4sHz8SE3Ebd/5zGnrAcC0FOTF7WhILAHoDVvdOWi9Pq85V1XwWHiUYsPiYtbqAho9GtLlN79P01QqPXS6rQkJ8dr8+sFRIYn/uEDoSzzNJHoPfKreS8+4UVgJ6umFbvodTu3ypPjkBqn1sNK4TwU2GUo20CgkF73dzOFz0z2/KVfq/i9fIZoWMadHvR8+fTu7we6OsOY4D4Tj479YzY/8TnkdDQgM7FYBFmHV5iwzmbMSSG8gnG72KstLwX4IndN/O8LtSS4nOGm8dgsMFQqCRH/ExQvEz9oQwG/RkwmTPTx5/YE07xdBNhi5QIxoQbwSR03AWKsBPRyUGjpyaxZwJOw= X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB5000; 6:6RUXuVyzCwO2oLH8cObJ2kH9vvhVkFKzytuYXL2Uj1U4uIokYDu0K+Bc2U9r3yrcgDk1c8Lmlk4BBZukHC8St5byWV5cx11phYg0EYcf6S/RDDypAMUzCleEvD4uesAeCu9/WYStgLg421jJnEeNt4GZTY5nHpsZhB/W5IfkGrNUnqgMggZaLJpVt2Nk2WIyL1Pw1seXqgnYebCrggp/H1XGdmBBpHIB2wZ8sQUuYON6AsCACoxecJ4nwPFRr/PeaT9c8ksGxGgQFNMonsPiazGdk8O3c/f9QtRAnTNahMV88BwHRASuNTWB/DeVRkGNW+vQe2LaJxfwPhI5W/sl6Y22Kh/i9Bb51VNi+ligDuoqlcx9vtn+TzHg07Z9xgIQpJon76MvOcT/C52/yW6m/Z+QHH0iu6phYwB2V65ZiA8svdeJdRaakSYGoRMDXGni6DWFwzjW+zBkJEekArbFSQ==; 5:RldqGpQIMFtQWBQRubo2UASy1AtAHFghlUW7RBx35lQpEdbZUZZTdKTCEyehirGqRenuwLrhVUurQMY1uHcdBwkgUnoTHp2VQ/FI7ZjxYCJmacAfs23QABU5MFitjsegNsBsJ8vy9mnyDMpCQDQ0OfbVpSpPuHXzBd7CUUp899A=; 7:9IBimzJMWgW1f2fcoXAempfh5vJ/m0wkvBTUxUOP110X9DqWMQQAqeaR2Ip71lwt/z+5QN0jTvSGhInDW8NarlU3QYttITZKPqwkDgom8uxaDDQX6ZGL+ebCL6Feq9t7TDDAdnHraRrr4B+VNRwqr5o+i8bntKDXQNkhvX4HddJsv0TGfJhTsIsGP7o6ULIboqz+9FiHsPgFhczDSCk29SagkRUbCZ0u4668UCEXYu9BmW+6KjeAJVSHaCsKvyOp SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2018 15:59:19.0181 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: eb1888b0-a125-4461-16c9-08d60dc861da X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB5000 Subject: Re: [dpdk-dev] [PATCH] mbuf: add IGMP packet type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Aug 2018 15:59:23 -0000 -----Original Message----- > Date: Wed, 29 Aug 2018 08:31:10 -0700 > From: Stephen Hemminger > To: Jerin Jacob > Cc: dev@dpdk.org, olivier.matz@6wind.com > Subject: Re: [dpdk-dev] [PATCH] mbuf: add IGMP packet type > > External Email > > On Mon, 27 Aug 2018 18:08:35 +0530 > Jerin Jacob wrote: > > > Add support for IGMP packet type. > > > > Signed-off-by: Jerin Jacob > > Could you add logic to recoginize IGMP to the software packet type identification > rte_net_get_ptype used by drivers that don't have hardware support. If everyone agrees then I can do it as adding IGMP support will reduce the performance of rte_net_get_ptype() and most of the NIC may not need it. Opinions? > > Also shouldn't this bit be part of RTE_PTYPE_L4_MASK? The RTE_PTYPE_L4_MASK is 0x00000f00 so it is part it. Right? >