From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0067.outbound.protection.outlook.com [104.47.41.67]) by dpdk.org (Postfix) with ESMTP id 1FCD0F11 for ; Wed, 29 Aug 2018 18:40:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rr7Lut5WZppkat3l+2+NcocMfZRTVSu7lSWHpBU7NWA=; b=U9GtlA88Acohxm3RLH7TrqC7jT6N17k2mafBULVIIChjpg2c01nX+aeGqRLKY7EYAGTgCdSmFMYHg5KdioXJvuk7kWq76dgD0vLMBlPA/y0woIJC7h7wTH+11v/Mkzb/89S3/3itWN7h9KWp05oLcvOmHIqZ/uayQ/sykOedx7o= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (223.226.45.236) by SN6PR07MB5006.namprd07.prod.outlook.com (2603:10b6:805:ac::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1080.17; Wed, 29 Aug 2018 16:40:42 +0000 Date: Wed, 29 Aug 2018 22:10:27 +0530 From: Jerin Jacob To: Stephen Hemminger Cc: dev@dpdk.org, olivier.matz@6wind.com Message-ID: <20180829164026.GA13511@jerin> References: <20180827123835.27531-1-jerin.jacob@caviumnetworks.com> <20180829083110.42d85024@xeon-e3> <20180829155904.GA7133@jerin> <20180829093436.3f06421f@xeon-e3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180829093436.3f06421f@xeon-e3> User-Agent: Mutt/1.10.1 (2018-07-13) X-Originating-IP: [223.226.45.236] X-ClientProxiedBy: SG2PR04CA0129.apcprd04.prod.outlook.com (2603:1096:3:16::13) To SN6PR07MB5006.namprd07.prod.outlook.com (2603:10b6:805:ac::32) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a2aed628-73b8-4024-0e66-08d60dce2a53 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:SN6PR07MB5006; X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB5006; 3:jbfd0EqVFp1niirveh/HnQKzi4kOjHf7/IcE4ZpBWr9q5K25WKSUBqZ5imxYMPMLMMb1rVCOmIePVAPCFGJqT7Y+HOyWxESxSRWZdGZeKgAZTlinnovRTlSMYQA58YXJQILaoVXXhHtmbaSHEY9orouKSuLDlNn/5DY+NtlMFSh2GLG0k8jt+6HByQrv03S3yymIeSiQF5JJyj3pSwg95gZepx0mHXuYfITjQLoWYllI8istDIOqXw9eRyGCBYIf; 25:6R3+QIY6/taCuPcZh6W/9S2hmw95p2/1JF+SXJ8z03UvATpxQSSaAwgGBoOW8Fe1yT5uQR0gIE2AK39/bdSKUeWXIadLEMqZi8ZLy7EqaU5LBebHBxrnyoKWhlEHMEQJg5K/T7JHAD9371DIgSva97ynnUNBoGAvhJJsCyunQ8kryFvRhQof00FzIqcnvJOppNmu61FJxrR1V5zyeauoUwn3PteS40Pa71eVcrg4CuUYowfJN0+azI6J3c+ZDfVtOlz22vEvesKAKKETLnIDXKSWlVxVDLM8/o4nDzEV8gxgYEzLjI0nzHRNZ8tG8is0VyvIazkQOxQdUIhXWDBngw==; 31:H8GIX8fnZ8pFBN8x/EJ6qjNgG+tvdvUM3xri4NuMCzWUKQuu/Qb0DT3EC7VZrbcLz+cYJ5NxVJS+9ddWCSxjmVtJVCzw0JJnSch4wGhI4iD8zmVIE/6ggp0ZYH/+a3jZaIWM2mGE+FZ+G0Q1GdfUtL1yLQ/3+Dt0Ue+O2jc0bQadGYOQCw9F0gQQi67+xLJi37iC9fbVcwl1Qg6sIP+//P3VfB3bcdXZP0yAn48pxm4= X-MS-TrafficTypeDiagnostic: SN6PR07MB5006: X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB5006; 20:pW/wUFJXOBTnKaXOArK+NDv9cS5S270EKOBVg3Kde9tn8SUIVuoUsLafg30HCAnwHB1uEArWLYHkUHR70Q7GL9pBi1ntPIrUCBJWf+UgWZhrWqzQ1jV06yVrKq74sURgb0Gy8Grq0/QxrAJSz4gEg70rKCKffE8Y+HKCkUNbmpI4YO1JxgC+KUg4yWfGGnecFvxEMFqvgEKW6uvvIpvW1XSeAIxAmNDKwUY3JhoFX3DbUllUbZAm1S+Hf5Eh0oPUm5J5+37zTLyzMoCdB9dMKOFHpDvhPmPitHoZsYqrn+jtAFMkkGHKaERbwFX959rEnvIebqlXHFLYoojFhgjdyhiJgWMEErTTZZwEKrb/gZUeRq7dkH+46evRRpdKt2YFE6KM6uFXFQi6kEVc8A6tF8cl7G0lAuSCi4DOuecKs9w9NZsnwrgYaSZBiMz9Go0gW8CP5v/xcX+sC9Wrr9WywbaJAtupop8JIPa7/BECnyPZZynZ3YD3IQFty+gndIAye4PhsVqfqoF/o5oRuerIQq3GvZ2u1q09tUrm2klPbUhVOtpLg2QzyOu8niUR7XsZP3YTyN8vZDGSDo/I27eY8TfxJmUP8SfayO9Xp25xBFQ=; 4:f8HunUjVuAHzCjoj6KU0Awnz4rT6PGZ3UfGJzvX8VqXNS8VpomCPeLpaifAhTIJ40ISlNSDMk+1VwtdYtvW95j2YyHMGN4VyoTrhV+lRFdR1jatNve/rqClvPH5JUjsAu5gA/GCf6OcxoJIzAf1wOH6A+towpcmy2npGZgYI2w3MZqm4P8HE+rjjG6Bi7rligui/+cw2DJAsm98KAQIp28ZEQhx4v0R47G+oNAj7VsHZt4rYDRIg710o8Qdsjn1Vr9G1ONNrKMOxzFobjRBZxg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(93006095)(3231311)(944501410)(52105095)(3002001)(149027)(150027)(6041310)(20161123562045)(20161123564045)(20161123560045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699016); SRVR:SN6PR07MB5006; BCL:0; PCL:0; RULEID:; SRVR:SN6PR07MB5006; X-Forefront-PRVS: 077929D941 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(346002)(366004)(376002)(136003)(39860400002)(13464003)(199004)(189003)(956004)(6116002)(53936002)(55016002)(6916009)(7736002)(16586007)(446003)(16526019)(186003)(33716001)(58126008)(50466002)(97736004)(25786009)(42882007)(476003)(6666003)(11346002)(9686003)(44832011)(5660300001)(6246003)(478600001)(229853002)(68736007)(305945005)(8936002)(6496006)(26005)(386003)(106356001)(486006)(8676002)(93886005)(1076002)(33656002)(33896004)(76176011)(52116002)(66066001)(2906002)(23726003)(105586002)(47776003)(81156014)(81166006)(72206003)(3846002)(55236004)(4326008)(316002)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN6PR07MB5006; H:jerin; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN6PR07MB5006; 23:NQX7IDuhe4/L4JaiSbeiT8AK9M3Cwd5YqivFQ+t/C?= =?us-ascii?Q?HS+MRCxmJYTKFNZKHn6hK78KP3Crwsb8efJrMlTQNhC5tL1aRBqTCzywaENO?= =?us-ascii?Q?Io+wjPjn/rZxR4BFD72de2jkp3cTUjMZmPzqQa4jxpvHj5uLVquY2YyhQmtk?= =?us-ascii?Q?m7Q2dRgAHzmThOflAHQu1mDSQRjIV/Lis7Q+DGp+uC50bNqpGVzJ0/hCgp6n?= =?us-ascii?Q?Vo8TdUZchT1PsVq3qQELy+qb59bFFK/k6UaLIVKIzrURbPDEHDs1E1R9FTK1?= =?us-ascii?Q?68DcnWAzXney3l7fCyITyWKzOqTm2CGaQ/V1MlCBw5lRwo4ZwRQpoYUKcJYo?= =?us-ascii?Q?WVfIwKiOj/86FCbfVMSaUEnUHrlrIvcHHdasF8iBJNEdvDe7soH9CwZEbSgV?= =?us-ascii?Q?i350R1HnBDsGiRmuH/ysM0FlCi3x4iu64VRKYjU5ISNAJoE2Bh7zjxVg0Hxi?= =?us-ascii?Q?B+K/qTrf9y7VG7GmkJMtepOEv5l9iSLG5vOJo52EBHgBf+yl+RCNQEcCkA+n?= =?us-ascii?Q?plRxu9sKBAZiL8bR2i0H7yvSG5ezo+32QJH+16VWWKSyFr5N2dyA0y0jDF2+?= =?us-ascii?Q?UZc2sAe8r/Vku+dpE/ApcAIkBi/S2LAo7J87VVKjOu4Ng+u5DfLqyxnwZivv?= =?us-ascii?Q?567mDUA/MLgKoVtPriiQJuD1xjh4m59II1eeU7DwyRp6faD2SClL1g0VoevW?= =?us-ascii?Q?eP9D4isjEk8x8Dfr3mvrjM6IIW/oa2Cpd0G4rPmcf1XvZbLDusTEMpQfqmHQ?= =?us-ascii?Q?E3lPgWWLzNPV9brkiv5Eo8AGlvLbKxsACL+TiaPthlcje4HhN/NRjYWTx1Lv?= =?us-ascii?Q?eQ3EU2HluMV0npxmi2Uz4CTB0l1+OgUba+CwNO68LplXdyiRikCKrK30ljLo?= =?us-ascii?Q?oDV/80UCai2NVvz5fckeobKFhCw0YcY1XK/hE+DHkVlYYW7SotoP8t92sZbX?= =?us-ascii?Q?4hDGasYFPEjqK1d9VAxKVzNCG7OQd6yaiVhl97Pu050FESi+FUTyrEnCpfC+?= =?us-ascii?Q?SFqe0kS9azrH1sHmS0/GTVJxMcY843CKkj2Y1K33gZA3vMSCVot+vjcLtQGF?= =?us-ascii?Q?dq/Aqo22Ee2Wn+dlrgizxiC6zkzwvNhSbSO7hY1Z7EpgZF2o5REHMLx1teCb?= =?us-ascii?Q?BppmYus8DyrexeFuGbwb820BiQD861CoOkQLLKGZF7aYExAPbMxeLKlv16/P?= =?us-ascii?Q?p1Crg4AFZiU+sEnUXZYi+puM16/52NYJO3C9Z572ZmPF99vim66JF4l20gfq?= =?us-ascii?Q?jr1+D47jQHZIsr3wLpJxu2ccAi2h6Scp/+NUleybfqurzg6IGaCEIp7araqh?= =?us-ascii?Q?07lzjWV5U7ol30ruqAUquKk3osHd/URH/jHChWT4PEPoE5V/IqFt/e55Biu/?= =?us-ascii?Q?kr/Qg=3D=3D?= X-Microsoft-Antispam-Message-Info: WXKTIoAZZ9McqUr2zraw6i++AZW3ToDJEHWhS9x1vE0hB2Q2j1WYphFh7jYg7WK8TADYiHXSUnMjzqLa104QBoSpc3v/JUm5+1UscGXFC/8vOdTHQLoY02dRNRwqAtJ1tNZiQjN0kJnuAmKkXzYLjhU1X+1JoHka+Zm0TklzS13lkDDhnxg/F180T+KSWj+fpuJ7AI7gtwdZW78KuBcqocpopSDCQv6WNLxOdaDpE5BJylQbzCB8FP+a9uge79HTZOfVboZST2nvD9bGJeV58pBSW9QZR68C48NQiRdwXx2/vlttyTcZoGOXJm7tGr3VkgV/hG8OBngK/it+5pGkW+4aUn4lVQV8WGzmJNQ27LA= X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB5006; 6:JS2CDLQvxGYqcwgxfQ9y5X99aO0TDbpAZWfTIWyAnvTvNcnlNom0U/qM+N7vEGEI9hhaQz8gAh12JI1eF4TX+CM+or5YrRdo0cD8tQAvlabfcRmfHtn3zED91VLa2bRV+lGuuB1wdqVGITTruidu3ss4oYxFmzUAvcopSFfhmUo/UMJZlquC/S7//JhOxcpObQ3BqCAIcqvk8bavW+rglB1Az9AExRywCjkUjEQnJTPvIkLdPLFFsrUUQHUCDd8bp/I46+d1GWqM8/bdlh0JhGuFTJo9XyODVoJS4Eap/KdtNaIIyaJZ/XhQMqCgC9K13Ups3R1OodK5EY6fEFLaGo8p5ykg/x4h6rfxWleStdF7u/hjstxl0i//JoOT92OgofQi7f/5XvArLSETkvwmvdKvv+m5o/+2ZdmPLjaFlITq8X42p336OFATK3mwpgyTTc2F9nAYVbr6KwhwXiNXZw==; 5:vGJoPehZVWreu5MbSj0Mmya3L014RB2CGl8/pRJSCsRnezt/rWzmPHyfcpHYxYp+32gvtvHNZ9/6xjeeYHzN57sBryAufcf2coQ/D0Hs6nvBImtdr3ByvL0puGF03Tl1hzoUk1plqLm7mrOQrUSPwUYZw+eLaKRlGNC9HqCLTeo=; 7:conSTe9x3+/SSWXPyTTxVQbB/B6r+CQEimfoSbILD1gQ0x4NygVFnO8AjcmZRcl8F/A3DzMa6w5RJS4EIuXSW5U0KGrrX6VdcQorUK5O0UhZ2RCRvfgdowVDtB4fUzvaaxyO40dePEVGOEblIRE/6LkyRxA6og2VWqrW/ykb2DisaiAxVf/zqp3wGpMYfP8RlLtWSW5yQI+ZQUyjVCpnu4sxsDpAulIRuHhnBsJE1u6Mted1uxFOQM5VEHKzk/ZM SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2018 16:40:42.8713 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a2aed628-73b8-4024-0e66-08d60dce2a53 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR07MB5006 Subject: Re: [dpdk-dev] [PATCH] mbuf: add IGMP packet type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Aug 2018 16:40:46 -0000 -----Original Message----- > Date: Wed, 29 Aug 2018 09:34:36 -0700 > From: Stephen Hemminger > To: Jerin Jacob > Cc: dev@dpdk.org, olivier.matz@6wind.com > Subject: Re: [dpdk-dev] [PATCH] mbuf: add IGMP packet type > > External Email > > On Wed, 29 Aug 2018 21:29:05 +0530 > Jerin Jacob wrote: > > > -----Original Message----- > > > Date: Wed, 29 Aug 2018 08:31:10 -0700 > > > From: Stephen Hemminger > > > To: Jerin Jacob > > > Cc: dev@dpdk.org, olivier.matz@6wind.com > > > Subject: Re: [dpdk-dev] [PATCH] mbuf: add IGMP packet type > > > > > > External Email > > > > > > On Mon, 27 Aug 2018 18:08:35 +0530 > > > Jerin Jacob wrote: > > > > > > > Add support for IGMP packet type. > > > > > > > > Signed-off-by: Jerin Jacob > > > > > > Could you add logic to recoginize IGMP to the software packet type identification > > > rte_net_get_ptype used by drivers that don't have hardware support. > > > > If everyone agrees then I can do it as adding IGMP support will reduce > > the performance of rte_net_get_ptype() and most of the NIC may not need it. > > > > Opinions? > > > > > > > > Also shouldn't this bit be part of RTE_PTYPE_L4_MASK? > > > > The RTE_PTYPE_L4_MASK is 0x00000f00 so it is part it. Right? > > Then you must add it to the software matcher since most drivers are advertising L4_MASK Which driver returns .dev_supported_ptypes_get ethdev ops with L4_MASK? >