DPDK patches and discussions
 help / color / mirror / Atom feed
From: Tiwei Bie <tiwei.bie@intel.com>
To: Rami Rosen <ramirose@gmail.com>
Cc: dev@dpdk.org, stable@dpdk.org, maxime.coquelin@redhat.com,
	zhihong.wang@intel.com, yuanhan.liu@linux.intel.com
Subject: Re: [dpdk-dev] [PATCH] examples/vhost: remove unnecessary MAX_PRINT_BUFF defintion
Date: Thu, 30 Aug 2018 12:40:58 +0800	[thread overview]
Message-ID: <20180830044057.GA15599@fbsd.sh.intel.com> (raw)
In-Reply-To: <20180825192240.6503-1-ramirose@gmail.com>


> [PATCH] examples/vhost: remove unnecessary MAX_PRINT_BUFF defintion

s/defintion/definition/

Apart from that,

Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>

Thanks

On Sat, Aug 25, 2018 at 10:22:40PM +0300, Rami Rosen wrote:
> This patch removes an unnecessary definition of MAX_PRINT_BUFF 
> in examples/vhost/main.c, since it is no longer being used.
> 
> Fixes: 68363d85857d ("examples/vhost: remove the non-working zero copy code").
> 
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
> ---
>  examples/vhost/main.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/examples/vhost/main.c b/examples/vhost/main.c
> index 2175c1186..5d28d03f6 100644
> --- a/examples/vhost/main.c
> +++ b/examples/vhost/main.c
> @@ -58,9 +58,6 @@
>  /* Max number of devices. Limited by vmdq. */
>  #define MAX_DEVICES 64
>  
> -/* Size of buffers used for snprintfs. */
> -#define MAX_PRINT_BUFF 6072
> -
>  /* Maximum long option length for option parsing. */
>  #define MAX_LONG_OPT_SZ 64
>  
> -- 
> 2.17.1
> 

  reply	other threads:[~2018-08-30  4:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-25 19:22 Rami Rosen
2018-08-30  4:40 ` Tiwei Bie [this message]
2018-09-10 13:30 ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180830044057.GA15599@fbsd.sh.intel.com \
    --to=tiwei.bie@intel.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=ramirose@gmail.com \
    --cc=stable@dpdk.org \
    --cc=yuanhan.liu@linux.intel.com \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).