From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 31341F11 for ; Thu, 30 Aug 2018 07:22:34 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Aug 2018 22:22:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,306,1531810800"; d="scan'208";a="87503395" Received: from fbsd.sh.intel.com ([10.67.104.231]) by orsmga002.jf.intel.com with ESMTP; 29 Aug 2018 22:22:31 -0700 Date: Thu, 30 Aug 2018 13:20:14 +0800 From: Tiwei Bie To: eric zhang Cc: maxime.coquelin@redhat.com, zhihong.wang@intel.com, dev@dpdk.org, Allain.Legacy@windriver.com, Matt.Peters@windriver.com Message-ID: <20180830052014.GA84594@fbsd.sh.intel.com> References: <1535558121-10034-1-git-send-email-eric.zhang@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1535558121-10034-1-git-send-email-eric.zhang@windriver.com> User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH v3] net/virtio-user: check negotiated features before set X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Aug 2018 05:22:34 -0000 On Wed, Aug 29, 2018 at 11:55:21AM -0400, eric zhang wrote: > This patch checks negotiated features to see if necessary to offload > before set the tap device offload capabilities. It also checks if kernel > support the TUNSETOFFLOAD operation. Fixes: 5e97e4202563 ("net/virtio-user: enable offloading") Cc: stable@dpdk.org Reviewed-by: Tiwei Bie Thanks! > > Signed-off-by: eric zhang > > --- > v3: > * make other offloading features depend on CSUM > * check IFF_VNET_HDR support when handling VHOST_GET_FEATURES > > --- > v2: > * don't return failure when failed to set offload to tap > * check if offloads available when handling VHOST_GET_FEATURES > --- > drivers/net/virtio/virtio_user/vhost_kernel.c | 18 +++++--- > drivers/net/virtio/virtio_user/vhost_kernel_tap.c | 56 +++++++++++++++++------ > drivers/net/virtio/virtio_user/vhost_kernel_tap.h | 2 +- > 3 files changed, 54 insertions(+), 22 deletions(-) >