From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by dpdk.org (Postfix) with ESMTP id 16A622BA3 for ; Fri, 31 Aug 2018 10:26:05 +0200 (CEST) Received: by mail-wm0-f65.google.com with SMTP id j192-v6so4504829wmj.1 for ; Fri, 31 Aug 2018 01:26:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=jumwA/KOnDNRWE3hS1tnIar28fMSrLa6eH9gJLqPdGQ=; b=Knfp7U3qYpbN94lga7wh/XvNevupPFJQzzLWIewdZtkRQHlq7o5urbKehVgZYXwdas i8RnjMoQ1nQJwIyukQFW5B5WgsHjDIHq9/ZstyqSTDBtrr4Y8/6F41z4dC1MQDfFgbSU K2wKHow+8BlaieqKyV09TNI8erXclZdabKc8jxIcc2jH88fw8bDhEsUqs/2UF1VhQFWE cT4PNN/fHRBdJGTGMNTosnoKq1YbNpAXW85ItCg1+dpLxlLbI8lcXgyq7ylFoV1j/dLA fxWJBicuYEzFFu7W9ylBFrL8z7lsrlHB6t25kH4xTkIsXasoRQytoe0UwhQIMK+IqOd5 m+pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=jumwA/KOnDNRWE3hS1tnIar28fMSrLa6eH9gJLqPdGQ=; b=aNWv4H0zXq1qLZ0KQ3OMDKBBohufXMB7sT+/KcOoL/qX5Bisnc/CnwAgnNTjA5mKI4 DV9Xc+DQnlTDncpSpvrH1E27yu5ZUKnrywtxoBzUQqMPkj4cgIB72y24ggKLcfPhPWQ1 vSa+DwZktepQ5VEoasd+pZ4KEsZgB8KxX04he8wccel1EDz8C4YvLFXVucy8k33fCjc9 Q8WamjMmoJw7sJLPpQPAtOuW4XROTEZTwenYo+Eu9rFTrMHj3UdhbONrKj5/WLcAUisN YpYQeHaiRh6W9XWdSVaSFlzg/DyA9VQUOACEAR/hKwNbGsyYqW7MgnDteb3bIAMyd0qS fusQ== X-Gm-Message-State: APzg51CTVhi3fr7HcymT2cUM4qZePcOBBMkjyEWNrLzjg1wogNjXIZYk oz2QhhmRLaGAMRaz/bYQBnv4Aw== X-Google-Smtp-Source: ANB0VdaIGQLMxizalTOIJCGilxszzNfKvNX7z+6n6+/tya30DOg7wWduzX+h52nVLBdag4VSjZki2A== X-Received: by 2002:a1c:b143:: with SMTP id a64-v6mr4213686wmf.114.1535703964470; Fri, 31 Aug 2018 01:26:04 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id d12-v6sm10927870wru.36.2018.08.31.01.26.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 31 Aug 2018 01:26:03 -0700 (PDT) Date: Fri, 31 Aug 2018 10:25:47 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Stephen Hemminger Cc: dev@dpdk.org, Stephen Hemminger Message-ID: <20180831082547.s3xm3tb7keruam6m@bidouze.vm.6wind.com> References: <20180830223512.21297-1-stephen@networkplumber.org> <20180830223512.21297-5-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180830223512.21297-5-stephen@networkplumber.org> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH 4/5] net/netvsc: implement link state change callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Aug 2018 08:26:05 -0000 Hi Stephen, On Thu, Aug 30, 2018 at 03:35:11PM -0700, Stephen Hemminger wrote: > From: Stephen Hemminger > > Implement callback functionality on link state changes. > This is not really driven off of interrupt file descriptor like most other > PMD's. Instead, it happens when a link state change message arrives > in the common ring buffer. > Does this mean that the lsc event will be processed in a dataplane thread? Looking at the _rte_eth_dev_callback_process() call, it seems so. Shouldn't this be executed in the context of the eal-intr-thread instead? This thread is marked control and should be configured with the proper afinity, unless dataplane threads. Maybe I missed something, it's just to double-check that this will behave nicely with applications relying on the eal-intr-thread afinity. -- Gaëtan Rivet 6WIND