From: Bruce Richardson <bruce.richardson@intel.com>
To: Luca Boccassi <bluca@debian.org>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 4/4] build: install igb_uio kernel module when building with Meson
Date: Fri, 31 Aug 2018 11:15:21 +0100 [thread overview]
Message-ID: <20180831101520.GA19592@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20180831092029.4887-4-bluca@debian.org>
On Fri, Aug 31, 2018 at 10:20:29AM +0100, Luca Boccassi wrote:
> Install in $kerneldir/../extra/dpdk. Usually $kerneldir should something
> like: /lib/modules/$kver/build, so this directory will match the default
> one used by legacy makefiles.
>
> Fixes: a52f4574f798 ("igb_uio: build with meson")
>
> Signed-off-by: Luca Boccassi <bluca@debian.org>
> ---
> kernel/linux/igb_uio/meson.build | 2 ++
> meson_options.txt | 2 +-
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/linux/igb_uio/meson.build b/kernel/linux/igb_uio/meson.build
> index 71ed2e7a85..f5a9d5ccf3 100644
> --- a/kernel/linux/igb_uio/meson.build
> +++ b/kernel/linux/igb_uio/meson.build
> @@ -15,4 +15,6 @@ custom_target('igb_uio',
> '/../../../lib/librte_eal/common/include',
> 'modules'],
> depends: mkfile,
> + install: true,
> + install_dir: kernel_dir + '/../extra/dpdk',
> build_by_default: get_option('enable_kmods'))
> diff --git a/meson_options.txt b/meson_options.txt
> index c843278587..f452986da3 100644
> --- a/meson_options.txt
> +++ b/meson_options.txt
> @@ -7,7 +7,7 @@ option('examples', type: 'string', value: '',
> option('include_subdir_arch', type: 'string', value: '',
> description: 'subdirectory where to install arch-dependent headers')
> option('kernel_dir', type: 'string', value: '',
> - description: 'path to the kernel for building kernel modules')
> + description: 'path to the kernel for building kernel modules, they will be installed in $prefix/$kernel_dir/../extra/dpdk')
Will $prefix be used in the install path? I thought it would be $DEST_DIR?
next prev parent reply other threads:[~2018-08-31 10:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-31 9:20 [dpdk-dev] [PATCH 1/4] build: include missing hypervisor files in Meson build Luca Boccassi
2018-08-31 9:20 ` [dpdk-dev] [PATCH 2/4] build: use -Wno-error=format-security for Meson ifpga_rawdev build Luca Boccassi
2018-08-31 10:17 ` Bruce Richardson
2018-08-31 10:35 ` Luca Boccassi
2018-08-31 9:20 ` [dpdk-dev] [PATCH 3/4] build: use -Wno-error=format-security for Meson i40e build Luca Boccassi
2018-08-31 9:20 ` [dpdk-dev] [PATCH 4/4] build: install igb_uio kernel module when building with Meson Luca Boccassi
2018-08-31 10:15 ` Bruce Richardson [this message]
2018-08-31 10:19 ` Luca Boccassi
2018-08-31 10:41 ` [dpdk-dev] [PATCH v2 1/4] build: include missing hypervisor files in Meson build Luca Boccassi
2018-08-31 10:41 ` [dpdk-dev] [PATCH v2 2/4] build: use -Wno-error=format-security for Meson ifpga_rawdev build Luca Boccassi
2018-08-31 11:01 ` Bruce Richardson
2018-08-31 10:41 ` [dpdk-dev] [PATCH v2 3/4] build: use -Wno-error=format-security for Meson i40e build Luca Boccassi
2018-08-31 11:01 ` Bruce Richardson
2018-08-31 10:41 ` [dpdk-dev] [PATCH v2 4/4] build: install igb_uio kernel module when building with Meson Luca Boccassi
2018-08-31 11:06 ` Bruce Richardson
2018-08-31 11:00 ` [dpdk-dev] [PATCH v2 1/4] build: include missing hypervisor files in Meson build Bruce Richardson
2018-09-16 9:00 ` Thomas Monjalon
2018-09-17 8:20 ` Bruce Richardson
2018-09-17 9:01 ` Luca Boccassi
2018-09-17 9:01 ` [dpdk-dev] [PATCH v3 " Luca Boccassi
2018-09-17 9:01 ` [dpdk-dev] [PATCH v3 2/4] build: use -Wno-error=format-security for Meson ifpga_rawdev build Luca Boccassi
2018-09-17 9:01 ` [dpdk-dev] [PATCH v3 3/4] build: use -Wno-error=format-security for Meson i40e build Luca Boccassi
2018-09-17 9:01 ` [dpdk-dev] [PATCH v3 4/4] build: install igb_uio kernel module when building with Meson Luca Boccassi
2018-09-17 10:20 ` [dpdk-dev] [PATCH v3 1/4] build: include missing hypervisor files in Meson build Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180831101520.GA19592@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=bluca@debian.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).