From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id CFF7C8E60 for ; Fri, 31 Aug 2018 16:24:38 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Aug 2018 07:24:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,311,1531810800"; d="scan'208";a="67455602" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.107]) by fmsmga008.fm.intel.com with SMTP; 31 Aug 2018 07:24:19 -0700 Received: by (sSMTP sendmail emulation); Fri, 31 Aug 2018 15:24:18 +0100 Date: Fri, 31 Aug 2018 15:24:18 +0100 From: Bruce Richardson To: Luca Boccassi Cc: Thomas Monjalon , dev@dpdk.org Message-ID: <20180831142418.GA3024@bricha3-MOBL.ger.corp.intel.com> References: <20180831135132.14730-1-thomas@monjalon.net> <1535724642.11823.26.camel@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1535724642.11823.26.camel@debian.org> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH] build: get version number from header file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Aug 2018 14:24:39 -0000 On Fri, Aug 31, 2018 at 03:10:42PM +0100, Luca Boccassi wrote: > On Fri, 2018-08-31 at 15:51 +0200, Thomas Monjalon wrote: > > The header file rte_version.h should be the unique place > > to define the version number. > > The makefile command "showversion" makes it accessible, > > and it is used to set the meson project version with an external > > command. > > > > Signed-off-by: Thomas Monjalon > > --- > > > > I don't know how to check easily the meson version number. > > Please help in testing, thanks. > > > > --- > >  meson.build | 2 +- > >  1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/meson.build b/meson.build > > index 84af32ece..b9d1030e7 100644 > > --- a/meson.build > > +++ b/meson.build > > @@ -2,7 +2,7 @@ > >  # Copyright(c) 2017 Intel Corporation > >   > >  project('DPDK', 'C', > > - version: '18.11-rc0', > > + version: run_command('make', > > 'showversion').stdout().strip(), > >   license: 'BSD', > >   default_options: ['buildtype=release', > > 'default_library=static'], > >   meson_version: '>= 0.41' > > Isn't the ultimate end goal to remove the makefiles? If so, shouldn't > meson be independent? > > -- I would tend to agree. I also think that the rte_version.h file is the wrong place to put the version info, it would be better specified somewhere at the root of the tree. Therefore, I think that the toplevel makefile and meson.build files should have the version number there and then auto-generate the rte_version.h file based on that information. /Bruce