From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 5600B5F27 for ; Mon, 3 Sep 2018 16:40:18 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20180903144017euoutp01ac293fd0868a7ffd61108decebfaa3cc~Q6sfpxQx01511215112euoutp01I for ; Mon, 3 Sep 2018 14:40:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20180903144017euoutp01ac293fd0868a7ffd61108decebfaa3cc~Q6sfpxQx01511215112euoutp01I DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1535985617; bh=YjvAMCqMTYH43VcdqF+AoeBqchGSxQzIo/bOMZbPXJY=; h=Subject:To:From:Date:In-Reply-To:References:From; b=t1nqQDeYnvKUzZhbV6Astkxcqc9GRKPYr6QqARSNIRM3kp21x91bJsCIPAhZfOBpI 2+VOty2jonpko/vgfVKkVZ1OzurUVzQ6A+HrzSiOZr5LgXWkRk7uaZSJurXxYQhlv8 kZBKpMg6o3MaGIRl7Hpx/683rX9edFI4+y+kTzgc= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20180903144016eucas1p22065f1c298e9ef113dae1dea4e3471ae~Q6sfHjGmp2201122011eucas1p2R; Mon, 3 Sep 2018 14:40:16 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 00.20.04294.0D74D8B5; Mon, 3 Sep 2018 15:40:16 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20180903144015eucas1p2f4bee75a7eaccc76e158ae51482764c9~Q6seLK6ys2201122011eucas1p2Q; Mon, 3 Sep 2018 14:40:15 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20180903144015eusmtrp1d5b808eaca55f4d3bd8a0280f0b0adbf~Q6sd5Fesv1578915789eusmtrp1O; Mon, 3 Sep 2018 14:40:15 +0000 (GMT) X-AuditID: cbfec7f4-84fff700000010c6-83-5b8d47d09e5f Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id E5.78.04284.FC74D8B5; Mon, 3 Sep 2018 15:40:15 +0100 (BST) Received: from [106.109.129.180] (unknown [106.109.129.180]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20180903144015eusmtip2f5a9c4766d5b26c4cc32197ebf3acd86~Q6sdo4o0M0318203182eusmtip26; Mon, 3 Sep 2018 14:40:15 +0000 (GMT) To: Bruce Richardson , dev@dpdk.org From: Ilya Maximets Date: Mon, 3 Sep 2018 17:41:46 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180831133510.3121-1-bruce.richardson@intel.com> Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupmleLIzCtJLcpLzFFi42LZduznOd0L7r3RBnOPiFncWGVv8e7TdiaL K+0/2R2YPX4tWMrqsXjPSyaPvi2rGAOYo7hsUlJzMstSi/TtErgynu7uYC+4rFyx6fIKxgbG b7JdjJwcEgImEhPefmPrYuTiEBJYwSgxYfIsKOcLo8T5u7eZIZzPjBKfX8xigmk5fauRFSKx nFFi59kXTBDOR0aJl/e72UCqhAV8JKa//c8OYosI2Etc330MzGYT0JE4tfoII4jNIqAisX/1 K7CpogIREkceLASL8woISpyc+YQFxOYE6r2/4g1YnFlAXKLpy0pWCFteYvvbOWDnSQh8ZpN4 178QyOEAai6TWD1XGMSUEHCR2PtNBuJoYYlXx7ewQ9gyEqcn97BA2PUS91teMkKM6WCUmH7o H9SX9hJbXp9jB5nDLKApsX6XPkTYUeLErLfMEOP5JG68FYS4hk9i0rbpUGFeiY42IYhqFYnf B5czQ9hSEjfffYa6wENiwtbZrBMYFWch+XcWkh9nIflxFsINCxhZVjGKp5YW56anFhvlpZbr FSfmFpfmpesl5+duYgQmkdP/jn/ZwbjrT9IhRgEORiUe3gCD3mgh1sSy4srcQ4wSHMxKIrz7 nYFCvCmJlVWpRfnxRaU5qcWHGKU5WJTEefm00qKFBNITS1KzU1MLUotgskwcnFINjLHse+zy mQ6aVTyxXhFew2NVE7Qnxurw/W23fDV/S/J0tUdJzJG69fBIzPlzP8/s49226tvz1JRV/VdL Ihi3XIm1lPjIW61TJSo/KX/ucrnHQRnXVjHpXF6zdp+Pk+aC29H3zu9L3hE0neviUrc0yZNx G8ITeFMdtZ936nOLPvoYssDvvN9qByWW4oxEQy3mouJEAGc9LgYeAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprMIsWRmVeSWpSXmKPExsVy+t/xe7rn3XujDf41ilncWGVv8e7TdiaL K+0/2R2YPX4tWMrqsXjPSyaPvi2rGAOYo/RsivJLS1IVMvKLS2yVog0tjPQMLS30jEws9QyN zWOtjEyV9O1sUlJzMstSi/TtEvQynu7uYC+4rFyx6fIKxgbGb7JdjJwcEgImEqdvNbJ2MXJx CAksZZQ493wdO0RCSuLHrwusELawxJ9rXWwQRe8ZJb413AMrEhbwkZj+9j+YLSJgL3F99zEw W0hgEtCkM4ogNpuAjsSp1UcYQWxeATuJn+vPMIHYLAIqEvtXvwKzRQUiJFYvf8EKUSMocXLm ExYQmxNo5v0Vb8B6mQXUJf7Mu8QMYYtLNH1ZyQphy0tsfzuHeQKj4Cwk7bOQtMxC0jILScsC RpZVjCKppcW56bnFhnrFibnFpXnpesn5uZsYgRGy7djPzTsYL20MPsQowMGoxMMbYNAbLcSa WFZcmXuIUYKDWUmEd78zUIg3JbGyKrUoP76oNCe1+BCjKdBzE5mlRJPzgdGbVxJvaGpobmFp aG5sbmxmoSTOe96gMkpIID2xJDU7NbUgtQimj4mDU6qBscH/95ZgBZfIpdbLL1wW8uDftXd1 VJ9FAqNuzoU0XZEPU6r051ybHdzQEvB5eVyGxPr1wY9i7oT9XW8/W8XzEHOgRYR5347Y45rV HyfZSGy1C5uiLNt7nrFefcPzubumz3ZIP8vHl2u8aNrKLarTU2dPc2KN3/1efMmbknPmStqx MmU3CzsuKbEUZyQaajEXFScCAEzA0PemAgAA Message-Id: <20180903144015eucas1p2f4bee75a7eaccc76e158ae51482764c9~Q6seLK6ys2201122011eucas1p2Q@eucas1p2.samsung.com> X-CMS-MailID: 20180903144015eucas1p2f4bee75a7eaccc76e158ae51482764c9 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20180831133527epcas4p1039efdef614bebf49d048846927a68a2 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20180831133527epcas4p1039efdef614bebf49d048846927a68a2 References: <20180831133510.3121-1-bruce.richardson@intel.com> Subject: Re: [dpdk-dev] [PATCH] net/*/base: allow use of experimental APIs in base code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Sep 2018 14:40:18 -0000 On 31.08.2018 16:35, Bruce Richardson wrote: > The driver setting of "allow_experimental_apis" was not being used when > building the base code. To allow this we can manually put in a check > in the base code files for the setting and set the appropriate cflag > if it's needed. > > Signed-off-by: Bruce Richardson Tested-by: Ilya Maximets > --- > drivers/net/e1000/base/meson.build | 3 +++ > drivers/net/fm10k/base/meson.build | 3 +++ > drivers/net/i40e/base/meson.build | 3 +++ > drivers/net/ixgbe/base/meson.build | 3 +++ > drivers/net/octeontx/base/meson.build | 6 +++++- > drivers/net/sfc/base/meson.build | 3 +++ > drivers/net/thunderx/base/meson.build | 6 +++++- > 7 files changed, 25 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/e1000/base/meson.build b/drivers/net/e1000/base/meson.build > index 5e1716def..f26f24298 100644 > --- a/drivers/net/e1000/base/meson.build > +++ b/drivers/net/e1000/base/meson.build > @@ -25,6 +25,9 @@ error_cflags = ['-Wno-uninitialized', '-Wno-unused-parameter', > '-Wno-unused-variable', '-Wno-misleading-indentation', > '-Wno-implicit-fallthrough'] > c_args = cflags > +if allow_experimental_apis > + c_args += '-DALLOW_EXPERIMENTAL_API' > +endif > foreach flag: error_cflags > if cc.has_argument(flag) > c_args += flag > diff --git a/drivers/net/fm10k/base/meson.build b/drivers/net/fm10k/base/meson.build > index a8fc5fa8b..5525cdc82 100644 > --- a/drivers/net/fm10k/base/meson.build > +++ b/drivers/net/fm10k/base/meson.build > @@ -15,6 +15,9 @@ error_cflags = ['-Wno-unused-parameter', '-Wno-unused-value', > '-Wno-unused-variable', '-Wno-missing-field-initializers' > ] > c_args = cflags > +if allow_experimental_apis > + c_args += '-DALLOW_EXPERIMENTAL_API' > +endif > foreach flag: error_cflags > if cc.has_argument(flag) > c_args += flag > diff --git a/drivers/net/i40e/base/meson.build b/drivers/net/i40e/base/meson.build > index e6163eaa6..d4c8f872d 100644 > --- a/drivers/net/i40e/base/meson.build > +++ b/drivers/net/i40e/base/meson.build > @@ -16,6 +16,9 @@ error_cflags = ['-Wno-sign-compare', '-Wno-unused-value', > '-Wno-strict-aliasing', '-Wno-unused-but-set-variable' > ] > c_args = cflags > +if allow_experimental_apis > + c_args += '-DALLOW_EXPERIMENTAL_API' > +endif > foreach flag: error_cflags > if cc.has_argument(flag) > c_args += flag > diff --git a/drivers/net/ixgbe/base/meson.build b/drivers/net/ixgbe/base/meson.build > index 3147e1101..21ac64bf5 100644 > --- a/drivers/net/ixgbe/base/meson.build > +++ b/drivers/net/ixgbe/base/meson.build > @@ -20,6 +20,9 @@ sources = [ > error_cflags = ['-Wno-unused-value', > '-Wno-unused-but-set-variable'] > c_args = cflags > +if allow_experimental_apis > + c_args += '-DALLOW_EXPERIMENTAL_API' > +endif > foreach flag: error_cflags > if cc.has_argument(flag) > c_args += flag > diff --git a/drivers/net/octeontx/base/meson.build b/drivers/net/octeontx/base/meson.build > index 09f657abb..a06a2c89c 100644 > --- a/drivers/net/octeontx/base/meson.build > +++ b/drivers/net/octeontx/base/meson.build > @@ -13,8 +13,12 @@ foreach d: depends > static_objs += [get_variable('static_rte_' + d)] > endforeach > > +c_args = cflags > +if allow_experimental_apis > + c_args += '-DALLOW_EXPERIMENTAL_API' > +endif > base_lib = static_library('octeontx_base', sources, > - c_args: cflags, > + c_args: c_args, > dependencies: static_objs, > ) > > diff --git a/drivers/net/sfc/base/meson.build b/drivers/net/sfc/base/meson.build > index da2bf44d8..ab66f32f9 100644 > --- a/drivers/net/sfc/base/meson.build > +++ b/drivers/net/sfc/base/meson.build > @@ -58,6 +58,9 @@ extra_flags = [ > ] > > c_args = cflags > +if allow_experimental_apis > + c_args += '-DALLOW_EXPERIMENTAL_API' > +endif > foreach flag: extra_flags > if cc.has_argument(flag) > c_args += flag > diff --git a/drivers/net/thunderx/base/meson.build b/drivers/net/thunderx/base/meson.build > index c9d5a8f4e..bf4e8608a 100644 > --- a/drivers/net/thunderx/base/meson.build > +++ b/drivers/net/thunderx/base/meson.build > @@ -7,8 +7,12 @@ sources = [ > 'nicvf_bsvf.c' > ] > > +c_args = cflags > +if allow_experimental_apis > + c_args += '-DALLOW_EXPERIMENTAL_API' > +endif > base_lib = static_library('nicvf_base', sources, > - c_args: cflags, > + c_args: c_args, > dependencies: static_rte_ethdev > ) > >