From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id D9B0C5911 for ; Mon, 3 Sep 2018 16:51:29 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20180903145129euoutp014c97244db6a82d7d2c868845231058b7~Q62RlasZe2156521565euoutp01O for ; Mon, 3 Sep 2018 14:51:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20180903145129euoutp014c97244db6a82d7d2c868845231058b7~Q62RlasZe2156521565euoutp01O DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1535986289; bh=afpCYR5FXklszjWRIM/lDALjfzSOL61uG+mYSVr7jZE=; h=Subject:From:To:Date:In-Reply-To:References:From; b=K9IJrq07Gjld6FYXsZTT6NfARFedcjlSBGTthpOB/RPm9v8zVxvTHi8MjJK3JEMVQ 5Eh+ghOt4f/rJZHqoofFL5XHP8mB4Xn/5/PyhRCgrV0G927rf3u4bi+kbIW2Sn+JEk nS5TGuWeYL31IvUwrsSenWx7QNT3FTd/ApJUYUK4= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20180903145128eucas1p1a28056b584ae47082b3d5d0b49da38c5~Q62RFZIwB2503825038eucas1p1k; Mon, 3 Sep 2018 14:51:28 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id DB.AF.04806.07A4D8B5; Mon, 3 Sep 2018 15:51:28 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20180903145127eucas1p28e056d1d8be72d3cb9fec8668ccb42d4~Q62P_te0K0770907709eucas1p2T; Mon, 3 Sep 2018 14:51:27 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20180903145127eusmtrp2abafcd36b527ab4df032ca64c65d1555~Q62PsgH2F0988009880eusmtrp2D; Mon, 3 Sep 2018 14:51:27 +0000 (GMT) X-AuditID: cbfec7f5-34dff700000012c6-56-5b8d4a701c04 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 15.88.04128.F6A4D8B5; Mon, 3 Sep 2018 15:51:27 +0100 (BST) Received: from [106.109.129.180] (unknown [106.109.129.180]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20180903145126eusmtip2d8810753b803c6ac9b8ebf3b0ff1de3e~Q62PYXj4I0701507015eusmtip2k; Mon, 3 Sep 2018 14:51:26 +0000 (GMT) From: Ilya Maximets To: Bruce Richardson , dev@dpdk.org Date: Mon, 3 Sep 2018 17:52:58 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180903144015eucas1p2f4bee75a7eaccc76e158ae51482764c9~Q6seLK6ys2201122011eucas1p2Q@eucas1p2.samsung.com> Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupileLIzCtJLcpLzFFi42LZduznOd0Cr95og6MP+CxurLK3ePdpO5PF lfaf7A7MHr8WLGX1WLznJZNH35ZVjAHMUVw2Kak5mWWpRfp2CVwZHTvbGAuOq1U8ap7E3MC4 Q6GLkYNDQsBE4t0WgS5GLg4hgRWMElcO9TJCOF8YJTo6TkI5nxklTvbsY+pi5ATr2HjsB1Ri OaPEtY2fWSGcj4wSv+6/ZgGpEhbwkZj+9j87iM0moCNxavURRhBbRMBe4vruY+wgu1kEVCRW tkeAhEUFIiSOPFgIVsIrIChxcuYTsDGcAuUSjy53gY1hFhCXaPqykhXClpfY/nYOM8RB39kk Ovr5IXrLJPZuWsIKEXeR6HnyG6pGWOLV8S3sELaMxP+d86GeqZe43/IS7BkJgQ5GiemH/kEl 7CW2vD4HdiezgKbE+l36EGFHiROz3jJDgo5P4sZbQYhz+CQmbZsOFeaV6GgTgqhWkfh9cDnU BVISN999hrrAQ2LC1tmsExgVZyF5eBaSJ2cheXIWwg0LGFlWMYqnlhbnpqcWG+ellusVJ+YW l+al6yXn525iBKaQ0/+Of93BuO9P0iFGAQ5GJR7eH7q90UKsiWXFlbmHGCU4mJVEeBvdgUK8 KYmVValF+fFFpTmpxYcYpTlYlMR5+bTSooUE0hNLUrNTUwtSi2CyTBycUg2MZw8fvMAQZBUx eU1ycF7Woy2266d1tn7YXSD+v9fy7fblwtf8mG56XJB//2Xhl/t5i1OYk/KmMK18dm0z+97f ToXJWvc3TN2REbWi6/Saw+vaj0vv/hGok/err5z7d4vr1glqYqLznlw6/Sq+7JZd2RqFJvv7 xzYaW9jK2PyZWclnZdg430g4T4mlOCPRUIu5qDgRALqQvkYdAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprMIsWRmVeSWpSXmKPExsVy+t/xe7r5Xr3RBm+n8VvcWGVv8e7TdiaL K+0/2R2YPX4tWMrqsXjPSyaPvi2rGAOYo/RsivJLS1IVMvKLS2yVog0tjPQMLS30jEws9QyN zWOtjEyV9O1sUlJzMstSi/TtEvQyOna2MRYcV6t41DyJuYFxh0IXIyeHhICJxMZjPxi7GLk4 hASWMkp0vOxkgUhISfz4dYEVwhaW+HOtiw2i6D2jxO9rE8GKhAV8JKa//c8OYrMJ6EicWn2E EcQWEbCXuL77GDtEw39GiZ6lX8CKeAXsJG5+WQvUzMHBIqAisbI9AiQsKhAhsXr5C1aIEkGJ kzOfgM3nFCiXeHS5C6yVWUBd4s+8S8wQtrhE05eVrBC2vMT2t3OYJzAKzkLSPgtJyywkLbOQ tCxgZFnFKJJaWpybnltspFecmFtcmpeul5yfu4kRGCHbjv3csoOx613wIUYBDkYlHt4fur3R QqyJZcWVuYcYJTiYlUR4G92BQrwpiZVVqUX58UWlOanFhxhNgX6byCwlmpwPjN68knhDU0Nz C0tDc2NzYzMLJXHe8waVUUIC6YklqdmpqQWpRTB9TBycUg2MM+avsm3/uenOaTnN/JzcQ6za EX2zGXZtLj10QUXt90LRpnkH3ESPfplQW3JadvNaxsPnpdwZLhUq/3Dd5LJUN7wtxTXoeuqq vxcXzNwdmdCwxo/5+HLbvKa8fRPbGZJ9A5J1A0zelbxaOe3TvScMwbYlRcoN220Oze9Rc5w/ Y7bJzJudTq45SizFGYmGWsxFxYkAzDqwVaYCAAA= Message-Id: <20180903145127eucas1p28e056d1d8be72d3cb9fec8668ccb42d4~Q62P_te0K0770907709eucas1p2T@eucas1p2.samsung.com> X-CMS-MailID: 20180903145127eucas1p28e056d1d8be72d3cb9fec8668ccb42d4 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20180831133527epcas4p1039efdef614bebf49d048846927a68a2 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20180831133527epcas4p1039efdef614bebf49d048846927a68a2 References: <20180831133510.3121-1-bruce.richardson@intel.com> <20180903144015eucas1p2f4bee75a7eaccc76e158ae51482764c9~Q6seLK6ys2201122011eucas1p2Q@eucas1p2.samsung.com> Subject: Re: [dpdk-dev] [PATCH] net/*/base: allow use of experimental APIs in base code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Sep 2018 14:51:30 -0000 On 03.09.2018 17:41, Ilya Maximets wrote: > On 31.08.2018 16:35, Bruce Richardson wrote: >> The driver setting of "allow_experimental_apis" was not being used when >> building the base code. To allow this we can manually put in a check >> in the base code files for the setting and set the appropriate cflag >> if it's needed. >> >> Signed-off-by: Bruce Richardson > > Tested-by: Ilya Maximets > >> --- >> drivers/net/e1000/base/meson.build | 3 +++ >> drivers/net/fm10k/base/meson.build | 3 +++ >> drivers/net/i40e/base/meson.build | 3 +++ >> drivers/net/ixgbe/base/meson.build | 3 +++ >> drivers/net/octeontx/base/meson.build | 6 +++++- >> drivers/net/sfc/base/meson.build | 3 +++ >> drivers/net/thunderx/base/meson.build | 6 +++++- >> 7 files changed, 25 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/net/e1000/base/meson.build b/drivers/net/e1000/base/meson.build >> index 5e1716def..f26f24298 100644 >> --- a/drivers/net/e1000/base/meson.build >> +++ b/drivers/net/e1000/base/meson.build >> @@ -25,6 +25,9 @@ error_cflags = ['-Wno-uninitialized', '-Wno-unused-parameter', >> '-Wno-unused-variable', '-Wno-misleading-indentation', >> '-Wno-implicit-fallthrough'] >> c_args = cflags >> +if allow_experimental_apis >> + c_args += '-DALLOW_EXPERIMENTAL_API' >> +endif >> foreach flag: error_cflags >> if cc.has_argument(flag) >> c_args += flag >> diff --git a/drivers/net/fm10k/base/meson.build b/drivers/net/fm10k/base/meson.build >> index a8fc5fa8b..5525cdc82 100644 >> --- a/drivers/net/fm10k/base/meson.build >> +++ b/drivers/net/fm10k/base/meson.build >> @@ -15,6 +15,9 @@ error_cflags = ['-Wno-unused-parameter', '-Wno-unused-value', >> '-Wno-unused-variable', '-Wno-missing-field-initializers' >> ] >> c_args = cflags >> +if allow_experimental_apis >> + c_args += '-DALLOW_EXPERIMENTAL_API' >> +endif >> foreach flag: error_cflags >> if cc.has_argument(flag) >> c_args += flag >> diff --git a/drivers/net/i40e/base/meson.build b/drivers/net/i40e/base/meson.build >> index e6163eaa6..d4c8f872d 100644 >> --- a/drivers/net/i40e/base/meson.build >> +++ b/drivers/net/i40e/base/meson.build >> @@ -16,6 +16,9 @@ error_cflags = ['-Wno-sign-compare', '-Wno-unused-value', >> '-Wno-strict-aliasing', '-Wno-unused-but-set-variable' Actually, "-Wno-unused-but-set-variable" part is missing on master, so the patch could not be applied cleanly. I tested it after removing this flag from the patch to make it applicable. >> ] >> c_args = cflags >> +if allow_experimental_apis >> + c_args += '-DALLOW_EXPERIMENTAL_API' >> +endif >> foreach flag: error_cflags >> if cc.has_argument(flag) >> c_args += flag >> diff --git a/drivers/net/ixgbe/base/meson.build b/drivers/net/ixgbe/base/meson.build >> index 3147e1101..21ac64bf5 100644 >> --- a/drivers/net/ixgbe/base/meson.build >> +++ b/drivers/net/ixgbe/base/meson.build >> @@ -20,6 +20,9 @@ sources = [ >> error_cflags = ['-Wno-unused-value', >> '-Wno-unused-but-set-variable'] >> c_args = cflags >> +if allow_experimental_apis >> + c_args += '-DALLOW_EXPERIMENTAL_API' >> +endif >> foreach flag: error_cflags >> if cc.has_argument(flag) >> c_args += flag >> diff --git a/drivers/net/octeontx/base/meson.build b/drivers/net/octeontx/base/meson.build >> index 09f657abb..a06a2c89c 100644 >> --- a/drivers/net/octeontx/base/meson.build >> +++ b/drivers/net/octeontx/base/meson.build >> @@ -13,8 +13,12 @@ foreach d: depends >> static_objs += [get_variable('static_rte_' + d)] >> endforeach >> >> +c_args = cflags >> +if allow_experimental_apis >> + c_args += '-DALLOW_EXPERIMENTAL_API' >> +endif >> base_lib = static_library('octeontx_base', sources, >> - c_args: cflags, >> + c_args: c_args, >> dependencies: static_objs, >> ) >> >> diff --git a/drivers/net/sfc/base/meson.build b/drivers/net/sfc/base/meson.build >> index da2bf44d8..ab66f32f9 100644 >> --- a/drivers/net/sfc/base/meson.build >> +++ b/drivers/net/sfc/base/meson.build >> @@ -58,6 +58,9 @@ extra_flags = [ >> ] >> >> c_args = cflags >> +if allow_experimental_apis >> + c_args += '-DALLOW_EXPERIMENTAL_API' >> +endif >> foreach flag: extra_flags >> if cc.has_argument(flag) >> c_args += flag >> diff --git a/drivers/net/thunderx/base/meson.build b/drivers/net/thunderx/base/meson.build >> index c9d5a8f4e..bf4e8608a 100644 >> --- a/drivers/net/thunderx/base/meson.build >> +++ b/drivers/net/thunderx/base/meson.build >> @@ -7,8 +7,12 @@ sources = [ >> 'nicvf_bsvf.c' >> ] >> >> +c_args = cflags >> +if allow_experimental_apis >> + c_args += '-DALLOW_EXPERIMENTAL_API' >> +endif >> base_lib = static_library('nicvf_base', sources, >> - c_args: cflags, >> + c_args: c_args, >> dependencies: static_rte_ethdev >> ) >> >> > >