From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM05-DM3-obe.outbound.protection.outlook.com (mail-eopbgr730075.outbound.protection.outlook.com [40.107.73.75]) by dpdk.org (Postfix) with ESMTP id E1E402C02 for ; Wed, 5 Sep 2018 10:55:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iaqb8OkUg49KgAXuirnRo1Vz1GkhbinXuENWV3HnTZ0=; b=UoCTETPCl1mMAEWm856HjB0OmKApnquKzTpkj3bkoZTJ6s4YH5zDRcM2dLjZRgpgAXSwsq6ht7mStdiq8u2UYkCMUvNq4+iuXdFcM2znhj0Zhnd9+4tjRGTJm8ZOSfPf3sCKBbvbOxLNJfD4UeUNFyvElFrjHTmcjh3CdHvWkFM= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; Received: from ltp-pvn (111.93.218.67) by SN6PR07MB4973.namprd07.prod.outlook.com (2603:10b6:805:ac::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1080.15; Wed, 5 Sep 2018 08:55:06 +0000 Date: Wed, 5 Sep 2018 14:24:36 +0530 From: Pavan Nikhilesh To: "Rao, Nikhil" , jerin.jacob@caviumnetworks.com, anoob.joseph@caviumnetworks.com Cc: dev@dpdk.org Message-ID: <20180905085434.GA2858@ltp-pvn> References: <20180904141223.24216-1-pbhagavatula@caviumnetworks.com> <20180904141223.24216-3-pbhagavatula@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: BM1PR0101CA0058.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:19::20) To SN6PR07MB4973.namprd07.prod.outlook.com (2603:10b6:805:ac::23) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 74539b50-92a5-4ea8-d53d-08d6130d483b X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:SN6PR07MB4973; X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB4973; 3:9uxDM9HXYNiciATNFZLGoZ1e3RBmDZVmZF6KOLHXPeAz9FyzG+sFy1laEucGCyuVgUX+NlhGRKPXadzycWnXm9+A6n9Osd2C3ubachsiRibHQXFBI/EpZInjaTsQgEL/sP90VMu6VdB3ap3DC/NXEVbrVBrOSXbYnBeyCU7euPaJ2FsXOCNhnF4fimbWIRRwaET34wxd0iYND4mKu8FXYR86RVLmAhn+cqTSTOmpig3alG0nzqXbkGuibwe9nI0W; 25:SzTkqlBF137vnW2UajrChl6uUkl31E/NCUcaV/6R5ZXE1SotGH4oCs+ffRAZJ36lyMh+2lVXR6NwYyYikOSgBxDJUZTh/DuoxOy1OdHgWMCRAojZy9bg04JFhliumgek7ffPZkbilkWGiejmooHtQLp0UcR0VFYi6hHIeYVM6qIUhIVvccYOXBt3Wu0NuyKJer6TIe5QehQl41V0zmAIZ5JrQLw04bU/Vb+7TTvIS0Ux4nb9VGBEaqfnEOAueijfdj/Yxl1yFOxZpNaR5DrQFvRMp5MAW1yY2eXqDpREqHMbF+CrYyTVtbcR9a1RzDjflGOlkMBB8d5WLVv2ABYEfA==; 31:pbGQzxNTvSYxt1+Gvgy0y+ZS+BCkWbhjPhEkEzTmu52uYYnK9TvwpjRmjqMbdchcdxa0nInvX3Tqj3l18jE2RJIqO6JGOCv1ZZ6zlbkRMSZVEFARQQFjHybcPU6oM0cHbiilp+OlpcF0wjUfwNoZM4Jbfqzptht3LqDJDYYXDco4pGh3LFRbKhXyshyqbvwMBjbINcnltNi3GTOJo0aCHt2gDq8sH+IMftNqzOXETHs= X-MS-TrafficTypeDiagnostic: SN6PR07MB4973: X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB4973; 20:+TQUVK7C06S7MNfx8G//ImkXvR41T2LZZldoJzKXQxv5IFmM0xuUTrVpgYI2Y5zqf7Nhz3YQkLsvhpMzyVXocPJ/nwKurewELNyh0VO/bryKT+wzfN0kIs0cDpKUZlOGPH1kUgQvnIoYxXrc8Cy37k2EQFZC08pGVk7DPckDPXPDtjhEzs+23HJxXGmM4AQzcd88MotEK3m+XiJTRooGRR6BBsMKPtN2kINRNErSNzVqlj7aNKrl822EQhkZPSLYDaDgwxdHukFbgPRdaqKdfitNeipJad7hseQ/JKBnKpYkIZQSyaSPGayw69HQIP0keNDXUUrV4m9qTutdRYQr+cK8Q9Fa+Ilt4ablfe3SmBkVAOkhWorOOVZ0Ne+N2FRWPEUVcTixZvq8ILLdRG51u8Q6vgXE1Wi5kCEo3L44ys3mybY6hMyPerSWx0cvMsCt/hTsm7WC4mJDbuYtkl9lkMYemscIk8VBb0hecFdSBHDg4143hO2oFrnXmxEnl6OuLeFKXpyorOldPcSNfAqLtsI/BCFsIhU6+53wBkFnPcQDK6NW8FkaAg6l4KgfFHw1qY65ZjmY84iP1+IJEBQsdlU0T0HxLG0VF4rf+qfxnEg=; 4:leSuiuEQDk3IAYgbQgMcCzxVh0zz0t5glyxUp3SqrafKl5UCmU2m6EGi8xNzMYceJku2j9jQik6+drOokr5t3dU30qk5/hBvci9p+KVtHNS9/JCKOsIlDcFWS/act1K2C+1iwHiY08q58tWPq2SXRG0myqAmGlWQRIT9+ZKDJHy2VxWO/oZDmoIrqwA31K1T0Jg77oYrscN5T7wrgnyD6u5KxJtULRUcZTWa52tijULlbTrK6DNs6rE+RauYvqNRQg6zqf1WfkW55CiphVPt6w== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3231311)(944501410)(52105095)(93006095)(3002001)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201708071742011)(7699016); SRVR:SN6PR07MB4973; BCL:0; PCL:0; RULEID:; SRVR:SN6PR07MB4973; X-Forefront-PRVS: 078693968A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(376002)(366004)(346002)(136003)(189003)(199004)(6246003)(2906002)(14444005)(33716001)(305945005)(7736002)(25786009)(446003)(5660300001)(4326008)(486006)(6666003)(6636002)(476003)(11346002)(956004)(1076002)(76176011)(6116002)(8936002)(16586007)(316002)(58126008)(47776003)(3846002)(33896004)(66066001)(53546011)(68736007)(229853002)(386003)(9686003)(55016002)(16526019)(52116002)(81166006)(8676002)(50466002)(81156014)(53936002)(72206003)(97736004)(478600001)(186003)(26005)(106356001)(23726003)(33656002)(42882007)(5009440100003)(105586002)(6496006)(18370500001)(107986001)(42262002); DIR:OUT; SFP:1101; SCL:1; SRVR:SN6PR07MB4973; H:ltp-pvn; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN6PR07MB4973; 23:sdyx6u/O5lgiMC1QY7EQjFmQ3AdqkLx0v4kX+sP1b?= =?us-ascii?Q?Y/tXCB8Ucpj0dXHT1fNYgPH/LotuMI2ftoI9GIi04zxh0pxjw5D/LuNjPVmX?= =?us-ascii?Q?I3xK08utHIvPLi538jo/UEu1G3EFF1A05nmUhEjaMIKwLBHhOoUWq/65UTtG?= =?us-ascii?Q?yAPiMLjsmiTMmvRQo+nii38A9xMAGVZWs++uCTtfHbnhpsY11RUmIRetWBUN?= =?us-ascii?Q?TVXLek0WhAm0vki44JvbN01/hsq9la0A3kko2454bC3VtlVcSR+ulF0dFJMg?= =?us-ascii?Q?B/K+HGcrUATLkVkur2P35X/L321yziLNLMNHwlQil22YePBExbo5CxZ3YYEx?= =?us-ascii?Q?oDXqCNmMSJamVtUdRwVRFJx7zN697NckHf9NfElLRHzo2vtlVfLMCrVQfd+8?= =?us-ascii?Q?IMHji0A4tpkwfrAQ3xiZWi+Ad71e4I6a0MjMrF8UYNj/LVsoy/1R60BFvLQj?= =?us-ascii?Q?n1k2VrftVN+rjli3zGrOKmOLrzeC1GPAcmcxnA043fLX/l0P4kBWDfoNAHkr?= =?us-ascii?Q?iIJuBjH4kbt8zv2qbvNXh1ULk/pattN+OgeffmD7i8SRmci7FQnAqhYEarmI?= =?us-ascii?Q?4NA890WzSpDdE622eUexLgGizJb3I3txrxutGC/3eM81IAyPTBXtqIv3k0yH?= =?us-ascii?Q?xOccdPRjwDWTZpEBc59IPHui9zRU25WN9vxOG/L5kmEd4eRJF+CB209T6JCq?= =?us-ascii?Q?ebr9xan1IFVgB06GqbZi8EW0xsZ8KlP10QG1hIj6SX7fSvdXuRmTJCsgnFyj?= =?us-ascii?Q?dGLfOy8ZruE9jaFFd4I2JiLV6OZ7wJkLrq+uGk8AW66q1ENMnt/RMg6U/7tF?= =?us-ascii?Q?+goETLHSHmS1vHQ337bmai0EwvGLyp633nUm1l970gNlsiuQam8x2zUvmLth?= =?us-ascii?Q?/f0FMxaD8VufgQl6gW1qmkDDlY3bgyLa7cnuYCa7jwWV2Gj/xTeNtqGvFdkT?= =?us-ascii?Q?bnk/YYg7lc+ApGIBHUphQjoMfBDEWURZkq0gWoZQ9u6+UiV3yWKTMHQ/ljLG?= =?us-ascii?Q?HW+3Lx+IJGf8cynsyJsdlR41waC5vqXiUgCFS9eaFU6HF0iPeW6KKvt0yyzs?= =?us-ascii?Q?yB0Dpxe7KasX6V4TlbOYsKbY5kX5erReXBQuMreWnlBKr1HgJCeX7mKmE8ER?= =?us-ascii?Q?YWxiAdExtFBoKcZEcd5hBNW4XvUcxi09R19SHp6AG90xgQpU3WfTJ+kXR3o/?= =?us-ascii?Q?jl37io63MFlk+vCBivfvYjU1JqM5YqlQoeKXU86znCrkebe4HNcBPVkez9On?= =?us-ascii?Q?CKN9A6XaG5F5DSKfFZehtT2YXr5Gi1bKv2HwRVX3VJKP/iqovneuzmZqL0WD?= =?us-ascii?Q?TZt/GDjo4cRXpdP7xciX+Xv5nRLutmp4AkeGEBLznCt9U9IyIJKVtN/iyuuw?= =?us-ascii?Q?skI6qI5kmukOpPZD8Ks3LdX/QExGj1EWOqiBHbbcp6nFSL0?= X-Microsoft-Antispam-Message-Info: aqV2jpMnBlukClqiLnAvfN+UM5JBM9GP1Yb8V5G4dX2ZqlGXWt4bCL0kEsNnZEbBh6ESsmucNG4pTpLnsHW78h9YlQhzKVl5923TiWs2TEAD3+AQeTXw3YU8eEgZ0/ejDT7eWiosa/o6Lr8UWJH/9AJowo4j9Lq2y6Lc+Wlu3psFDJDShTK3ci+seQ9pXC7DzUDaV8+TW+cTIVC/gZWH5e5ae4NbkrqKZFJPQCjiaCGlbik0S1CXvIRO5GQTLkNfJsTAK9hYLIBXXdu1soODTtorSnUVV24eZ9y/6ipNyAIikvx0N1t4ugbF4B+1DejUOFRh43NdhxyJWHVfRYN/MLJiiMEwIuduOed9zsxiDyc= X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB4973; 6:4h/mypVoZf5EmWUWJzcsdw156GVqjnLD9WVEIViJVNEn6K3WQ3zfPw+xGQiWnkgEo/IX5dHfiuLRpFbwmzgX/o2Da6IdiVs4eQKY98wxbrbCo5wVWkV8HCUAA1RXQrNarJ+tK8SI4/aBwqf5pifXdcZ/C8nWlkSPgnVrLMh1XUgOTrsq4l/HZ/jecUU2Ut89WP0b9E2ZAa9t+rTnGXimtb9kpAfXAenJdmFzpNsjywxutl2VTsnshrjkABf7SoitOKlk8D/fR43M7AGQZ9jtCpc7bCx6k17976MPgBY9+Z1ifJo7ST8iyIDY+yFaklcoV0Q8GBEIvT9iqVO+h6nke/jr/4yFDdBDC4m123qEmbxVVvjZki2ZACjpmI/w7fL63WMxxaB8nJixJRD7Bd9glwzmegEw1pmOi9cCQCAR64D0pPQSOBy8aWYERa46FPDgJOBg7V1+46p7ldWVgOy/HA==; 5:XgIDGDeAQbRiW83m9pDFSp31H6PLsvh60MWqlBrhIk5/WsCove5ZYBdXbeCflch2tlWW/BIWWwNUH7nUKsEniirkC8quFVxZI+OIBohO3EMyLlhwdN7ZA0rPee/EPedopGyOR5mJoyNBnfles6I3AoPEFvMPEnpffVlQxsNIvrk=; 7:kRvsynu9+DzQiJxubFl1eNH9Nuu9ZgjHmFMo8Fl1zfrUL7nEAT50mYAhXvqEkYn0lqv6v3tqrG16GYxKknZYjUysZ7V6NExV5l598gPOSRCJWgWPcDUUqoC+xeD0LUyUrf1P8em4wonoYsuwhuAJG+Vm1wCfcELRtuhgAXeyYeGcEU0RR8f2usujQI0tNGhfmYTAh8osX6Fh/oX+7dgFFT/90zIdkoq6w8acAOJtvsiw/GkaNQk3kcUlclEt3BF2 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2018 08:55:06.9164 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 74539b50-92a5-4ea8-d53d-08d6130d483b X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR07MB4973 Subject: Re: [dpdk-dev] [PATCH v2 3/4] app/test-eventdev: add Tx adapter support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Sep 2018 08:55:11 -0000 On Wed, Sep 05, 2018 at 12:24:18PM +0530, Rao, Nikhil wrote: > On 9/4/2018 7:42 PM, Pavan Nikhilesh wrote: > > Convert existing Tx service based pipeline to Tx adapter based APIs and > > simplify worker functions. > > > > Signed-off-by: Pavan Nikhilesh > > --- > > app/test-eventdev/test_pipeline_atq.c | 269 ++++++++++++----------- > > app/test-eventdev/test_pipeline_common.c | 206 +++++------------ > > app/test-eventdev/test_pipeline_common.h | 62 +++--- > > app/test-eventdev/test_pipeline_queue.c | 241 ++++++++++---------- > > 4 files changed, 367 insertions(+), 411 deletions(-) > > > > diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eventdev/test_pipeline_common.c > > index 832ab8b6e..ab407dbbb 100644 > > --- a/app/test-eventdev/test_pipeline_common.c > > +++ b/app/test-eventdev/test_pipeline_common.c > > @@ -5,58 +5,6 @@ > > > > > > @@ -215,7 +160,6 @@ pipeline_ethdev_setup(struct evt_test *test, struct evt_options *opt) > > { > > uint16_t i; > > uint8_t nb_queues = 1; > > - uint8_t mt_state = 0; > > struct test_pipeline *t = evt_test_priv(test); > > struct rte_eth_rxconf rx_conf; > > struct rte_eth_conf port_conf = { > > @@ -238,13 +182,21 @@ pipeline_ethdev_setup(struct evt_test *test, struct evt_options *opt) > > return -ENODEV; > > } > > > > + t->internal_port = 0; > > RTE_ETH_FOREACH_DEV(i) { > > struct rte_eth_dev_info dev_info; > > struct rte_eth_conf local_port_conf = port_conf; > > + uint32_t caps = 0; > > + > > + rte_event_eth_tx_adapter_caps_get(opt->dev_id, i, &caps); > > + if ((caps & RTE_EVENT_ETH_TX_ADAPTER_CAP_INTERNAL_PORT)) { > > + t->internal_port = 1; > > + } else if (t->internal_port == 1) { > > + evt_err("Eventdev can't use %d port", i); > > + return -EINVAL; > > + } > > > Shouldn't this function also return -EINVAL for the case where > internal_port = 0 for i = 0, and internal_port = 1 for i = 1 ? I think it would be better to force all the ports to use the non-internal cap mode when we detect that one of the port doesn't have internal port capability rather than exiting. This was the behaviour previously it will leave room to support both the pipeline models in future. > > Nikhil > Thanks, Pavan.