From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-f68.google.com (mail-ed1-f68.google.com [209.85.208.68]) by dpdk.org (Postfix) with ESMTP id 653D94CE4 for ; Wed, 5 Sep 2018 14:57:55 +0200 (CEST) Received: by mail-ed1-f68.google.com with SMTP id l5so5993821edw.9 for ; Wed, 05 Sep 2018 05:57:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WPEdTiVpdEVKK1HQt9SNPrpSbxzulVQdiqIaT61oIeg=; b=d92MEPAh6Gb8+dCFlxSaPnWTsMH2KwKoX0FE0pKl7ziiBOAjJCfeXX1ybuu6bkwRpT ywMfddzp3jl8CGSkypHQGnQL/R0vKwNa8wgify7RU/J1rndKVGs8roFwaWcc1k/QBtTd G7EZ0FHe27NRZFXpieTZi8anpgQiUFuKg3Twyjh1CdLki5aInJYIX1/FMVX8FCRsSd98 Kk899Vae5TS6jVsxydkJMrTT/XrVvqeXu7/7JYWNEHH5GSLCtA5egWV4glWmJXte+KJa 5NUkXqeQfFyZDMcvriSCWa2gFh8XTCRX7c8/6/GhS4hWHCgwJNfhS7AdcXu9HVL5I+e/ 3DeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WPEdTiVpdEVKK1HQt9SNPrpSbxzulVQdiqIaT61oIeg=; b=efY4ckHlbLjmnKmEog8qc8qkJoyfFB1dAtXa2wOK1UA6GD8LTnBHJ3OxVeFu0UtMrr 7rGmISwT7cKVZ6tVP4G6B3S16AFXZmztir/45Hc7tagjxV0B7LS13JtJEx29eieX47gb RgP4RJhksywlsxh1FAD6j6AlKqG8FQo4Dlp2h6gmwk2EopWMLSAy59y+cqEaJsECChYF 2bdrrUfqnCCZfbAGllSCl7EKzbUpugfbNGYO1SpZ2YEpP5LO6o+jEGp5OZB5qc9OWkVO PsJDUV6yxLutGWwCxMMDYHbOjdH9+iamNbxP5vIPnkPtgKv3CO8yjCQATJ7yT09c5YmC 9PZQ== X-Gm-Message-State: APzg51DrzcPgXZgekFKDtb8TXgmGS/Z5/Mwkh3S0uOpQ2AX/b++bNg83 S+UqH7B0krm9FqFpm2Q2Dy3MTQ== X-Google-Smtp-Source: ANB0VdYw59vPwMku0z63YR6UWYJl6AGHxOM2BtMz+XQ2GIluxtVOJ85vTCOi+laHIfL6pMQzL1hfjA== X-Received: by 2002:aa7:c553:: with SMTP id s19-v6mr41235561edr.202.1536152274845; Wed, 05 Sep 2018 05:57:54 -0700 (PDT) Received: from shemminger-XPS-13-9360 ([31.216.236.195]) by smtp.gmail.com with ESMTPSA id b47-v6sm1098527eda.79.2018.09.05.05.57.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 05 Sep 2018 05:57:54 -0700 (PDT) Date: Wed, 5 Sep 2018 13:57:50 +0100 From: Stephen Hemminger To: Dan Gora Cc: Igor Ryzhov , Ferruh Yigit , dev@dpdk.org Message-ID: <20180905135751.74f6c14b@shemminger-XPS-13-9360> In-Reply-To: References: <20180628224513.18391-1-dg@adax.com> <20180629015508.26599-1-dg@adax.com> <20180629015508.26599-11-dg@adax.com> <20180829085410.4411c07e@xeon-e3> <20180829150014.0ae59128@xeon-e3> <20180829161043.11bb2434@xeon-e3> <20180830150911.6b0e7901@xeon-e3> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 10/10] kni: add API to set link status on kernel interface X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Sep 2018 12:57:55 -0000 On Mon, 3 Sep 2018 21:47:22 -0300 Dan Gora wrote: > Hi All, > > One other problem with using the sysfs method to change the link state > rather than this ioctl method. The sysfs/netdev method to change the > carrier was only introduced in kernel 3.9. For older kernels, we > would just be out of luck. The ioctl method will work with any kernel > version (2.6+). It's not clear if this is a problem for DPDK apps or > not. > > thanks > dan > > > On Thu, Aug 30, 2018 at 7:11 PM, Dan Gora wrote: > > On Thu, Aug 30, 2018 at 7:09 PM, Stephen Hemminger > > wrote: > >> On Thu, 30 Aug 2018 18:41:14 -0300 > >> Dan Gora wrote: > >> > >>> On the other hand, the "write to /sys" method is a bit more simple and > >>> confines the changes to the user space library. If we're confident > >>> that the /sys ABI is stable and not going to be changed going forward > >>> it seems like a valid alternative. > >> > >> See Documentation/ABI/testing/sysfs-class-net > > > > yeah, but it's in the 'testing' directory :) > > > > From Documentation/ABI/README: > > > > testing/ > > > > This directory documents interfaces that are felt to be stable, > > as the main development of this interface has been completed. > > The interface can be changed to add new features, but the > > current interface will not break by doing this, unless grave > > errors or security problems are found in them. Userspace > > programs can start to rely on these interfaces, but they must be > > aware of changes that can occur before these interfaces move to > > be marked stable. Programs that use these interfaces are > > strongly encouraged to add their name to the description of > > these interfaces, so that the kernel developers can easily > > notify them if any changes occur (see the description of the > > layout of the files below for details on how to do this.) > > > > Like I said, I'm ok with using this if that's what everyone wants to do. > > > > d > > > Linux 3.9 is no longer supported. Currently, upstream Linux kernel is supported from 3.16 on. If someone is on a kernel that old, they aren't going to get any security fixes.