From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <xiaolong.ye@intel.com>
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by dpdk.org (Postfix) with ESMTP id 1419B3772
 for <dev@dpdk.org>; Fri,  7 Sep 2018 02:55:49 +0200 (CEST)
X-Amp-Result: UNKNOWN
X-Amp-Original-Verdict: FILE UNKNOWN
X-Amp-File-Uploaded: False
Received: from orsmga008.jf.intel.com ([10.7.209.65])
 by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 06 Sep 2018 17:55:49 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.53,340,1531810800"; d="scan'208";a="71230372"
Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.110.207])
 by orsmga008.jf.intel.com with ESMTP; 06 Sep 2018 17:55:47 -0700
Date: Fri, 7 Sep 2018 15:44:02 +0800
From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Rami Rosen <roszenrami@gmail.com>
Cc: dev@dpdk.org, maxime.coquelin@redhat.com, tiwei.bie@intel.com,
 zhihong.wang@intel.com, xiao.w.wang@intel.com
Message-ID: <20180907074402.GA18298@intel.com>
References: <20180906131653.10752-1-xiaolong.ye@intel.com>
 <20180906131653.10752-2-xiaolong.ye@intel.com>
 <CAKoUArkWvSWJVoRSFTLs6gVT+wcQ7R=Lx9utX-i2ht=Y9JWtfg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAKoUArkWvSWJVoRSFTLs6gVT+wcQ7R=Lx9utX-i2ht=Y9JWtfg@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Subject: Re: [dpdk-dev] [PATCH v1 2/2] examples/vdpa: add a new sample for
 vdpa
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Sep 2018 00:55:50 -0000

Hi, Rosen.

Thanks a lot for your comments.

On 09/06, Rami Rosen wrote:
>Hi all,
>First, thanks for the vdpa example patches.
>Second, I am getting a compilation error under Ubuntu 18.04, with gcc
>version 7.3.0 (Ubuntu 7.3.0-16ubuntu3)
>...
>  CC main.o
>/work/src/dpdk/examples/vdpa/main.c: In function ‘main’:
>/work/src/dpdk/examples/vdpa/main.c:321:5: error: ignoring return
>value of ‘scanf’, declared with attribute warn_unused_result
>[-Werror=unused-result]
>     scanf("%c", &ch);
>     ^~~~~~~~~~~~~~~~
>cc1: all warnings being treated as errors
>/work/src/dpdk/mk/internal/rte.compile-pre.mk:114: recipe for target
>'main.o' failed
>make[1]: *** [main.o] Error 1
>

I'll look into it and solve it in v2.

>Also, it would be nice to have as part of this patch series adding the
>relevant info in
>MAINTAINERS, doc/guides/sample_app_ug/index.rst , examples/Makefile
>and adding a doc/guides/sample_app_ug/vdpa.rst, like most  patches for
>examples do.
>See for example,
>
>commit f5188211c721688bf8530d1648d623205246e1da
>Author: Fan Zhang <roy.fan.zhang@intel.com>
>Date:   Thu Apr 5 17:01:36 2018 +0100
>    examples/vhost_crypto: add sample application
>

Got it, I'll add necessary documentations accordingly.

Thanks,
Xiaolong

>Regards,
>Rami Rosen