From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0049.outbound.protection.outlook.com [104.47.41.49]) by dpdk.org (Postfix) with ESMTP id 712E61041 for ; Mon, 10 Sep 2018 13:35:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1fIr/vxv/50j1Km5oQJm73ijBwtjXDg5joOJqMWHPnA=; b=mRWg5/0j7BYnkaJupGVTxYYGDAOYlwL+5SqNbIp4idqDLQTJ4bBcl+DVpF7cMIEHRiIXE48YerBeeCBW70ScQSm7kR0Y/o+fxpL3YWhIU+BgvMWg+Dmy8FoIUh80jrAQiLIVtj7A9EYPRjJ6cNTtvD+4lhrX4XmItDqG2wZqTTc= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (223.226.45.236) by BL0PR07MB4993.namprd07.prod.outlook.com (2603:10b6:208:49::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1101.18; Mon, 10 Sep 2018 11:34:57 +0000 Date: Mon, 10 Sep 2018 17:04:46 +0530 From: Jerin Jacob To: Ferruh Yigit Cc: Wenzhuo Lu , Jingjing Wu , Bernard Iremonger , John McNamara , Marko Kovacevic , Qi Zhang , Xiao Wang , Neil Horman , Remy Horton , Ori Kam , Bruce Richardson , Pablo de Lara , Radu Nicolau , Akhil Goyal , Tomasz Kantecki , "John W. Linville" , Allain Legacy , Matt Peters , Ravi Kumar , Ajit Khaparde , Somnath Kotur , Rahul Lakkireddy , Hemant Agrawal , Shreyansh Jain , John Daley , Hyong Youb Kim , Gaetan Rivet , Beilei Xing , Konstantin Ananyev , Matan Azrad , Shahaf Shuler , Yongseok Koh , Tomasz Duszynski , Dmitri Epshtein , Natalie Samsonov , Stephen Hemminger , "K. Y. Srinivasan" , Haiyang Zhang , Alejandro Lucero , Tetsuya Mukawa , Santosh Shukla , Rasesh Mody , Harish Patil , Shahed Shaikh , Andrew Rybchenko , Jasvinder Singh , Cristian Dumitrescu , Jan Remes , Keith Wiles , Maciej Czekaj , Maxime Coquelin , Tiwei Bie , Zhihong Wang , Yong Wang , Amr Mokhtar , Declan Doherty , Chas Williams , David Hunt , Anatoly Burakov , Harry van Haaren , Xiaoyun Li , Thomas Monjalon , dev@dpdk.org Message-ID: <20180910113445.GA6418@jerin> References: <20180903144501.31373-1-ferruh.yigit@intel.com> <20180904101257.61129-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180904101257.61129-1-ferruh.yigit@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Originating-IP: [223.226.45.236] X-ClientProxiedBy: SG2PR06CA0135.apcprd06.prod.outlook.com (2603:1096:1:1f::13) To BL0PR07MB4993.namprd07.prod.outlook.com (2603:10b6:208:49::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 29451cee-9633-49f3-4cd4-08d617117c0d X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:BL0PR07MB4993; X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4993; 3:98PsvvrgMj7f8I5ztWFuRUiwoU9avhno+YzzXyhyBbMkE9CGH13EaitNFhZPdxntG/GY/7RSSjx3N+vtpISqDejSYrDjkbXk8jkIgsY3hwWnIerANKS+AqQn4sHByzUobwn8YwwwB2RDb8jEYBjZ+k7CnZXkhk3d/nMK1OFHFm7EZQ55UrlMS58faBHwySWRv91JgkjHJVD6ELvqWPOaiBWXE/GzUAk2ZENEm17islWGJJkG41/iIMj1qCSRX8sn; 25:/qbOswUaFdbpUlexzOGbYEUzIFT7SZHjJf3ybX1mGR47HVeAA/qC7/wnU4fXWWBoSw6SyKa074jAn4IMo05+sQIqWi+j0Q5Y3J1S6L4FOH/axuWjNjK8h0gb8eGYABfvlL07VDMO3eHFCtFCfvB5XoQ7IlIWwkbZUQsGQZ67bHAJANSVDbknjNBlhRVETVdQAVHxCOjDRmHuAqM2Q3rlzFSuvOHUZybgBr3U7ro1p5nPSt93uJ/7aitK4pQ0BENGsd32soydTTVQvGb86I4Qp5FRDBWLMrgs72j/HpNn9Fn7VduYbVuiNzb58ntKsKxf8xyYYw+O+z7iPzM7/49x2w==; 31:9PZRZ8evkO7qfVRPQ8lVaX8PeH2Ehy77h/5xmxv3yEXM7yIpL/3/sRNJT1qCdAdW1FiXIhmI0lG6wBRAaU2ikP1zmLX9gfCsZa7eg/AQ8504hyc0a5kz4PgI5Pq+SSCYTvGQ9jwKJh0AEg8XlIFGV1Yt2vY4XKV/0BG0kA7t23xVqRnwUgkYoW5rQrMTmnikLqexFIdFS2bcU1xCPh/NTY9/CT2KTVGngRURN1Zrvy8= X-MS-TrafficTypeDiagnostic: BL0PR07MB4993: X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4993; 20:2FRNuTxJzhZvfLUod8hyJFMAHJgBCbhDAWloXu8f0VD41+xzDJroBsF6Upb1yfTidX/Tx0IygwiiQh4nYVJe7MMJGGqfV3uDPobyGh8uQTjE5Zi/QNhKCgSyqgD6ooRX7PB+j1AeYAANiiX5xdVQzHacr5W7wwKerHkeGuo9OEsGx6LK7RCnyYLGo0yHS42FQW+sJwPrpVlGBJn4lYdPVF8asW4bojQ9uWCRxMmqlFxCpDea5u4TAuQPfFN7tcaeG68Y5O4BYhBe7HCFhChBofPtWZVU9PKu3+EQuPtHHyzzDa32RlSQ2I6Nutn7OTL0qUWiZNuAPrqwMj1Cpoid/II2ImUzw5Ql5HA5pZCZKInnRDWRSZleYaMUBXcddcSnBJsLn0/NGBEmol5w/hruARK0ugvAXxOtZi3erTL2jBSBaA3ZRJW1CuUJcZLOcUNTlaBHgUYCYbCCnbRFj3H62lt5uQzp1BBJffCK+Z3Qa7QLJkAZfjc78innDBYE504ei3ltWgoJqA/Ki0T0/rqwA6HjHwAWzdG89gnyP9OtihCOLgYHIyjk8BSRhNf/4nSGeuzj98sjnTbiY/NpNF7JnGQcgRloo014AlHuMN1+aug= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(278428928389397)(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231311)(944501410)(52105095)(93006095)(10201501046)(3002001)(149027)(150027)(6041310)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699050); SRVR:BL0PR07MB4993; BCL:0; PCL:0; RULEID:; SRVR:BL0PR07MB4993; X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4993; 4:OwepUYy1zIboG+ck84zRNDH7qd4gDePfmO+hOe30TJ+bray86AmK9Ic0+pOokf4SCRr7kgHWzw2vwHZlzjpX75uySeISowikWE6y2gjUfuLHKgOBwRn/hA0QSrLKWb0L28P0ACkc1A/V88Aag8SeZOKq/qQy0MVXja8dIY57Lq0ZaKI2L1yLloW/gw1ZQaQEbO5TaNuOeD/bj56lknmQdxSqRrd1rV2at9mMtKCVy1Gmrhok/QVaHWW7ACGqxQb9LhKiaDCy1g+ggSy0STcRoGe/1elw8JGXvQjTBzFsjd5QtGBYf8BQ+8KDlghSTX/Ou0UhtuLptDa/ABTUhFlhbILO+H6eesaSxUmQDxYMVDo= X-Forefront-PRVS: 07915F544A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(376002)(136003)(39860400002)(346002)(396003)(13464003)(189003)(199004)(54906003)(186003)(1076002)(6916009)(105586002)(11346002)(956004)(446003)(476003)(106356001)(7366002)(8676002)(2906002)(33716001)(3846002)(58126008)(5660300001)(6666003)(68736007)(72206003)(478600001)(6116002)(23726003)(7406005)(305945005)(8936002)(7736002)(7416002)(4326008)(47776003)(97736004)(33656002)(52116002)(6496006)(39060400002)(486006)(316002)(33896004)(76176011)(6246003)(42882007)(53936002)(50466002)(16586007)(386003)(9686003)(55236004)(16526019)(81156014)(26005)(229853002)(55016002)(25786009)(66066001)(44832011)(81166006)(83323001)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BL0PR07MB4993; H:jerin; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BL0PR07MB4993; 23:02N+d7qRBE99s7XRT+QRDQcjO73jp5zuMoX0g64ai?= =?us-ascii?Q?Oe34UNp4SBxwDRui2e0XHuDFxzxaT8o5YTYydXVDwfPBK9GwvWy7BCBYoEa+?= =?us-ascii?Q?KMOX2CZJwY8gOCeZHo4oBONqwWYBuavr4Ulp0LQ95mi6Dj02ea+Tu4DLPqAF?= =?us-ascii?Q?c217zfz8aR0ozW3P+A0yDri+xdz7Atz6x3CD6PvdNZjonq+C8Xi+lmUutrpc?= =?us-ascii?Q?klpAfn6ffoe62rQU626h/tFkZKItb6Y5ERYsbrdHiA8Jgdo3drUmiqA3o8Z8?= =?us-ascii?Q?YfMyd2fQPlJSVgZZgQLJpvq7wiI1tanSS/WdfPR43jNXL8CP/uNKkwjHbn20?= =?us-ascii?Q?d2im0EPzTYZq5NJvTioJmeYngc4A4+DPcdjX7JnpJNvz/OFLiRX23KIO11CK?= =?us-ascii?Q?poG+pBNIg/rheW93DNKD78NsW/7S9RoGlKuorz7D/qbhHB7RfTjhq/XJSyHw?= =?us-ascii?Q?7eDwts0wev0opE5sWzlHcvHr0RPmdfmUWkU1AZSm7RuoUSvRT2lkvoeZkQRs?= =?us-ascii?Q?JUVwwBuIl9b1pe0p4hzzA7oPhtuNt9NYSmlE+n8dboX3bZaeVfR2eFXQ76XV?= =?us-ascii?Q?+mDtVMV7/XG/3PQAbW0FDDHZY6BJWkG0WONPARAza0GEE8TAeBn4r2u7p8tn?= =?us-ascii?Q?/uR8ZVBCXCyQccxqmWsJV9eG6PJLCcu4xEcRx0N3voDb/mmq190Ur9Ts2/+9?= =?us-ascii?Q?CcyGqHB1YZspF9E1ayEUdOFe6tKHHETnZ162qkP6ohFij6xMLj4XR3QWtFvm?= =?us-ascii?Q?8Xl0lZ8dyBdlIxwLf2U/qnISuSF5bhfynyuMtNWWprhRSLpLZc1pWih2s/uv?= =?us-ascii?Q?v0eIzf+5riAOtpT2t/RF0ACIx3dMWL1Cy/cFDv0Ur/WHlH/GL/GucIbOCJUp?= =?us-ascii?Q?oJJAy9RzDedfJZ18i43LTlkaf2XxaU8UqDEmEpWODYEyMnypSt8wKbpuzi4n?= =?us-ascii?Q?szAhy2MIwEBVAwDCJRaAgmG8J013uFtUeVUia+GdEMSzp+uI1kCwnxBKbPdP?= =?us-ascii?Q?nP4hFCxq33Cvj+ozj8tkoxrdEkpSxT2qAIoGVykKqXGJq8lI4P3ThvDXKM+q?= =?us-ascii?Q?uO37MniOLKO2jDAB6pKbB8BY1MoJJIFjM6SLMlv1gITjDInezKA/R+dPFTpe?= =?us-ascii?Q?ofcMTXIe8gLN6RPIdl3UskG93sjICPn6VjaC/AdQcooBDhB+vgCRWd00OD+u?= =?us-ascii?Q?kmJn/SICvZ2s09OPPLU8dGk7vJYG5LXw6L3DxX9M5IRHjp3Pt9utFcPOfyBx?= =?us-ascii?Q?Mmh70Bbh33PbGXaHg3Kijre5jd833OgblmhN7D/AkA1J+eCeKxQvMPkFljIA?= =?us-ascii?Q?3TdPprWXcYsPAaN1LKjhQqzbmJ2pufdD8Bo+1jPlYd9NmD6hTu9dgGxdxz8u?= =?us-ascii?Q?Q6oWeFQm+59L2nDRWnlIDj+qk0VnZxzugGLPN3sdr12W+LFkw3MPORF8ScaA?= =?us-ascii?Q?rOTUGiUh5VElkr6VSWorlMeLguY4+6cirdXNP2PX6HKN2ECLqey?= X-Microsoft-Antispam-Message-Info: BkRc4E9j5OgiPYXPPhWtHkbe0J7vrdGpPgi/rENvYptpLxOgEjZ++FWEKMErfZqW2GSkbxyqfsazAJDbbgBdca3cWyGzBaZdXE88ISDTKucpwdyq6UPkg+vM8JI971mVI6Qpn6lGljuelIkxNXz6p73Rjw7P6BPbX06I/PsyleiiCkAhG1dJPg6nqxQ1/YC0YKKcW31B8AjgLBCwTx9kLkZwHsICJ6KqqCCoOj0ctuZ+OmDbVoCYztlesGitGYI4eDB0AM4TOdtj40f/Qs2OapAZw+CT543d+SpYwodboO7XvxCA5XO7xJs3ApMWUocMBq28Tl8CVWaRKQ5PJqVtbuE5raUpxN7XEo8HmPXjMfk= X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4993; 6:gqv+/3+B09qU0+2iYRDURf1OsMbg8rQ8shf8WMXvAJkaFB6MoO5qWMt+AkjCbhK9b5TxiNYB0ZbzHsR5I/CmxD3gzqfbOj6YxkEGIDr2y+THri1MFCxFznGE9Yrl5TwN2Pn/0tpx+nD4aaWmTp4n9U9Wbo5RtwMYJ494h0/BD9rRleyWsYSl5Iighd5ZwQt9pVYZ6vLh04Z+7eNq9S86s+TZemnv9Wltr9MGzqRIO4UcdEpeglDi1mBpFzIH8l86KA+yt4SH89zlXVaX59JVZtii4vmVMk/y711jiOVAFuPCAAuTkYVwOjF+e4M7Qt6M1ibDNcHnxPIN5bVa01FRq/YUppB0aVHC5h5nU2ldsMvqhBCT91FmN86W3jhtUpbGWyb6u4eXJ8K9q+gMJWNEUE52RboRUBB4+cPy7nbEp2uv0vvM0He0FkZpbqLS6JMyPGUqsTHv8mxHpFLPB9RsDw==; 5:LDJ/8tj/wLYJkKy9JP3RJ0SsSbe9GKZpu2JYwo2ZswVQ4IPLkHc0KK9q+1gdWZ9XEftVvXEPnN4Y3mBveSE3BlGtSAUJoIqm0uHgkTjvMOPlg/xqHEX6XuONJ/oSCiebjK6VJVrnaMr0erBY/LBd9TPA0/SCl8L69f8tb9mrCVk=; 7:U3NS6uPMEC+tei1pQZqYRKjS3MDiG6JuJbLf6ZUyb1O956YooLmnRpOw8HgQh/LIcs74+H0uif3V7H2xd/ul5lKSpY9dulZODVkikvOZGaHjEF43gvfSLGtXQg5/9WMwhC71mgfQmiFTE/4w4C/tEfsp34ORLNk7rrsETa81aRZSAE9ZwQLDlKQ1u4W0e96nPYYCuiEsGMWpA492Iq1JtfEokuO9X3Le+aSTu8QU2cOBH8MOPwFnOww/gkqtZBfI SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2018 11:34:57.7785 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 29451cee-9633-49f3-4cd4-08d617117c0d X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR07MB4993 X-Mailman-Approved-At: Mon, 10 Sep 2018 14:06:52 +0200 Subject: Re: [dpdk-dev] [PATCH v2] ethdev: make default behavior CRC strip on Rx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Sep 2018 11:35:26 -0000 -----Original Message----- > > Removed DEV_RX_OFFLOAD_CRC_STRIP offload flag. > Without any specific Rx offload flag, default behavior by PMDs is to > strip CRC. > > PMDs that support keeping CRC should advertise DEV_RX_OFFLOAD_KEEP_CRC > Rx offload capability. > > Applications that require keeping CRC should check PMD capability first > and if it is supported can enable this feature by setting > DEV_RX_OFFLOAD_KEEP_CRC in Rx offload flag in rte_eth_dev_configure() > > Signed-off-by: Ferruh Yigit > Acked-by: Tomasz Duszynski > --- > v2: > * fix flag check > * add KEEP_CRC flag into "show port cap #" > > Note "show port cap #" and > "show port # [r/t]x_offload capabilities/configuration" > does same thing, in long term I suggest removing "show port cap" one For thunderx and octeontx Acked-by: Jerin Jacob