Re: [dpdk-dev] [PATCH] app/testpmd: add commands for TM to mark pkts

[Jerin Jacob <jerin.jacob@caviumnetworks.com>]

-----Original Message-----
> Date: Fri, 17 Aug 2018 13:39:19 +0200
> From: Krzysztof Kanas <krzysztof.kanas@caviumnetworks.com>
> To: dev@dpdk.org
> Cc: krzysztof.kanas@caviumnetworks.com,
>  Jerin.JacobKollanukkaran@cavium.com, Nithin.Dabilpuram@cavium.com
> Subject: [dpdk-dev] [PATCH] app/testpmd: add commands for TM to mark pkts
> X-Mailer: git-send-email 2.18.0
> 
> Add following testpmd run-time commands to support test of TM packet
> marking:
> 
> set port tm mark ip_ecn   <port_id> <green> <yellow> <red>
> set port tm mark ip_dscp  <port_id> <green> <yellow> <red>
> set port tm mark vlan_dei <port_id> <green> <yellow> <red>
> 
> Signed-off-by: Krzysztof Kanas <krzysztof.kanas@caviumnetworks.com>
> ---
>  app/test-pmd/cmdline.c                      |   3 +
>  app/test-pmd/cmdline_tm.c                   | 260 ++++++++++++++++++++
>  app/test-pmd/cmdline_tm.h                   |   3 +

+ Cristian, Wenzhuo, Jingjing, Bernard 

In addition to this slow path change, IMO, we need test engine similar to
checksum(app/test-pmd/csumonly.c) to generate traffic(app/test-pmd/markonly.c) 
with struct rte_mbuf::tx_offload populated so that we can test the packet
marking.

Cristian,

Any thoughts as a rte_tm maintainer?