From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <hyonkim@cisco.com> Received: from alln-iport-5.cisco.com (alln-iport-5.cisco.com [173.37.142.92]) by dpdk.org (Postfix) with ESMTP id 112C91041 for <dev@dpdk.org>; Tue, 11 Sep 2018 10:05:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1069; q=dns/txt; s=iport; t=1536653141; x=1537862741; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=S4rq2+1qMEtzzHVtD3JqxOeFgib/kE10nAGAWaxUIiY=; b=IqIIdYK1K+4zfPGrn+B40Tix7TYY9AHcy94UQNJAUJwNffATEQNx6jva qS+oVf5ncBy7xs3Xxu3+Fx4nsAxhzLKUYa1x41fG6Ys4P3eFOzKerQJpg b4c6SCzUwnYnaMBKHpAIPJByEg3zN6eAys6h2UTCb9Wb4bXxPZvoZsGBe c=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0ClAAAPdpdb/4kNJK1bGQEBAQEBAQE?= =?us-ascii?q?BAQEBAQcBAQEBAYNOgWQojAWMH4INljQUgWYLhGwChAMhNBgBAgEBAgEBAm0?= =?us-ascii?q?ohTkBBScTPxALGAklDwVJE4UjpWMzigqKZREGgUE/hCSEZoNKgiYCjjONVQm?= =?us-ascii?q?PdyKOcJNmAgQGBQIUgUI4gVUzGggbFYMnkGIwMI4aAQE?= X-IronPort-AV: E=Sophos;i="5.53,359,1531785600"; d="scan'208";a="169422280" Received: from alln-core-4.cisco.com ([173.36.13.137]) by alln-iport-5.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Sep 2018 08:05:40 +0000 Received: from HYONKIM-7R0DR.cisco.com ([10.24.95.245]) by alln-core-4.cisco.com (8.15.2/8.15.2) with ESMTPS id w8B85aqg023119 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 11 Sep 2018 08:05:39 GMT Date: Tue, 11 Sep 2018 17:05:35 +0900 From: Hyong Youb Kim <hyonkim@cisco.com> To: Ferruh Yigit <ferruh.yigit@intel.com> Cc: dev@dpdk.org Message-ID: <20180911080534.GA10096@HYONKIM-7R0DR.cisco.com> References: <20180903144501.31373-1-ferruh.yigit@intel.com> <20180904101257.61129-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180904101257.61129-1-ferruh.yigit@intel.com> User-Agent: Mutt/1.10.0 (2018-05-17) X-Outbound-SMTP-Client: 10.24.95.245, [10.24.95.245] X-Outbound-Node: alln-core-4.cisco.com Subject: Re: [dpdk-dev] [PATCH v2] ethdev: make default behavior CRC strip on Rx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 11 Sep 2018 08:05:41 -0000 On Tue, Sep 04, 2018 at 11:12:56AM +0100, Ferruh Yigit wrote: > Removed DEV_RX_OFFLOAD_CRC_STRIP offload flag. > Without any specific Rx offload flag, default behavior by PMDs is to > strip CRC. > > PMDs that support keeping CRC should advertise DEV_RX_OFFLOAD_KEEP_CRC > Rx offload capability. > > Applications that require keeping CRC should check PMD capability first > and if it is supported can enable this feature by setting > DEV_RX_OFFLOAD_KEEP_CRC in Rx offload flag in rte_eth_dev_configure() [...] > diff --git a/drivers/net/enic/enic_res.c b/drivers/net/enic/enic_res.c > index 8d493ffed..abe004b24 100644 > --- a/drivers/net/enic/enic_res.c > +++ b/drivers/net/enic/enic_res.c > @@ -195,7 +195,6 @@ int enic_get_vnic_config(struct enic *enic) > enic->rx_offload_capa = > DEV_RX_OFFLOAD_SCATTER | > DEV_RX_OFFLOAD_JUMBO_FRAME | > - DEV_RX_OFFLOAD_CRC_STRIP | > DEV_RX_OFFLOAD_VLAN_STRIP | > DEV_RX_OFFLOAD_IPV4_CKSUM | > DEV_RX_OFFLOAD_UDP_CKSUM | For net/enic. Acked-by: Hyong Youb Kim <hyonkim@cisco.com>