From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) by dpdk.org (Postfix) with ESMTP id 1E4C44C9F for ; Tue, 11 Sep 2018 19:04:10 +0200 (CEST) Received: by mail-pl1-f193.google.com with SMTP id f6-v6so11632388plo.1 for ; Tue, 11 Sep 2018 10:04:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=aprdIxTT+eBtXbE0euQwbipHOto9EYpvcEZDJvaabZM=; b=pJ3tfAzegzG+sI9AQy2I3k3oo2uQlAlgMkKMSgwUBaQgRa5gnriH0OLoWZohU0QEuO 91Tcolu3WfI59M02lBpc4o2KLkG1jqcMCL4HE0ocj/lLk1PbuJukpj1NqZT+FlSK8vPX P/jNPI/coWFMErBqg510exMlqjTQMRIuKw1eQtIwfn2wLRPWpGS73+Ux6us9sbJSA5Pe tmHOQkKZj4AlMKqOLdSTPX4Nru3M1/o2mPNCSvuyqP5o+mZf1i4Y+SW7uRQ2Z8iy6txe Aa6Orz7qNcQ6ok/S4f+1GXi9eexfBfQT4BMR2R7RM5SE74x2MKQmKfF6mQKzNMI1JXxi 1Gwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=aprdIxTT+eBtXbE0euQwbipHOto9EYpvcEZDJvaabZM=; b=NWpFqvpa9xqr0HMlh5uZcpv/UD9vbOveFXpTOqdNWxeX1UPch59fhcY2slHx+3t6JG GGoG3xP7CptmGRWfMeoqAYGhwwf0y0JxcMCUT2d0QgGwwfGeyQR5OlVd/7VZotav+7jZ L1U5wGOgBEkwy23uadKFecNY/jeqQdRGhR11hDH5ixywLXAYwN6f0Hp0DoztfHk0fkQp SK5hp/YuNJ8CZ5ow5Ad2zYiFg0RZQLqFnHt02gC3wkG7x85Hc8PGztiI9k+NaktzZOsB a+PKkcWyoRYURJg8N1a1d5drEXi9vaPU3DPYs+C31DDuH9woc35/h9mAYpm5o72orMyv FqYA== X-Gm-Message-State: APzg51BnfoDikxzb1zCulRswRWE1Z7N0nZprn/4v7gwYZ3uUhhUAXHt8 YsNxSzP9yL7y1+52wEbpkumNPw== X-Google-Smtp-Source: ANB0Vdb7856vYdxLlR5Z1xH+BzTWTP/aOGjdWLWXFwy1S4dvz2noKWjReFEMl61RR21dFpdOj9AtaQ== X-Received: by 2002:a17:902:76c5:: with SMTP id j5-v6mr28397216plt.140.1536685448927; Tue, 11 Sep 2018 10:04:08 -0700 (PDT) Received: from xeon-e3 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id i25-v6sm41041048pfi.150.2018.09.11.10.04.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 11 Sep 2018 10:04:08 -0700 (PDT) Date: Tue, 11 Sep 2018 10:04:01 -0700 From: Stephen Hemminger To: Igor Russkikh Cc: dev@dpdk.org, pavel.belous@aquantia.com, Nadezhda.Krupnina@aquantia.com, Simon.Edelhaus@aquantia.com, Corey Melton , Ashish Kumar Message-ID: <20180911100402.581bdba9@xeon-e3> In-Reply-To: <1536333719-32155-5-git-send-email-igor.russkikh@aquantia.com> References: <1536333719-32155-1-git-send-email-igor.russkikh@aquantia.com> <1536333719-32155-5-git-send-email-igor.russkikh@aquantia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 04/21] net/atlantic: hw_atl register declarations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Sep 2018 17:04:10 -0000 On Fri, 7 Sep 2018 18:21:42 +0300 Igor Russkikh wrote: > +/* register address for bitfield imr_rx{r}_en */ > + static u32 itr_imr_rxren_adr[32] = { > + 0x00002100U, 0x00002100U, 0x00002104U, 0x00002104U, > + 0x00002108U, 0x00002108U, 0x0000210CU, 0x0000210CU, > + 0x00002110U, 0x00002110U, 0x00002114U, 0x00002114U, > + 0x00002118U, 0x00002118U, 0x0000211CU, 0x0000211CU, > + 0x00002120U, 0x00002120U, 0x00002124U, 0x00002124U, > + 0x00002128U, 0x00002128U, 0x0000212CU, 0x0000212CU, > + 0x00002130U, 0x00002130U, 0x00002134U, 0x00002134U, > + 0x00002138U, 0x00002138U, 0x0000213CU, 0x0000213CU > + }; > + Don't you want to make these data tables const?