From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
by dpdk.org (Postfix) with ESMTP id 9B2594CA1
for <dev@dpdk.org>; Tue, 11 Sep 2018 15:06:22 +0200 (CEST)
X-Amp-Result: UNSCANNABLE
X-Amp-File-Uploaded: False
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
11 Sep 2018 06:06:21 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.53,360,1531810800"; d="scan'208";a="262514104"
Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.107])
by fmsmga006.fm.intel.com with SMTP; 11 Sep 2018 06:06:16 -0700
Received: by (sSMTP sendmail emulation); Tue, 11 Sep 2018 14:06:16 +0100
Date: Tue, 11 Sep 2018 14:06:15 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Luca Boccassi <bluca@debian.org>, t@bricha3-MOBL.ger.corp.intel.com
Cc: dev@dpdk.org, keith.wiles@intel.com, roy.fan.zhang@intel.com,
jingjing.wu@intel.com, wenzhuo.lu@intel.com, rasesh.mody@cavium.com,
harish.patil@cavium.com, shahed.shaikh@cavium.com,
amr.mokhtar@intel.com, shijith.thotton@cavium.com,
ssrinivasan@cavium.com, liang.j.ma@intel.com,
peter.mccarthy@intel.com, jerin.jacob@caviumnetworks.com,
maciej.czekaj@caviumnetworks.com, arybchenko@solarflare.com,
antosh.shukla@caviumnetworks.com, ashish.gupta@cavium.com,
yongwang@vmware.com, thomas@monjalon.net
Message-ID: <20180911130615.GA11744@bricha3-MOBL.ger.corp.intel.com>
References: <20180910200415.8340-1-bluca@debian.org>
<20180910200415.8340-8-bluca@debian.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180910200415.8340-8-bluca@debian.org>
Organization: Intel Research and Development Ireland Ltd.
User-Agent: Mutt/1.10.1 (2018-07-13)
Subject: Re: [dpdk-dev] [PATCH 07/15] net/liquidio: rename version map after
library file name
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Sep 2018 13:06:23 -0000
On Mon, Sep 10, 2018 at 09:04:07PM +0100, Luca Boccassi wrote:
> The library is called librte_pmd_lio, so rename the map file and set
> the name in the meson file so that the built library names with meson
> and legacy makefiles are the same
>
> Fixes: bad475c03fee ("net/liquidio: add to meson build")
> Cc: stable@dpdk.org
>
> Signed-off-by: Luca Boccassi <bluca@debian.org>
Rather than doing this renaming, can we instead add a symlink in the
install phase to map the old name to the new one? I'd like to see the
consistency of directory name, map filename and driver name enforced
strictly in the build system. Having exceptions is a pain.
/Bruce