From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 488A74C91 for ; Tue, 11 Sep 2018 15:09:49 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Sep 2018 06:09:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,360,1531810800"; d="scan'208";a="262515231" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.107]) by fmsmga006.fm.intel.com with SMTP; 11 Sep 2018 06:09:43 -0700 Received: by (sSMTP sendmail emulation); Tue, 11 Sep 2018 14:09:42 +0100 Date: Tue, 11 Sep 2018 14:09:42 +0100 From: Bruce Richardson To: Luca Boccassi Cc: dev@dpdk.org, keith.wiles@intel.com, roy.fan.zhang@intel.com, jingjing.wu@intel.com, wenzhuo.lu@intel.com, rasesh.mody@cavium.com, harish.patil@cavium.com, shahed.shaikh@cavium.com, amr.mokhtar@intel.com, shijith.thotton@cavium.com, ssrinivasan@cavium.com, liang.j.ma@intel.com, peter.mccarthy@intel.com, jerin.jacob@caviumnetworks.com, maciej.czekaj@caviumnetworks.com, arybchenko@solarflare.com, antosh.shukla@caviumnetworks.com, ashish.gupta@cavium.com, yongwang@vmware.com, thomas@monjalon.net Message-ID: <20180911130941.GB11744@bricha3-MOBL.ger.corp.intel.com> References: <20180910200415.8340-1-bluca@debian.org> <20180910200415.8340-11-bluca@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180910200415.8340-11-bluca@debian.org> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH 10/15] net/thunderx: rename version map after library file name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Sep 2018 13:09:49 -0000 On Mon, Sep 10, 2018 at 09:04:10PM +0100, Luca Boccassi wrote: > The library is called librte_pmd_thunderx_nicvf, so rename the map file > and set the name in the meson file so that the built library names with > meson and legacy makefiles are the same > > Fixes: 7f615033d64f ("drivers/net: build Cavium NIC PMDs with meson") > Cc: stable@dpdk.org > > Signed-off-by: Luca Boccassi > --- Again, I'd prefer we use a symlink if we need to enforce backward compatibility. I also think we should then use the deprecation procedure to remove those symlinks in a later version. /Bruce