From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id CD74A1B19 for ; Tue, 11 Sep 2018 15:30:21 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Sep 2018 06:30:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,360,1531810800"; d="scan'208";a="73358621" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.107]) by orsmga006.jf.intel.com with SMTP; 11 Sep 2018 06:30:18 -0700 Received: by (sSMTP sendmail emulation); Tue, 11 Sep 2018 14:30:18 +0100 Date: Tue, 11 Sep 2018 14:30:17 +0100 From: Bruce Richardson To: Luca Boccassi Cc: dev@dpdk.org Message-ID: <20180911133017.GC11744@bricha3-MOBL.ger.corp.intel.com> References: <20180910200415.8340-1-bluca@debian.org> <20180910200415.8340-8-bluca@debian.org> <20180911130615.GA11744@bricha3-MOBL.ger.corp.intel.com> <1536671370.10952.18.camel@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1536671370.10952.18.camel@debian.org> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH 07/15] net/liquidio: rename version map after library file name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Sep 2018 13:30:22 -0000 On Tue, Sep 11, 2018 at 02:09:30PM +0100, Luca Boccassi wrote: > On Tue, 2018-09-11 at 14:06 +0100, Bruce Richardson wrote: > > On Mon, Sep 10, 2018 at 09:04:07PM +0100, Luca Boccassi wrote: > > > The library is called librte_pmd_lio, so rename the map file and > > > set > > > the name in the meson file so that the built library names with > > > meson > > > and legacy makefiles are the same > > > > > > Fixes: bad475c03fee ("net/liquidio: add to meson build") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Luca Boccassi > > > > Rather than doing this renaming, can we instead add a symlink in the > > install phase to map the old name to the new one? I'd like to see the > > consistency of directory name, map filename and driver name enforced > > strictly in the build system. Having exceptions is a pain. > > > > /Bruce > > We could, but the pain gets shifted on packagers then - what about > renaming the directory entirely to net/lio? > It is still an issue with packagers if the symlinks are created as part of the install step of DPDK itself (which is what I was intending)? I was thinking of adding a new post-install script for the backward compatible renames. As for renaming the directory, I don't mind, but I'll let the driver maintainers comment on their thoughts on it. /Bruce