From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <jfreimann@redhat.com>
Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])
by dpdk.org (Postfix) with ESMTP id 12AE31041
for <dev@dpdk.org>; Wed, 12 Sep 2018 11:05:03 +0200 (CEST)
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com
[10.11.54.6])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by mx1.redhat.com (Postfix) with ESMTPS id A8ACCDFE5;
Wed, 12 Sep 2018 09:05:02 +0000 (UTC)
Received: from localhost (dhcp-192-209.str.redhat.com [10.33.192.209])
by smtp.corp.redhat.com (Postfix) with ESMTPS id 55CCC2166BA2;
Wed, 12 Sep 2018 09:05:00 +0000 (UTC)
Date: Wed, 12 Sep 2018 11:04:59 +0200
From: Jens Freimann <jfreimann@redhat.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: dev@dpdk.org, tiwei.bie@intel.com
Message-ID: <20180912090459.qu2c2ss6oyjslh7p@jenstp.localdomain>
References: <20180906181947.20646-1-jfreimann@redhat.com>
<20180906181947.20646-2-jfreimann@redhat.com>
<e8859808-390c-f4c9-3296-dacf93507ee6@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <e8859808-390c-f4c9-3296-dacf93507ee6@redhat.com>
User-Agent: NeoMutt/20180716
X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
(mx1.redhat.com [10.11.55.2]); Wed, 12 Sep 2018 09:05:02 +0000 (UTC)
X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]);
Wed, 12 Sep 2018 09:05:02 +0000 (UTC) for IP:'10.11.54.6'
DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com'
HELO:'smtp.corp.redhat.com' FROM:'jfreimann@redhat.com' RCPT:''
Subject: Re: [dpdk-dev] [PATCH v5 01/11] net/virtio: vring init for packed
queues
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Sep 2018 09:05:03 -0000
On Wed, Sep 12, 2018 at 10:02:30AM +0200, Maxime Coquelin wrote:
>
>
>On 09/06/2018 08:19 PM, Jens Freimann wrote:
>> vq->vq_free_cnt = vq->vq_nentries;
>> memset(vq->vq_descx, 0, sizeof(struct vq_desc_extra) * vq->vq_nentries);
>>+ vq->vq_used_cons_idx = 0;
>>+ vq->vq_avail_idx = 0;
>>+ if (vtpci_packed_queue(vq->hw)) {
>>+ vring_desc_init_packed(vr, size);
>>+ } else {
>>+ vq->vq_desc_head_idx = 0;
>>+ vq->vq_desc_tail_idx = (uint16_t)(vq->vq_nentries - 1);
>>- vring_desc_init(vr->desc, size);
>>+ vring_desc_init(vr->desc, size);
>>+ }
>
>Maybe worth renaming to vring_desc_init_split() for consistency.
yes, I'll rename it.
regards,
Jens