From: Timothy Redaelli <tredaelli@redhat.com>
To: Luca Boccassi <bluca@debian.org>
Cc: dev@dpdk.org, bruce.richardson@intel.com
Subject: Re: [dpdk-dev] [PATCH] build: create relative symlinks for PMDs in libdir
Date: Wed, 12 Sep 2018 19:39:10 +0200 [thread overview]
Message-ID: <20180912193910.6597fdf4@redhat.com> (raw)
In-Reply-To: <20180912172134.21099-1-bluca@debian.org>
On Wed, 12 Sep 2018 18:21:34 +0100
Luca Boccassi <bluca@debian.org> wrote:
> Add -r option to ln, otherwise the link will be absolute and contain
> the build path and break packaging among other things:
>
> lrwxrwxrwx 1 bluca bluca 99 Sep 11 22:17
> librte_mempool_dpaa.so.1.1
> -> /home/bluca/git/dpdk/testt4//usr/local/lib/x86_64-linux-gnu/dpdk/
> drivers/librte_mempool_dpaa.so.1.1
>
> With -r:
>
> lrwxrwxrwx 1 bluca bluca 35 Sep 12 18:13 librte_pmd_zlib.so.1.1
> -> dpdk/drivers/librte_pmd_zlib.so.1.1
>
> Fixes: ed4d43d73e2b ("build: symlink drivers to library directory")
> Cc: stable@dpdk.org
>
> Signed-off-by: Luca Boccassi <bluca@debian.org>
Tested on Fedora 28 by building dpdk using meson from a spec file
Tested-by: Timothy Redaelli <tredaelli@redhat.com>
next prev parent reply other threads:[~2018-09-12 17:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 17:21 Luca Boccassi
2018-09-12 17:39 ` Timothy Redaelli [this message]
2018-09-13 9:11 ` Bruce Richardson
2018-09-17 11:38 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180912193910.6597fdf4@redhat.com \
--to=tredaelli@redhat.com \
--cc=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).