From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tredaelli@redhat.com>
Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])
 by dpdk.org (Postfix) with ESMTP id 14B1E4CA7
 for <dev@dpdk.org>; Wed, 12 Sep 2018 19:39:13 +0200 (CEST)
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com
 [10.11.54.3])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 904E487A87;
 Wed, 12 Sep 2018 17:39:12 +0000 (UTC)
Received: from localhost (unknown [10.32.181.196])
 by smtp.corp.redhat.com (Postfix) with ESMTP id CD68C10CD7C3;
 Wed, 12 Sep 2018 17:39:11 +0000 (UTC)
Date: Wed, 12 Sep 2018 19:39:10 +0200
From: Timothy Redaelli <tredaelli@redhat.com>
To: Luca Boccassi <bluca@debian.org>
Cc: dev@dpdk.org, bruce.richardson@intel.com
Message-ID: <20180912193910.6597fdf4@redhat.com>
In-Reply-To: <20180912172134.21099-1-bluca@debian.org>
References: <20180912172134.21099-1-bluca@debian.org>
Organization: Red Hat
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.11.55.1]); Wed, 12 Sep 2018 17:39:12 +0000 (UTC)
X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]);
 Wed, 12 Sep 2018 17:39:12 +0000 (UTC) for IP:'10.11.54.3'
 DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com'
 HELO:'smtp.corp.redhat.com' FROM:'tredaelli@redhat.com' RCPT:''
Subject: Re: [dpdk-dev] [PATCH] build: create relative symlinks for PMDs in
	libdir
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Sep 2018 17:39:13 -0000

On Wed, 12 Sep 2018 18:21:34 +0100
Luca Boccassi <bluca@debian.org> wrote:

> Add -r option to ln, otherwise the link will be absolute and contain
> the build path and break packaging among other things:
> 
> lrwxrwxrwx 1 bluca bluca     99 Sep 11 22:17
> librte_mempool_dpaa.so.1.1
> -> /home/bluca/git/dpdk/testt4//usr/local/lib/x86_64-linux-gnu/dpdk/
> drivers/librte_mempool_dpaa.so.1.1
> 
> With -r:
> 
> lrwxrwxrwx 1 bluca bluca     35 Sep 12 18:13 librte_pmd_zlib.so.1.1
>   -> dpdk/drivers/librte_pmd_zlib.so.1.1  
> 
> Fixes: ed4d43d73e2b ("build: symlink drivers to library directory")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Luca Boccassi <bluca@debian.org>

Tested on Fedora 28 by building dpdk using meson from a spec file

Tested-by: Timothy Redaelli <tredaelli@redhat.com>