From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 475014F91 for ; Thu, 13 Sep 2018 11:13:27 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Sep 2018 02:13:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,368,1531810800"; d="scan'208";a="83149240" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.107]) by orsmga003.jf.intel.com with SMTP; 13 Sep 2018 02:11:40 -0700 Received: by (sSMTP sendmail emulation); Thu, 13 Sep 2018 10:11:36 +0100 Date: Thu, 13 Sep 2018 10:11:36 +0100 From: Bruce Richardson To: Luca Boccassi Cc: dev@dpdk.org, tredaelli@redhat.com Message-ID: <20180913091135.GA20960@bricha3-MOBL.ger.corp.intel.com> References: <20180912172134.21099-1-bluca@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180912172134.21099-1-bluca@debian.org> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH] build: create relative symlinks for PMDs in libdir X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Sep 2018 09:13:27 -0000 On Wed, Sep 12, 2018 at 06:21:34PM +0100, Luca Boccassi wrote: > Add -r option to ln, otherwise the link will be absolute and contain > the build path and break packaging among other things: > > lrwxrwxrwx 1 bluca bluca 99 Sep 11 22:17 librte_mempool_dpaa.so.1.1 > -> /home/bluca/git/dpdk/testt4//usr/local/lib/x86_64-linux-gnu/dpdk/ > drivers/librte_mempool_dpaa.so.1.1 > > With -r: > > lrwxrwxrwx 1 bluca bluca 35 Sep 12 18:13 librte_pmd_zlib.so.1.1 > -> dpdk/drivers/librte_pmd_zlib.so.1.1 > > Fixes: ed4d43d73e2b ("build: symlink drivers to library directory") > Cc: stable@dpdk.org > > Signed-off-by: Luca Boccassi > --- > buildtools/symlink-drivers-solibs.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/buildtools/symlink-drivers-solibs.sh b/buildtools/symlink-drivers-solibs.sh > index 803dfec491..9826c6ae37 100644 > --- a/buildtools/symlink-drivers-solibs.sh > +++ b/buildtools/symlink-drivers-solibs.sh > @@ -9,4 +9,4 @@ > # parameters to script are paths relative to install prefix: > # 1. directory containing driver files e.g. lib64/dpdk/drivers > # 2. directory for installed regular libs e.g. lib64 > -ln -sf ${DESTDIR}/${MESON_INSTALL_PREFIX}/$1/* ${DESTDIR}/${MESON_INSTALL_PREFIX}/$2 > +ln -rsf ${DESTDIR}/${MESON_INSTALL_PREFIX}/$1/* ${DESTDIR}/${MESON_INSTALL_PREFIX}/$2 > -- Acked-by: Bruce Richardson