* [dpdk-dev] [PATCH] build: create relative symlinks for PMDs in libdir
@ 2018-09-12 17:21 Luca Boccassi
2018-09-12 17:39 ` Timothy Redaelli
2018-09-13 9:11 ` Bruce Richardson
0 siblings, 2 replies; 4+ messages in thread
From: Luca Boccassi @ 2018-09-12 17:21 UTC (permalink / raw)
To: dev; +Cc: bruce.richardson, tredaelli
Add -r option to ln, otherwise the link will be absolute and contain
the build path and break packaging among other things:
lrwxrwxrwx 1 bluca bluca 99 Sep 11 22:17 librte_mempool_dpaa.so.1.1
-> /home/bluca/git/dpdk/testt4//usr/local/lib/x86_64-linux-gnu/dpdk/
drivers/librte_mempool_dpaa.so.1.1
With -r:
lrwxrwxrwx 1 bluca bluca 35 Sep 12 18:13 librte_pmd_zlib.so.1.1
-> dpdk/drivers/librte_pmd_zlib.so.1.1
Fixes: ed4d43d73e2b ("build: symlink drivers to library directory")
Cc: stable@dpdk.org
Signed-off-by: Luca Boccassi <bluca@debian.org>
---
buildtools/symlink-drivers-solibs.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/buildtools/symlink-drivers-solibs.sh b/buildtools/symlink-drivers-solibs.sh
index 803dfec491..9826c6ae37 100644
--- a/buildtools/symlink-drivers-solibs.sh
+++ b/buildtools/symlink-drivers-solibs.sh
@@ -9,4 +9,4 @@
# parameters to script are paths relative to install prefix:
# 1. directory containing driver files e.g. lib64/dpdk/drivers
# 2. directory for installed regular libs e.g. lib64
-ln -sf ${DESTDIR}/${MESON_INSTALL_PREFIX}/$1/* ${DESTDIR}/${MESON_INSTALL_PREFIX}/$2
+ln -rsf ${DESTDIR}/${MESON_INSTALL_PREFIX}/$1/* ${DESTDIR}/${MESON_INSTALL_PREFIX}/$2
--
2.18.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] build: create relative symlinks for PMDs in libdir
2018-09-12 17:21 [dpdk-dev] [PATCH] build: create relative symlinks for PMDs in libdir Luca Boccassi
@ 2018-09-12 17:39 ` Timothy Redaelli
2018-09-13 9:11 ` Bruce Richardson
1 sibling, 0 replies; 4+ messages in thread
From: Timothy Redaelli @ 2018-09-12 17:39 UTC (permalink / raw)
To: Luca Boccassi; +Cc: dev, bruce.richardson
On Wed, 12 Sep 2018 18:21:34 +0100
Luca Boccassi <bluca@debian.org> wrote:
> Add -r option to ln, otherwise the link will be absolute and contain
> the build path and break packaging among other things:
>
> lrwxrwxrwx 1 bluca bluca 99 Sep 11 22:17
> librte_mempool_dpaa.so.1.1
> -> /home/bluca/git/dpdk/testt4//usr/local/lib/x86_64-linux-gnu/dpdk/
> drivers/librte_mempool_dpaa.so.1.1
>
> With -r:
>
> lrwxrwxrwx 1 bluca bluca 35 Sep 12 18:13 librte_pmd_zlib.so.1.1
> -> dpdk/drivers/librte_pmd_zlib.so.1.1
>
> Fixes: ed4d43d73e2b ("build: symlink drivers to library directory")
> Cc: stable@dpdk.org
>
> Signed-off-by: Luca Boccassi <bluca@debian.org>
Tested on Fedora 28 by building dpdk using meson from a spec file
Tested-by: Timothy Redaelli <tredaelli@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] build: create relative symlinks for PMDs in libdir
2018-09-12 17:21 [dpdk-dev] [PATCH] build: create relative symlinks for PMDs in libdir Luca Boccassi
2018-09-12 17:39 ` Timothy Redaelli
@ 2018-09-13 9:11 ` Bruce Richardson
2018-09-17 11:38 ` Thomas Monjalon
1 sibling, 1 reply; 4+ messages in thread
From: Bruce Richardson @ 2018-09-13 9:11 UTC (permalink / raw)
To: Luca Boccassi; +Cc: dev, tredaelli
On Wed, Sep 12, 2018 at 06:21:34PM +0100, Luca Boccassi wrote:
> Add -r option to ln, otherwise the link will be absolute and contain
> the build path and break packaging among other things:
>
> lrwxrwxrwx 1 bluca bluca 99 Sep 11 22:17 librte_mempool_dpaa.so.1.1
> -> /home/bluca/git/dpdk/testt4//usr/local/lib/x86_64-linux-gnu/dpdk/
> drivers/librte_mempool_dpaa.so.1.1
>
> With -r:
>
> lrwxrwxrwx 1 bluca bluca 35 Sep 12 18:13 librte_pmd_zlib.so.1.1
> -> dpdk/drivers/librte_pmd_zlib.so.1.1
>
> Fixes: ed4d43d73e2b ("build: symlink drivers to library directory")
> Cc: stable@dpdk.org
>
> Signed-off-by: Luca Boccassi <bluca@debian.org>
> ---
> buildtools/symlink-drivers-solibs.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/buildtools/symlink-drivers-solibs.sh b/buildtools/symlink-drivers-solibs.sh
> index 803dfec491..9826c6ae37 100644
> --- a/buildtools/symlink-drivers-solibs.sh
> +++ b/buildtools/symlink-drivers-solibs.sh
> @@ -9,4 +9,4 @@
> # parameters to script are paths relative to install prefix:
> # 1. directory containing driver files e.g. lib64/dpdk/drivers
> # 2. directory for installed regular libs e.g. lib64
> -ln -sf ${DESTDIR}/${MESON_INSTALL_PREFIX}/$1/* ${DESTDIR}/${MESON_INSTALL_PREFIX}/$2
> +ln -rsf ${DESTDIR}/${MESON_INSTALL_PREFIX}/$1/* ${DESTDIR}/${MESON_INSTALL_PREFIX}/$2
> --
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] build: create relative symlinks for PMDs in libdir
2018-09-13 9:11 ` Bruce Richardson
@ 2018-09-17 11:38 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2018-09-17 11:38 UTC (permalink / raw)
To: Luca Boccassi; +Cc: dev, Bruce Richardson, tredaelli
13/09/2018 11:11, Bruce Richardson:
> On Wed, Sep 12, 2018 at 06:21:34PM +0100, Luca Boccassi wrote:
> > Add -r option to ln, otherwise the link will be absolute and contain
> > the build path and break packaging among other things:
> >
> > lrwxrwxrwx 1 bluca bluca 99 Sep 11 22:17 librte_mempool_dpaa.so.1.1
> > -> /home/bluca/git/dpdk/testt4//usr/local/lib/x86_64-linux-gnu/dpdk/
> > drivers/librte_mempool_dpaa.so.1.1
> >
> > With -r:
> >
> > lrwxrwxrwx 1 bluca bluca 35 Sep 12 18:13 librte_pmd_zlib.so.1.1
> > -> dpdk/drivers/librte_pmd_zlib.so.1.1
> >
> > Fixes: ed4d43d73e2b ("build: symlink drivers to library directory")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > ---
> > buildtools/symlink-drivers-solibs.sh | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/buildtools/symlink-drivers-solibs.sh b/buildtools/symlink-drivers-solibs.sh
> > index 803dfec491..9826c6ae37 100644
> > --- a/buildtools/symlink-drivers-solibs.sh
> > +++ b/buildtools/symlink-drivers-solibs.sh
> > @@ -9,4 +9,4 @@
> > # parameters to script are paths relative to install prefix:
> > # 1. directory containing driver files e.g. lib64/dpdk/drivers
> > # 2. directory for installed regular libs e.g. lib64
> > -ln -sf ${DESTDIR}/${MESON_INSTALL_PREFIX}/$1/* ${DESTDIR}/${MESON_INSTALL_PREFIX}/$2
> > +ln -rsf ${DESTDIR}/${MESON_INSTALL_PREFIX}/$1/* ${DESTDIR}/${MESON_INSTALL_PREFIX}/$2
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-09-17 11:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-12 17:21 [dpdk-dev] [PATCH] build: create relative symlinks for PMDs in libdir Luca Boccassi
2018-09-12 17:39 ` Timothy Redaelli
2018-09-13 9:11 ` Bruce Richardson
2018-09-17 11:38 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).