From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 919CF4C91 for ; Thu, 13 Sep 2018 08:07:30 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Sep 2018 23:07:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,368,1531810800"; d="scan'208";a="89601319" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.110.207]) by fmsmga001.fm.intel.com with ESMTP; 12 Sep 2018 23:07:27 -0700 Date: Thu, 13 Sep 2018 20:55:19 +0800 From: Ye Xiaolong To: Xiao Wang Cc: tiwei.bie@intel.com, dev@dpdk.org Message-ID: <20180913125519.GA13400@intel.com> References: <20180910110531.138449-1-xiao.w.wang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180910110531.138449-1-xiao.w.wang@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] net/ifc: do not notify before HW ready X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Sep 2018 06:07:31 -0000 Hi, Xiao On 09/10, Xiao Wang wrote: >Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver") Could you help describe what problem is without this fix in commit log? Thanks, Xiaolong > >Signed-off-by: Xiao Wang >--- > drivers/net/ifc/ifcvf_vdpa.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/drivers/net/ifc/ifcvf_vdpa.c b/drivers/net/ifc/ifcvf_vdpa.c >index 3c5430dc0..7d3085d8d 100644 >--- a/drivers/net/ifc/ifcvf_vdpa.c >+++ b/drivers/net/ifc/ifcvf_vdpa.c >@@ -503,11 +503,11 @@ update_datapath(struct ifcvf_internal *internal) > if (ret) > goto err; > >- ret = setup_notify_relay(internal); >+ ret = vdpa_ifcvf_start(internal); > if (ret) > goto err; > >- ret = vdpa_ifcvf_start(internal); >+ ret = setup_notify_relay(internal); > if (ret) > goto err; > >@@ -515,12 +515,12 @@ update_datapath(struct ifcvf_internal *internal) > } else if (rte_atomic32_read(&internal->running) && > (!rte_atomic32_read(&internal->started) || > !rte_atomic32_read(&internal->dev_attached))) { >- vdpa_ifcvf_stop(internal); >- > ret = unset_notify_relay(internal); > if (ret) > goto err; > >+ vdpa_ifcvf_stop(internal); >+ > ret = vdpa_disable_vfio_intr(internal); > if (ret) > goto err; >-- >2.15.1 >