From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <bruce.richardson@intel.com> Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id A2C681B027 for <dev@dpdk.org>; Thu, 13 Sep 2018 16:49:02 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Sep 2018 07:49:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,369,1531810800"; d="scan'208";a="262298818" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.107]) by fmsmga005.fm.intel.com with SMTP; 13 Sep 2018 07:48:02 -0700 Received: by (sSMTP sendmail emulation); Thu, 13 Sep 2018 15:48:02 +0100 Date: Thu, 13 Sep 2018 15:48:01 +0100 From: Bruce Richardson <bruce.richardson@intel.com> To: Luca Boccassi <bluca@debian.org> Cc: dev@dpdk.org, keith.wiles@intel.com, roy.fan.zhang@intel.com, jingjing.wu@intel.com, wenzhuo.lu@intel.com, rasesh.mody@cavium.com, harish.patil@cavium.com, shahed.shaikh@cavium.com, amr.mokhtar@intel.com, shijith.thotton@cavium.com, ssrinivasan@cavium.com, liang.j.ma@intel.com, peter.mccarthy@intel.com, jerin.jacob@caviumnetworks.com, maciej.czekaj@caviumnetworks.com, arybchenko@solarflare.com, santosh.shukla@caviumnetworks.com, ashish.gupta@cavium.com, yongwang@vmware.com, thomas@monjalon.net Message-ID: <20180913144801.GC14728@bricha3-MOBL.ger.corp.intel.com> References: <20180910200415.8340-1-bluca@debian.org> <20180911160903.27226-1-bluca@debian.org> <20180911160903.27226-4-bluca@debian.org> <20180913132442.GB14728@bricha3-MOBL.ger.corp.intel.com> <1536845274.10952.51.camel@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1536845274.10952.51.camel@debian.org> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH v2 4/9] build: add Meson files for avf PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 13 Sep 2018 14:49:03 -0000 On Thu, Sep 13, 2018 at 02:27:54PM +0100, Luca Boccassi wrote: > On Thu, 2018-09-13 at 14:24 +0100, Bruce Richardson wrote: > > On Tue, Sep 11, 2018 at 05:08:58PM +0100, Luca Boccassi wrote: > > > Signed-off-by: Luca Boccassi <bluca@debian.org> > > > --- > > > drivers/net/avf/base/meson.build | 20 ++++++++++++++++++++ > > > drivers/net/avf/meson.build | 15 +++++++++++++++ > > > drivers/net/meson.build | 1 + > > > 3 files changed, 36 insertions(+) > > > create mode 100644 drivers/net/avf/base/meson.build > > > create mode 100644 drivers/net/avf/meson.build > > > > > > > After applying this patch, I get lots of unused variable warnings. > > Gcc 6.3 > > on debian, you'll be glad to know. > > > > /Bruce > > Yep got the same, but I'll leave that for the AVF maintainers to have > fun with :-) > Ok, I've sent a patch to remove the unused stuff. http://patches.dpdk.org/patch/44694/ I think this file still needs "cflags += '-Wno-strict-aliasing'" to make it work though, since those errors are tougher to remove. There also needs to be an "INC_VECTOR" define inside the x86-specific block, as is done for the IXGBE and I40E drivers. /Bruce