From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 11ECE58CB for ; Fri, 14 Sep 2018 07:33:40 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Sep 2018 22:33:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,372,1531810800"; d="scan'208";a="69897591" Received: from btwcube1.sh.intel.com (HELO debian) ([10.67.104.151]) by fmsmga007.fm.intel.com with ESMTP; 13 Sep 2018 22:33:37 -0700 Date: Fri, 14 Sep 2018 13:32:36 +0800 From: Tiwei Bie To: Jens Freimann Cc: dev@dpdk.org, maxime.coquelin@redhat.com Message-ID: <20180914053236.GA19348@debian> References: <20180906181947.20646-1-jfreimann@redhat.com> <20180906181947.20646-10-jfreimann@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180906181947.20646-10-jfreimann@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH v5 09/11] net/virtio: disable ctrl virtqueue for packed rings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Sep 2018 05:33:42 -0000 On Thu, Sep 06, 2018 at 07:19:45PM +0100, Jens Freimann wrote: > Signed-off-by: Jens Freiman > --- > drivers/net/virtio/virtio_ethdev.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c > index a2bb726ba..b02c65598 100644 > --- a/drivers/net/virtio/virtio_ethdev.c > +++ b/drivers/net/virtio/virtio_ethdev.c > @@ -1161,6 +1161,15 @@ virtio_negotiate_features(struct virtio_hw *hw, uint64_t req_features) > req_features &= ~(1ULL << VIRTIO_NET_F_MTU); > } > > +#ifdef RTE_LIBRTE_VIRTIO_PQ > + if (req_features & (1ULL << VIRTIO_F_RING_PACKED)) { > + req_features &= ~(1ull << VIRTIO_NET_F_CTRL_MAC_ADDR); > + req_features &= ~(1ull << VIRTIO_NET_F_CTRL_VQ); > + req_features &= ~(1ull << VIRTIO_NET_F_CTRL_RX); > + req_features &= ~(1ull << VIRTIO_NET_F_CTRL_VLAN); > + } > +#endif I think we need to support ctrl vq. And in performance test, we need to use more cores on vhost side to make sure that we can get the max performance of the virtio PMD. Otherwise, it's likely that the performance gain we get is the gain in vhost. > + > /* > * Negotiate features: Subset of device feature bits are written back > * guest feature bits. > -- > 2.17.1 >