From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0043.outbound.protection.outlook.com [104.47.34.43]) by dpdk.org (Postfix) with ESMTP id AA1605681 for ; Fri, 14 Sep 2018 08:38:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WGIEIWJHLECfZxOpp/Vf1Ggi2F/ohQlD3bUNMW799/A=; b=eaI1mpSNvINqi1tl++jQd2st7qn/l5ofkp6wE+whJhT4hwFTyVJQA3Gswe/r5bTR3Ed5u53J6FLtr6rhyhsJUYc9mTj7yMNRCvjOOjKnjhPRdzNStnjhIivT58rB0adjXHvM2CH39yTd0OneqQpiLa7GJwXYO7S+G3/y0JyrOPg= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (122.178.212.30) by DM6PR07MB5004.namprd07.prod.outlook.com (2603:10b6:5:25::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1143.15; Fri, 14 Sep 2018 06:35:24 +0000 Date: Fri, 14 Sep 2018 12:05:11 +0530 From: Jerin Jacob To: David Marchand Cc: Raslan Darawsheh , "Wu, Jingjing" , Thomas Monjalon , dev@dpdk.org, Shahaf Shuler , xuemingl@mellanox.com Message-ID: <20180914063509.GA8298@jerin> References: <1536739583-29166-1-git-send-email-rasland@mellanox.com> <1536739583-29166-2-git-send-email-rasland@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Originating-IP: [122.178.212.30] X-ClientProxiedBy: PN1PR01CA0101.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00::17) To DM6PR07MB5004.namprd07.prod.outlook.com (2603:10b6:5:25::25) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c48d8503-afd5-44f3-ebdd-08d61a0c426b X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:DM6PR07MB5004; X-Microsoft-Exchange-Diagnostics: 1; DM6PR07MB5004; 3:GdC2xOS5PCnNAfnsEv3Xay4yuHvzeuBqkbNqD+iHMojHvWnyK1EDNKot45N/pgrTSaiP6bk6frEV4nK1dFnHRmdvAOLv8h616wDhmB3XnJecyXjYONsgfeiDqsN7pFfhW4luCkWtGseyHnyPCeTo4CYGJs0abOYzb+jFf3fYc4H4hM9MQ/UhPQzx18TQQJNecGaBn0jafKg/02qgaQ5Y3l8bw0seYml/tZeh1NVFMJxMDz8kXmry6ru0Pyj/ep8K; 25:gTBYO+qGPQvP00k2oVxURrk5tOt9zxyGhyjSEQVqabIzzxDa1QiEd+KfLwqKRyYlp2l6RP3+JXVk/fnx4eNTIbijNpmQr/ezkQBjKeU7MrWvDRRxj+F7bhJKXWky3QQuMTe6KFs+0ozkAt5BaAwiqdn8b7/KxPSsK5pq6eJi04XlAXXcNgCrBIckomXhwVYBi4MXn80Lr2uy4SVb44g5w8NvnXVIbsoNoa8pW4URVJIesIMf2bXMZhijEjYT92q0iormNfNYdsDpPdwfaFmSUFpVPKGg2H9Gu2Udq/sJndX3AclbW+EtUtJYzL2JHFvL/X/qLtdWfFjts/gG5SEagw==; 31:fFUgVWcdy0Gm5yVmkZ42WE7zys7xYARljQFAEj+8UuA/NgbVgOU2unMlfsNxTWlmCEdF6XX1T9nivGiExSBJ/LIUVH+I1zqSR2cI94fi+DcITmsRdCo2uyQGEQ2nVdnCqhaf0OLaYr+EJwapenDgSIyWF7ZA1vxvck73Q135TEmR4ZQi6qgFfJfqZ7ZTS6Rj6IOzmvXM3igcDBstqg4/U6/tQe7r9qCNBHTbqnrdikE= X-MS-TrafficTypeDiagnostic: DM6PR07MB5004: X-Microsoft-Exchange-Diagnostics: 1; DM6PR07MB5004; 20:XjzHVleL6tqTrt3/bWKklcqvJicnxYlzjySm/mXp3eFVuGVZv89o4uke4K1xjhKnsSr/TN5Nwcj0F+wvULDtehOSEvYwXMTM1LjCHfnM7HIPGeq/owgy/SZL7k8loOwnuQHdHxnlbq98Kcj2wJameA8fmgNCBHPYmZLhY1k61sdbcElqilscT/OB3pAhGIGw4EcfVCvRnvhgHMEC1fxZPpffXt3vzk2/52ZC41ra/ohMSAmN8deyGoKxDMMwbj7mlU6Sn7JtQteJZqPYD6I6CQ8quNeV0XqCYCKP0uRjOD/ERRwWDvXO+zkUqcMTxSRe62/hsus1fnRdZSzh+adKbxU6Shqam//yFhf2+ot/fmisOI39GhZG9nwJe7FgWlA9PRvCjP+AmY6i6xTTmHdDlBsSbUvyRs500IglqUY4ZW1uZ/0zhyjYb5mXg29bdW77ebFdr0wh4jgHx+y4Muu5i6y4ym3undZ//aMaWlGkomjdNDROv3iWEJKSQDkei/hXiuwtMjlVoEogfLzCG3MWoUwbgaTrAtYDndoGK+cEKL5sobm303rbcRvaQH3jvWzVOY7oZsRxbMlWVz2RWcg8XsAHLN2kcqpFbS7YBd5+Qh4=; 4:wn0CBdLfT39TvtSJL4pZnCMw1aLCe9Lvr32zcSCPqhy0KSraeNndd7Hz66O03+F8uh6N+hRt7RxdP6dlVZ8UaYMzAZcf+H+uqYdtaKzW5lLRerBo8C6OWo9nmvh0BGQq2+1tvOY+Qs/NetbNL5P+cyDcrz3wjZz6SZX2EMcIAtaRZyn7a81WVSKrlCrlrPvGsMCON8g9JN2/+rbIFCXjxyqcc5rozBvzeUIlnZio16jX6DLGkRwKdEjmT42HHURA0yCrMEXvITIy4C70hAOao+Hk8q3X/hygPp5Ylrjxur2xSLfzpqUaovOeFHFBGZSh X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(3231311)(944501410)(52105095)(10201501046)(3002001)(149027)(150027)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123558120)(20161123564045)(201708071742011)(7699050); SRVR:DM6PR07MB5004; BCL:0; PCL:0; RULEID:; SRVR:DM6PR07MB5004; X-Forefront-PRVS: 07954CC105 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(136003)(39860400002)(346002)(366004)(376002)(396003)(199004)(189003)(13464003)(76176011)(33896004)(52116002)(6496006)(4326008)(6666003)(33716001)(229853002)(6916009)(25786009)(68736007)(2906002)(66066001)(106356001)(47776003)(33656002)(5660300001)(105586002)(42882007)(50466002)(486006)(446003)(476003)(44832011)(11346002)(956004)(6246003)(16526019)(53936002)(26005)(53546011)(386003)(186003)(6306002)(9686003)(55016002)(478600001)(6116002)(3846002)(8936002)(1076002)(58126008)(97736004)(81156014)(72206003)(54906003)(16586007)(81166006)(305945005)(8676002)(316002)(966005)(7736002)(23726003)(18370500001)(41533002); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR07MB5004; H:jerin; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM6PR07MB5004; 23:OY/YZy/CkWGU9M3fEuWrK7J7HLt+JHC14IbldtjPB?= =?us-ascii?Q?NvPLYlcPxVCqDB9SqFxvulp86i1h6BNWwOt6VOh8J95Js9pf8lkQAtqZgWur?= =?us-ascii?Q?2VITJBYPc6xzBPQg1Py/nVeIFPlys0iXBJ3/W6CyFemQrvwH8eaGw7FDNZu4?= =?us-ascii?Q?mhYZPEZuaTNyQPme9j+C5jkMuyW3g68ZQooQMGFo+odAVrGeyJdr+vM4E3UM?= =?us-ascii?Q?QTbykwon/zpxCFSH6J4tZ5H65DddKcFoviTsDyQLqEPCxUrl9RQh84pnujiE?= =?us-ascii?Q?gWG1rr5YxZZWJY2H4ispHn5KwngJ3TiLVMLYh7UXnYaGLtkDDzotBKJUOVoA?= =?us-ascii?Q?wRnQhgPgH76lpVU12w5sy9ZkKiyg52iPcyVhQKWdJq3zYrPf+xA2asOdSdIW?= =?us-ascii?Q?dj37vU+JLA4/ilkTB7FeJ+DyPVfhxoSvFdrQVCdt7U4p/1IOWb5r4B9qauYZ?= =?us-ascii?Q?1X4cOLX8pCfKAifnlQMqqNuCVFxcs4HceJzo/USkFHP0toLs2f5zuMt23Mw0?= =?us-ascii?Q?MYgN83wnNRnHjCl6vNTIM+r7ChscKtY1C3HwQjr0sBzrU+bWy5mh8Y5aJ2Zt?= =?us-ascii?Q?2qF1wrjRPz0ptU69sgCnUZjAbZxHAWZkAkwbrZ5Mjc6uLwugow3/gbpYbInT?= =?us-ascii?Q?50HZEFQvX+gK9ksp+eNHKZx7+fJI2hxTT8vI3hIdfLSDLE90tiPSkNge77Tf?= =?us-ascii?Q?WcIGfq3LU6J6g3ytuK1FiKdtkFH2xhiBzfuVvM120RW82SJeC1uJ2P9WVYnO?= =?us-ascii?Q?QViRoxyy3KWnOK90TkVnocYL5frWOX90DiN1pP6C123YyHD/lTj9W48tii2P?= =?us-ascii?Q?/cEsvKQAakimsuFkdr9xxnQ9Wf2MgBzqduKL0kgmN+H96GPID9b85Gjp92ds?= =?us-ascii?Q?lJHpSWje+/YQ94Nq2HHr63WIcxA7KxiNinuc8oj6ehI5XgEKCLi2Qucuqs2/?= =?us-ascii?Q?qKlzUWUZVBQXugkDmSJx/97vrAaSWPzMNpo2+m+Nw4J2sOvUgahzw4IczCbQ?= =?us-ascii?Q?Wubj6Wq9ebbPXHWz2dMoe3K+Bdi4grE8bpRJlKsiOvxLbiyo5/c0kaw6TS9L?= =?us-ascii?Q?+kFxpHUk07rFxHiaIt0Zx2PRaqNEjSowyLqsm4RERONrcAysyhw9rPryS0iz?= =?us-ascii?Q?WE6MnDyvjMZhxv+b/7DzR23uWgTM8nVOFFrI81YykW/Odji+jhhjvq7wTnFI?= =?us-ascii?Q?GilX/sDESqvUGzdbTWPMK6/WvagXGaeQXFjKojYGUnKmHG3HnKWxV2nXvxgv?= =?us-ascii?Q?wpT0HnMeoT8ia0m/nr8B2mqAmGRYphNF18JMF7PFjOBY460izuTQ29m2AeCp?= =?us-ascii?Q?E75xPfo0SJPVR8DK/53VRqtrQBYfnUnpMAv14qqSFxABZHJ+jcrhuDi2abF3?= =?us-ascii?Q?UH8J2+VP97YQAbbKIHSXK5lE/MPO2olVKQ4pxHONJUrH+FwksabOOUxZtl3k?= =?us-ascii?Q?I1X+nEjJw=3D=3D?= X-Microsoft-Antispam-Message-Info: 9gyYpYLzTXu/lsImivrm4V+lDkSxE/UOTntmjXnQxPvUkisYMnD8ANl+Y1ECa3OiQX/tMHZGfdnuXBatZ45E2CXQuNNdVQOvqVWMcAfwlIN+PN6hBAghAGHTByltCpF/D8iKD733CfDDexbdTo193DGFJB51EybeMj6wD9zeSD77GetxGIyqLSe9f1dU4zVcZcm1Fez4J5tFuoxy6VWqAdjMxEUGe33snKf/6ghyoYy3EhfGlHlZFjVDhhy91RfSDtas0/atFALrUtGcfbVBtH/PKmVH9kCzJtzKTkFItZfgprum1sxwKMg9IDWXPBZTA3ZXwYv10Plq9wXOKqGGPb8xgTVV9/54PQnUwFJ8cHo= X-Microsoft-Exchange-Diagnostics: 1; DM6PR07MB5004; 6:HPQdQba+nQLgXGoNT+U5NqJY83MYtSuwfC7CBRP9In4UGov/uDh1E8Crd/YrUBvvyb2Z1zJdVZqQ7/gjTMKyYEwWBQWYoPzlEhe03j0KmJdUFnPHUdgPo9w9oqkgpripSDRNJ24iSmeJq8CRW2xZgsXLV1noRVYDL1DzzwuNlF8hHDM355mR1cKiU57G4aCO/GFhj2TFdGbThPmaCVW7WUOtVZ65K/UN+ZE5386zZUUMttZY4Ij70XGxhVJ+aPW76GC2gnEMEMSt7Kld868jp4qFbSqiN0B/DNBhlA6vqOYWq1TbJ6TPNURW0BFBr36pPETxgCDPmDqeGYIBBR9YmE/6PDE12PWZ43R738eBIlkJjVvz0nkgVWoBykYQZWqS/P/1I5wBVIThFUapuWDd6nOtpIuCcO7yYQHB/RrjoQAUiGWocNYRHj1FTJqlRWJ80poKtlTW9Y2BdAMSpi3x3A==; 5:kB5hcUWEazZ3ETuyTxI95H/36pYjsUBRO0axvVPiZpU3XhLgFKJSdTCv9klBBw1AUYmUrrn6Qlm9SHgApKVitCxxRLWDMtTA3RWt3FAACK1sgOic+19594Lfql2owWSZrftY4/efes3D0yLTVU6qeJ624LuxL/q/e9359MXZw1k=; 7:EsgvEOctTxyXZqER94RbfT8fQ5Zgpyys3YSVkh/PA1liFDO4nilG0M1+RgaVPbWWu5kUiH7vvDUfKbwDK4VrDtRU7r93frtcfdKwNykPzcuLomfize3LZhYFmkRiW4Vw2tWovQlzbRM/6vsKqCAeXVLnvIhmQJLZMTmWejNGP1wkSmNXqSVPhFPOrkJb4XA3B4WeQNSl71sIfccC9C/NTfpF1sCIsnSWWB54amMMnOUGAE6mhvLQLG8D8EnRmb9c SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Sep 2018 06:35:24.2289 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c48d8503-afd5-44f3-ebdd-08d61a0c426b X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR07MB5004 Subject: Re: [dpdk-dev] [PATCH 2/2] app/testpmd: use the generic function to dump packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Sep 2018 06:38:05 -0000 -----Original Message----- > Date: Thu, 13 Sep 2018 18:43:02 +0200 > From: David Marchand > To: Raslan Darawsheh > Cc: "Wu, Jingjing" , Thomas Monjalon > , dev@dpdk.org, Shahaf Shuler , > xuemingl@mellanox.com > Subject: Re: [dpdk-dev] [PATCH 2/2] app/testpmd: use the generic function > to dump packets > > > On Wed, Sep 12, 2018 at 10:06 AM, Raslan Darawsheh wrote: > > use the generic function to dump packets for several forwarding > > engines. > > Rather than patching some engines, how about putting this in rx/tx callbacks ? +1 to have zero performance impact on forward engines. > A bit like something I sent earlier ? > > http://patches.dpdk.org/patch/44465/ > > > -- > David Marchand