From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by dpdk.org (Postfix) with ESMTP id 3E77F5911 for ; Fri, 14 Sep 2018 17:22:34 +0200 (CEST) Received: by mail-pg1-f193.google.com with SMTP id s7-v6so4573743pgc.0 for ; Fri, 14 Sep 2018 08:22:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6NFZm5knY6iWzI806WQeAlWUMvNgmbZlZ/YSH9qfjC0=; b=OrYmdxXntjQ12AG3Wv03Ph8Za0t9UqR9nqaKeFdeFj31PYyjk3RSayV17xgOgVNfqK 1BDIHEZ8khdLlQ0eIMQeIrNp69I7pvT/p0LtjwDpNdCb8ztq2hYZtY4weq/7oIf2+UE9 pAjBN27LA0xQD7V6VBJHd4esJP0sVjE4pJhu5LlTq7n3vQE0kYTpX0WzamMp96ANCHwI 99IIb2M3GW4ANxmAoB6zPKrVtt7T3WrTXiQUn5QqJnRmvl7SttwT/0I+DvLxlsqGGjPl TxoGNFs5sytYVbPGGLl1gNZ32hPiQKufX4g4XWCH7IGyg2WloTzkHlEWVqP7RWpMpxt+ xP1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6NFZm5knY6iWzI806WQeAlWUMvNgmbZlZ/YSH9qfjC0=; b=dECa7Tm6O3QhiofKmgsoiUhOiTXs/+gwyEZjMGBPIbZ8wklzaK9PCgArC6ewhLpkjX uP6o5HIqGc2s/eBxw8snzd8ywtEPnIlmjuXB+oaLoZ5kl4EJr0OW4IV1PMayd0sISI3g y3+BvfAhACsQ1WTfSVil/8/Gkf2x+yiDFNztA26krfIUvFLCsEoc/2o9mvgBAGHeMyea XtZCqSMb3PxLUYpGAfE7M3C4OMVBINgUzYFZu3+M2phljuZsC8HWtkHSlCbKjhbpioIt /6xTrUc4MbokT1fnb3Uzxr4V0KbTNfhbDBRvJ3jAKD2ipbrNqwtwbPd6ogBSmfzF1f30 WxaQ== X-Gm-Message-State: APzg51DtPmGEWrQwxLorPdzbZIT6CaeoG3ni36migkJM/9JNhYCBobo3 rTMAHbKF12Dxlv9s+7U6CqNEmA== X-Google-Smtp-Source: ANB0VdY4WU+Ws62x24eRVCoMOy87iQqGqBtEFQSPD4PZ8Zcn0yXmpN5IdNwhxDaFBg99Lr/VCNppbQ== X-Received: by 2002:a63:d348:: with SMTP id u8-v6mr12381608pgi.420.1536938553246; Fri, 14 Sep 2018 08:22:33 -0700 (PDT) Received: from xeon-e3 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id d12-v6sm9908775pfn.118.2018.09.14.08.22.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 14 Sep 2018 08:22:33 -0700 (PDT) Date: Fri, 14 Sep 2018 08:22:26 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: dev@dpdk.org, Stephen Hemminger Message-ID: <20180914082226.08fc223d@xeon-e3> In-Reply-To: <03884d78-ac63-4d47-2392-bd1e3cab4d58@intel.com> References: <20180830223512.21297-1-stephen@networkplumber.org> <20180830223512.21297-6-stephen@networkplumber.org> <03884d78-ac63-4d47-2392-bd1e3cab4d58@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 5/5] net/netvsc: integrated VF support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Sep 2018 15:22:34 -0000 On Fri, 14 Sep 2018 13:57:58 +0100 Ferruh Yigit wrote: > On 8/30/2018 11:35 PM, Stephen Hemminger wrote: > > From: Stephen Hemminger > > > > Integrate accelerated networking support into netvsc PMD. > > This allows netvsc to manage VF without using failsafe or vdev_netvsc. > > For the exception vswitch path some tests like transmit > > get a 22% increase in packets/sec. > > For the VF path, the code is slightly shorter but has no > > real change in performance. > > > > Pro: > > * using netvsc is more like other DPDK NIC's > > * the exception packet uses less CPU > > * much smaller code size > > * no locking required on VF transmit/receive path > > * no legacy Linux network device to get mangled by userspace > > * much simpler (1K vs 9K) LOC > > * unified extended statistics > > > > Con: > > * using netvsc has more complex startup model > > * no bifurcated driver support > > * no flow support (since host does not have flow API). > > * no tunnel offload support > > * no receive interrupt support > > > > Signed-off-by: Stephen Hemminger > > --- > > devtools/checkpatches.sh | 2 +- > > doc/guides/nics/netvsc.rst | 12 +- > > doc/guides/rel_notes/release_18_11.rst | 14 +- > > drivers/net/netvsc/Makefile | 1 + > > drivers/net/netvsc/hn_ethdev.c | 109 +++++- > > drivers/net/netvsc/hn_nvs.c | 11 +- > > drivers/net/netvsc/hn_nvs.h | 9 + > > drivers/net/netvsc/hn_rndis.c | 31 ++ > > drivers/net/netvsc/hn_rndis.h | 1 + > > drivers/net/netvsc/hn_rxtx.c | 136 ++++--- > > drivers/net/netvsc/hn_var.h | 43 ++- > > drivers/net/netvsc/hn_vf.c | 512 +++++++++++++++++++++++++ > > drivers/net/netvsc/meson.build | 2 +- > > 13 files changed, 799 insertions(+), 84 deletions(-) > > create mode 100644 drivers/net/netvsc/hn_vf.c > > > > diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh > > index ba795ad1dc36..db7afc43d4c0 100755 > > --- a/devtools/checkpatches.sh > > +++ b/devtools/checkpatches.sh > > @@ -1,4 +1,4 @@ > > -#! /bin/sh > > +#! /bin/bash > > # SPDX-License-Identifier: BSD-3-Clause > > # Copyright 2015 6WIND S.A. > > This tool patch shouldn't be part of driver update, would you mind sending a > separate patch for it? Sorry, that slipped in. Will drop it.