From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <gaetan.rivet@6wind.com>
Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com
[209.85.128.66]) by dpdk.org (Postfix) with ESMTP id 5E8675B34
for <dev@dpdk.org>; Fri, 14 Sep 2018 15:07:04 +0200 (CEST)
Received: by mail-wm1-f66.google.com with SMTP id f21-v6so1886269wmc.5
for <dev@dpdk.org>; Fri, 14 Sep 2018 06:07:04 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=6wind-com.20150623.gappssmtp.com; s=20150623;
h=date:from:to:cc:subject:message-id:references:mime-version
:content-disposition:content-transfer-encoding:in-reply-to
:user-agent; bh=KSadAhdZLDYiVXQH3PfanMBD7s+w5iWEKz/N+zoHNW8=;
b=voJ/2mEqcv5LIboTaktmjcH/7lOSB6zyJraU+NvunAMPh8lV4iFjYddPVwUiwMv8mu
svysitOwohigU+o8ahva9FnQZmBhLgpZ5w6u5NLKLIYj7lNVMv1t9lmGSygI49uP2d/V
9/Wgw3A6z+AFBRLnJ+0SCmJWE4yPa701SbykyQoQLCMvP4DiJb5ZwXpYT2wkihLqAtQM
lYPRZhTf6B63vZiSMyFcWVdaGDh2PC3B7sYjqhwuuPsUuwvjgvSAmrzeH1kKZ3g+LXa/
DckUm6GYVKk5/P2Lko5/Dr9G3SEG4iV62/TI6TiiyeN/x0hLfNDyZCXiy2NRi35gf//A
zayA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:date:from:to:cc:subject:message-id:references
:mime-version:content-disposition:content-transfer-encoding
:in-reply-to:user-agent;
bh=KSadAhdZLDYiVXQH3PfanMBD7s+w5iWEKz/N+zoHNW8=;
b=YvJhYswo3CNY5EH77xIKj2jQ3pH5wS1AKRufZe2zYvGCsEn5g+NNJ5Yfz164DPFSsI
xqM3UEKKRGbLgSECCxO31ZQp2MBKtDPoN8538BaGXfNoD7Q1u/V7wRE6GD99wWOnUbPi
+h1lWX8ryAuToI2RcLkdZnSBdFXgqAOWyBQFVCzSp8nFaw76yb3+2kyXWm4Sjp4adYrU
P5CWeWVhS3+qWgRbuxQmE53CtRbe2D+Px/OnVogAXYmOQMcH37FVl/fYk8+8klO0QVsj
bjZo7K1f5yElIyj25yz0MpAnqpJyOP0rnLkenakRwGTMMNNHsmaO0OxzX6xI8x1oGGDT
xoLQ==
X-Gm-Message-State: APzg51BRNtEUUUvs5Uv/hvu1XBSyNvU4Tsc5amQDcC3NGq/po8/C+pTF
jAlUM2ydZK16FsuiMjPjiJJ9mQ==
X-Google-Smtp-Source: ANB0VdaiosrmYNYq2U9k37H5plA/HEYYiAEcYE8kexB0Ft1u1V0iJCc5FJHW9yAMeVWeGQia3y5JWA==
X-Received: by 2002:a1c:3314:: with SMTP id
z20-v6mr2300588wmz.95.1536930423892;
Fri, 14 Sep 2018 06:07:03 -0700 (PDT)
Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com.
[62.23.145.78])
by smtp.gmail.com with ESMTPSA id y5-v6sm8064399wrd.5.2018.09.14.06.07.02
(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
Fri, 14 Sep 2018 06:07:03 -0700 (PDT)
Date: Fri, 14 Sep 2018 15:06:46 +0200
From: =?iso-8859-1?Q?Ga=EBtan?= Rivet <gaetan.rivet@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org,
Stephen Hemminger <sthemmin@microsoft.com>
Message-ID: <20180914130646.cuyl55ycqfz2yvtp@bidouze.vm.6wind.com>
References: <20180830223512.21297-1-stephen@networkplumber.org>
<20180830223512.21297-2-stephen@networkplumber.org>
<f40e48a3-ff31-5c64-2dc9-8d2f8b580d06@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <f40e48a3-ff31-5c64-2dc9-8d2f8b580d06@intel.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Subject: Re: [dpdk-dev] [PATCH 1/5] bus/vmbus: add devargs support
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Sep 2018 13:07:04 -0000
Hi,
On Fri, Sep 14, 2018 at 01:46:59PM +0100, Ferruh Yigit wrote:
> On 8/30/2018 11:35 PM, Stephen Hemminger wrote:
> > From: Stephen Hemminger <sthemmin@microsoft.com>
> >
> > Take device arguments from command line and put
> > them in the device devargs.
> >
> > Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
>
> <...>
>
> > @@ -204,6 +203,27 @@ vmbus_parse(const char *name, void *addr)
> > return ret;
> > }
> >
> > +/*
> > + * scan for matching device args on command line
> > + * example:
> > + * -w 'vmbus(635a7ae3-091e-4410-ad59-667c4f8c04c3,latency=20)'
>
> This is just in comment but,
>
> I guess latest syntax is:
> -w "vmbus:635a7ae3-091e-4410-ad59-667c4f8c04c3,latency=20"
>
> @Gaetan, is latest devarg syntax documented somewhere?
That's the current syntax indeed. Some documentation is found at
lib/librte_eal/common/include/rte_devargs.h:100
Where it is specified that the bus name can be either omitted or
followed by any character, to separate it from the device identifier.
This means that using ':' is fine, as well as '('. As long as the device
PMD afterward ignore the dangling ')' during devargs parsing, this should
be fine.
I don't think this is very clean, but it works.
--
Gaëtan Rivet
6WIND