From: Olivier Matz <olivier.matz@6wind.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: David Marchand <david.marchand@6wind.com>,
dev@dpdk.org, Andrew Rybchenko <arybchenko@solarflare.com>
Subject: Re: [dpdk-dev] [PATCH] mbuf: remove deprecated segment free functions
Date: Mon, 17 Sep 2018 09:07:47 +0200 [thread overview]
Message-ID: <20180917070747.ywy3362j6ers66hz@platinum> (raw)
In-Reply-To: <3144150.fCSgx81mNO@xps>
Hi Thomas,
On Sun, Sep 16, 2018 at 11:39:29AM +0200, Thomas Monjalon wrote:
> 10/09/2018 10:06, Andrew Rybchenko:
> > On 09/10/2018 08:18 AM, David Marchand wrote:
> > > __rte_mbuf_raw_free and __rte_pktmbuf_prefree_seg have been deprecated for
> > > a long time now (early 17.05), are not part of the abi and are easily
> > > replaced with existing api.
> > >
> > > Signed-off-by: David Marchand <david.marchand@6wind.com>
> >
> > Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
>
> I think we need to bump the library version and update the API section
> in the release notes.
I don't think bumping the lib version is required here, the patch removes
two functions that are static inline.
But updating the API section would be nice, yes.
Thanks,
Olivier
next prev parent reply other threads:[~2018-09-17 7:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-10 5:18 David Marchand
2018-09-10 8:06 ` Andrew Rybchenko
2018-09-16 9:39 ` Thomas Monjalon
2018-09-17 7:07 ` Olivier Matz [this message]
2018-09-17 12:45 ` [dpdk-dev] [PATCH v2] " David Marchand
2018-09-19 8:34 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180917070747.ywy3362j6ers66hz@platinum \
--to=olivier.matz@6wind.com \
--cc=arybchenko@solarflare.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).