From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id 2F99B2B84 for ; Mon, 17 Sep 2018 09:07:52 +0200 (CEST) Received: from rsa59-2-82-233-193-189.fbx.proxad.net ([82.233.193.189] helo=droids-corp.org) by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1g1neO-000563-Ol; Mon, 17 Sep 2018 09:08:54 +0200 Received: by droids-corp.org (sSMTP sendmail emulation); Mon, 17 Sep 2018 09:07:47 +0200 Date: Mon, 17 Sep 2018 09:07:47 +0200 From: Olivier Matz To: Thomas Monjalon Cc: David Marchand , dev@dpdk.org, Andrew Rybchenko Message-ID: <20180917070747.ywy3362j6ers66hz@platinum> References: <20180910051819.15528-1-david.marchand@6wind.com> <90cb6257-0571-b28e-acf5-badbb235a499@solarflare.com> <3144150.fCSgx81mNO@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3144150.fCSgx81mNO@xps> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH] mbuf: remove deprecated segment free functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Sep 2018 07:07:52 -0000 Hi Thomas, On Sun, Sep 16, 2018 at 11:39:29AM +0200, Thomas Monjalon wrote: > 10/09/2018 10:06, Andrew Rybchenko: > > On 09/10/2018 08:18 AM, David Marchand wrote: > > > __rte_mbuf_raw_free and __rte_pktmbuf_prefree_seg have been deprecated for > > > a long time now (early 17.05), are not part of the abi and are easily > > > replaced with existing api. > > > > > > Signed-off-by: David Marchand > > > > Acked-by: Andrew Rybchenko > > I think we need to bump the library version and update the API section > in the release notes. I don't think bumping the lib version is required here, the patch removes two functions that are static inline. But updating the API section would be nice, yes. Thanks, Olivier