* [dpdk-dev] [PATCH] mbuf: remove deprecated segment free functions
@ 2018-09-10 5:18 David Marchand
2018-09-10 8:06 ` Andrew Rybchenko
2018-09-17 12:45 ` [dpdk-dev] [PATCH v2] " David Marchand
0 siblings, 2 replies; 6+ messages in thread
From: David Marchand @ 2018-09-10 5:18 UTC (permalink / raw)
To: dev; +Cc: olivier.matz
__rte_mbuf_raw_free and __rte_pktmbuf_prefree_seg have been deprecated for
a long time now (early 17.05), are not part of the abi and are easily
replaced with existing api.
Signed-off-by: David Marchand <david.marchand@6wind.com>
---
lib/librte_mbuf/rte_mbuf.h | 16 ----------------
1 file changed, 16 deletions(-)
diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
index 9ce5d76d7..a50b05c64 100644
--- a/lib/librte_mbuf/rte_mbuf.h
+++ b/lib/librte_mbuf/rte_mbuf.h
@@ -1038,14 +1038,6 @@ rte_mbuf_raw_free(struct rte_mbuf *m)
rte_mempool_put(m->pool, m);
}
-/* compat with older versions */
-__rte_deprecated
-static inline void
-__rte_mbuf_raw_free(struct rte_mbuf *m)
-{
- rte_mbuf_raw_free(m);
-}
-
/**
* The packet mbuf constructor.
*
@@ -1658,14 +1650,6 @@ rte_pktmbuf_prefree_seg(struct rte_mbuf *m)
return NULL;
}
-/* deprecated, replaced by rte_pktmbuf_prefree_seg() */
-__rte_deprecated
-static inline struct rte_mbuf *
-__rte_pktmbuf_prefree_seg(struct rte_mbuf *m)
-{
- return rte_pktmbuf_prefree_seg(m);
-}
-
/**
* Free a segment of a packet mbuf into its original mempool.
*
--
2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] mbuf: remove deprecated segment free functions
2018-09-10 5:18 [dpdk-dev] [PATCH] mbuf: remove deprecated segment free functions David Marchand
@ 2018-09-10 8:06 ` Andrew Rybchenko
2018-09-16 9:39 ` Thomas Monjalon
2018-09-17 12:45 ` [dpdk-dev] [PATCH v2] " David Marchand
1 sibling, 1 reply; 6+ messages in thread
From: Andrew Rybchenko @ 2018-09-10 8:06 UTC (permalink / raw)
To: David Marchand, dev; +Cc: olivier.matz
On 09/10/2018 08:18 AM, David Marchand wrote:
> __rte_mbuf_raw_free and __rte_pktmbuf_prefree_seg have been deprecated for
> a long time now (early 17.05), are not part of the abi and are easily
> replaced with existing api.
>
> Signed-off-by: David Marchand <david.marchand@6wind.com>
Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] mbuf: remove deprecated segment free functions
2018-09-10 8:06 ` Andrew Rybchenko
@ 2018-09-16 9:39 ` Thomas Monjalon
2018-09-17 7:07 ` Olivier Matz
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Monjalon @ 2018-09-16 9:39 UTC (permalink / raw)
To: David Marchand; +Cc: dev, Andrew Rybchenko, olivier.matz
10/09/2018 10:06, Andrew Rybchenko:
> On 09/10/2018 08:18 AM, David Marchand wrote:
> > __rte_mbuf_raw_free and __rte_pktmbuf_prefree_seg have been deprecated for
> > a long time now (early 17.05), are not part of the abi and are easily
> > replaced with existing api.
> >
> > Signed-off-by: David Marchand <david.marchand@6wind.com>
>
> Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
I think we need to bump the library version and update the API section
in the release notes.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] mbuf: remove deprecated segment free functions
2018-09-16 9:39 ` Thomas Monjalon
@ 2018-09-17 7:07 ` Olivier Matz
0 siblings, 0 replies; 6+ messages in thread
From: Olivier Matz @ 2018-09-17 7:07 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: David Marchand, dev, Andrew Rybchenko
Hi Thomas,
On Sun, Sep 16, 2018 at 11:39:29AM +0200, Thomas Monjalon wrote:
> 10/09/2018 10:06, Andrew Rybchenko:
> > On 09/10/2018 08:18 AM, David Marchand wrote:
> > > __rte_mbuf_raw_free and __rte_pktmbuf_prefree_seg have been deprecated for
> > > a long time now (early 17.05), are not part of the abi and are easily
> > > replaced with existing api.
> > >
> > > Signed-off-by: David Marchand <david.marchand@6wind.com>
> >
> > Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
>
> I think we need to bump the library version and update the API section
> in the release notes.
I don't think bumping the lib version is required here, the patch removes
two functions that are static inline.
But updating the API section would be nice, yes.
Thanks,
Olivier
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH v2] mbuf: remove deprecated segment free functions
2018-09-10 5:18 [dpdk-dev] [PATCH] mbuf: remove deprecated segment free functions David Marchand
2018-09-10 8:06 ` Andrew Rybchenko
@ 2018-09-17 12:45 ` David Marchand
2018-09-19 8:34 ` Thomas Monjalon
1 sibling, 1 reply; 6+ messages in thread
From: David Marchand @ 2018-09-17 12:45 UTC (permalink / raw)
To: dev; +Cc: olivier.matz, arybchenko, thomas
__rte_mbuf_raw_free and __rte_pktmbuf_prefree_seg have been deprecated for
a long time now (early 17.05), are not part of the abi and are easily
replaced with existing api.
Signed-off-by: David Marchand <david.marchand@6wind.com>
Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
doc/guides/rel_notes/release_18_11.rst | 5 +++++
lib/librte_mbuf/rte_mbuf.h | 16 ----------------
2 files changed, 5 insertions(+), 16 deletions(-)
diff --git a/doc/guides/rel_notes/release_18_11.rst b/doc/guides/rel_notes/release_18_11.rst
index 3ae6b3f58..d98573072 100644
--- a/doc/guides/rel_notes/release_18_11.rst
+++ b/doc/guides/rel_notes/release_18_11.rst
@@ -68,6 +68,11 @@ API Changes
Also, make sure to start the actual text at the margin.
=========================================================
+* mbuf: The ``__rte_mbuf_raw_free()`` and ``__rte_pktmbuf_prefree_seg()``
+ functions were deprecated since 17.05 and are removed:
+
+ Those functions were kept for compatibility and are replaced by
+ ``rte_mbuf_raw_free()`` and ``rte_pktmbuf_prefree_seg()``.
ABI Changes
-----------
diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
index 9ce5d76d7..a50b05c64 100644
--- a/lib/librte_mbuf/rte_mbuf.h
+++ b/lib/librte_mbuf/rte_mbuf.h
@@ -1038,14 +1038,6 @@ rte_mbuf_raw_free(struct rte_mbuf *m)
rte_mempool_put(m->pool, m);
}
-/* compat with older versions */
-__rte_deprecated
-static inline void
-__rte_mbuf_raw_free(struct rte_mbuf *m)
-{
- rte_mbuf_raw_free(m);
-}
-
/**
* The packet mbuf constructor.
*
@@ -1658,14 +1650,6 @@ rte_pktmbuf_prefree_seg(struct rte_mbuf *m)
return NULL;
}
-/* deprecated, replaced by rte_pktmbuf_prefree_seg() */
-__rte_deprecated
-static inline struct rte_mbuf *
-__rte_pktmbuf_prefree_seg(struct rte_mbuf *m)
-{
- return rte_pktmbuf_prefree_seg(m);
-}
-
/**
* Free a segment of a packet mbuf into its original mempool.
*
--
2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH v2] mbuf: remove deprecated segment free functions
2018-09-17 12:45 ` [dpdk-dev] [PATCH v2] " David Marchand
@ 2018-09-19 8:34 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2018-09-19 8:34 UTC (permalink / raw)
To: David Marchand; +Cc: dev, olivier.matz, arybchenko
17/09/2018 14:45, David Marchand:
> __rte_mbuf_raw_free and __rte_pktmbuf_prefree_seg have been deprecated for
> a long time now (early 17.05), are not part of the abi and are easily
> replaced with existing api.
>
> Signed-off-by: David Marchand <david.marchand@6wind.com>
> Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
Applied, thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-09-19 8:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-10 5:18 [dpdk-dev] [PATCH] mbuf: remove deprecated segment free functions David Marchand
2018-09-10 8:06 ` Andrew Rybchenko
2018-09-16 9:39 ` Thomas Monjalon
2018-09-17 7:07 ` Olivier Matz
2018-09-17 12:45 ` [dpdk-dev] [PATCH v2] " David Marchand
2018-09-19 8:34 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).