From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 11D032B84
 for <dev@dpdk.org>; Mon, 17 Sep 2018 10:17:25 +0200 (CEST)
X-Amp-Result: UNKNOWN
X-Amp-Original-Verdict: FILE UNKNOWN
X-Amp-File-Uploaded: False
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 17 Sep 2018 01:17:25 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.53,384,1531810800"; d="scan'208";a="90700582"
Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.107])
 by fmsmga001.fm.intel.com with SMTP; 17 Sep 2018 01:17:21 -0700
Received: by  (sSMTP sendmail emulation); Mon, 17 Sep 2018 09:17:20 +0100
Date: Mon, 17 Sep 2018 09:17:19 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Luca Boccassi <bluca@debian.org>, dev@dpdk.org
Message-ID: <20180917081719.GA2372@bricha3-MOBL.ger.corp.intel.com>
References: <20180830170701.21443-1-bruce.richardson@intel.com>
 <1535650263.11823.18.camel@debian.org> <3518182.H5eQSvgRL9@xps>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3518182.H5eQSvgRL9@xps>
Organization: Intel Research and Development Ireland Ltd.
User-Agent: Mutt/1.10.1 (2018-07-13)
Subject: Re: [dpdk-dev] [PATCH] compat: fix symbol version support with meson
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Sep 2018 08:17:26 -0000

On Sun, Sep 16, 2018 at 11:14:10AM +0200, Thomas Monjalon wrote:
> 30/08/2018 19:31, Luca Boccassi:
> > On Thu, 2018-08-30 at 18:07 +0100, Bruce Richardson wrote:
> > > For meson builds, the define to enable the symbol version
> > > macros in rte_compat.h was missing. This led to symbols being
> > > omitted from shared objects. For example, checking rte_distributor.so
> > > with objdump and comparing make and meson built versions:
> > > 
> > > $ objdump -T make-build/lib/librte_distributor.so | grep _flush
> > >  0000000000001b60 g    DF .text	00000000000000a7
> > > (DPDK_2.0)   rte_distributor_flush
> > >  0000000000003f10 g    DF .text	0000000000000434  DPDK_17.05  
> > > rte_distributor_flush
> > > $ objdump -T meson-build/lib/librte_distributor.so | grep _flush
> > >  0000000000001d50 g    DF .text	00000000000000fb  DPDK_2.0    
> > > rte_distributor_flush
> > > 
> > > Adding in the missing define fixes this.
> > > 
> > > Fixes: 5b9656b157d3 ("lib: build with meson")
> > > 
> > > Reported-by: Luca Boccassi <bluca@debian.org>
> > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > 
> > Tested-by: Luca Boccassi <bluca@debian.org>
> 
> Cc stable?
> 
Yes, will add on a V2.