From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id D440B2BA8; Mon, 17 Sep 2018 10:18:34 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Sep 2018 01:18:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,384,1531810800"; d="scan'208";a="91150407" Received: from silpixa00399126.ir.intel.com (HELO silpixa00399126.ger.corp.intel.com) ([10.237.223.223]) by orsmga001.jf.intel.com with ESMTP; 17 Sep 2018 01:18:32 -0700 From: Bruce Richardson To: thomas@monjalon.net Cc: dev@dpdk.org, bluca@debian.org, Bruce Richardson , stable@dpdk.org Date: Mon, 17 Sep 2018 09:18:00 +0100 Message-Id: <20180917081800.8912-1-bruce.richardson@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180830170701.21443-1-bruce.richardson@intel.com> References: <20180830170701.21443-1-bruce.richardson@intel.com> Subject: [dpdk-dev] [PATCH v2] compat: fix symbol version support with meson X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Sep 2018 08:18:35 -0000 For meson builds, the define to enable the symbol version macros in rte_compat.h was missing. This led to symbols being omitted from shared objects. For example, checking rte_distributor.so with objdump and comparing make and meson built versions: $ objdump -T make-build/lib/librte_distributor.so | grep _flush 0000000000001b60 g DF .text 00000000000000a7 (DPDK_2.0) rte_distributor_flush 0000000000003f10 g DF .text 0000000000000434 DPDK_17.05 rte_distributor_flush $ objdump -T meson-build/lib/librte_distributor.so | grep _flush 0000000000001d50 g DF .text 00000000000000fb DPDK_2.0 rte_distributor_flush Adding in the missing define fixes this. Fixes: 5b9656b157d3 ("lib: build with meson") CC: stable@dpdk.org Reported-by: Luca Boccassi Signed-off-by: Bruce Richardson Tested-by: Luca Boccassi --- config/rte_config.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/config/rte_config.h b/config/rte_config.h index a8e479774..46775a841 100644 --- a/config/rte_config.h +++ b/config/rte_config.h @@ -20,6 +20,9 @@ /****** library defines ********/ +/* compat defines */ +#define RTE_BUILD_SHARED_LIB + /* EAL defines */ #define RTE_MAX_MEMSEG_LISTS 128 #define RTE_MAX_MEMSEG_PER_LIST 8192 -- 2.17.1