From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id EB4502BE3 for ; Mon, 17 Sep 2018 11:11:18 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 50B18308A953; Mon, 17 Sep 2018 09:11:18 +0000 (UTC) Received: from localhost (dhcp-192-209.str.redhat.com [10.33.192.209]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8ED2F5DD87; Mon, 17 Sep 2018 09:11:12 +0000 (UTC) Date: Mon, 17 Sep 2018 11:11:11 +0200 From: Jens Freimann To: Tiwei Bie Cc: dev@dpdk.org, maxime.coquelin@redhat.com Message-ID: <20180917091111.ft4qdr5sad3zh3ip@jenstp.localdomain> References: <20180906181947.20646-1-jfreimann@redhat.com> <20180906181947.20646-10-jfreimann@redhat.com> <20180914053236.GA19348@debian> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20180914053236.GA19348@debian> User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Mon, 17 Sep 2018 09:11:18 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v5 09/11] net/virtio: disable ctrl virtqueue for packed rings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Sep 2018 09:11:19 -0000 On Fri, Sep 14, 2018 at 01:32:36PM +0800, Tiwei Bie wrote: >On Thu, Sep 06, 2018 at 07:19:45PM +0100, Jens Freimann wrote: >> Signed-off-by: Jens Freiman >> --- >> drivers/net/virtio/virtio_ethdev.c | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c >> index a2bb726ba..b02c65598 100644 >> --- a/drivers/net/virtio/virtio_ethdev.c >> +++ b/drivers/net/virtio/virtio_ethdev.c >> @@ -1161,6 +1161,15 @@ virtio_negotiate_features(struct virtio_hw *hw, uint64_t req_features) >> req_features &= ~(1ULL << VIRTIO_NET_F_MTU); >> } >> >> +#ifdef RTE_LIBRTE_VIRTIO_PQ >> + if (req_features & (1ULL << VIRTIO_F_RING_PACKED)) { >> + req_features &= ~(1ull << VIRTIO_NET_F_CTRL_MAC_ADDR); >> + req_features &= ~(1ull << VIRTIO_NET_F_CTRL_VQ); >> + req_features &= ~(1ull << VIRTIO_NET_F_CTRL_RX); >> + req_features &= ~(1ull << VIRTIO_NET_F_CTRL_VLAN); >> + } >> +#endif > >I think we need to support ctrl vq. I will add it to the next version. > >And in performance test, we need to use more cores on vhost >side to make sure that we can get the max performance of the >virtio PMD. Otherwise, it's likely that the performance gain >we get is the gain in vhost. ok. thanks! regards, Jens