DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] test-meson-builds: add 32-bit compilation test
Date: Mon, 17 Sep 2018 13:54:02 +0100	[thread overview]
Message-ID: <20180917125402.GA3464@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <4200777.W2uOughg41@xps>

On Mon, Sep 17, 2018 at 02:03:50PM +0200, Thomas Monjalon wrote:
> 29/08/2018 18:02, Bruce Richardson:
> > Add in a cross-file to enable 32-bit compile tests as part
> > of the test-meson-builds script.
> > 
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> > NOTE: For ease of use, it's recommended that meson 0.47 be used for
> > this testing. With earlier versions, it may be necessary to ensure that
> > the same development packages are installed for both 64-bit and 32-bit.
> > ---
> >  config/x86/i686_sse4_linuxapp_gcc | 18 ++++++++++++++++++
> >  devtools/test-meson-builds.sh     |  4 ++++
> >  2 files changed, 22 insertions(+)
> 
> I'm not sure about adding this test as mandatory, because 32-bit version
> of libraries can be hard to get, especially libbsd and libnuma.
> I hope this test will be run by all developers, so we should not discourage
> them by adding too many requirements.
> Opinion? Idea?

Libbsd is not required, but yes, libnuma is, so you do need a 32-bit
libnuma (devel) installed to run this test. I would expect that to be
available on most distros though. I'm open to suggestions as to how to make
this optional, but I do think that sanity checking 32-bit is good practice
to avoid errors, e.g. those wonderful printf format strings for uint64_t.

/Bruce

  reply	other threads:[~2018-09-17 12:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-29 16:02 Bruce Richardson
2018-09-17 12:03 ` Thomas Monjalon
2018-09-17 12:54   ` Bruce Richardson [this message]
2018-09-17 13:38     ` Thomas Monjalon
2018-09-17 15:17       ` Bruce Richardson
2018-09-17 16:44         ` Thomas Monjalon
2018-09-17 19:34           ` Bruce Richardson
2018-09-17 19:58             ` Thomas Monjalon
2018-09-18 10:15               ` Bruce Richardson
2018-09-18 10:23                 ` Thomas Monjalon
2018-10-11 11:54                   ` Thomas Monjalon
2018-10-11 13:46                     ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180917125402.GA3464@bricha3-MOBL.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).