Re: [dpdk-dev] [PATCH v3 4/5] eventdev: add auto test for eth Tx adapter

[Jerin Jacob <jerin.jacob@caviumnetworks.com>]

-----Original Message-----
> Date: Fri, 31 Aug 2018 11:11:08 +0530
> From: Nikhil Rao <nikhil.rao@intel.com>
> To: jerin.jacob@caviumnetworks.com, olivier.matz@6wind.com
> CC: dev@dpdk.org, Nikhil Rao <nikhil.rao@intel.com>
> Subject: [PATCH v3 4/5] eventdev: add auto test for eth Tx adapter
> X-Mailer: git-send-email 1.8.3.1
> 
> This patch adds tests for the eth Tx adapter APIs. It also
> tests the data path for the rte_service function based
> implementation of the APIs.
> 
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> ---
>  test/test/test_event_eth_tx_adapter.c | 694 ++++++++++++++++++++++++++++++++++
>  MAINTAINERS                           |   1 +
>  test/test/Makefile                    |   1 +
>  test/test/meson.build                 |   2 +
>  4 files changed, 698 insertions(+)
>  create mode 100644 test/test/test_event_eth_tx_adapter.c
> 
> diff --git a/test/test/test_event_eth_tx_adapter.c b/test/test/test_event_eth_tx_adapter.c
> new file mode 100644
> index 0000000..e97f59f
> --- /dev/null
> +++ b/test/test/test_event_eth_tx_adapter.c
> @@ -0,0 +1,694 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) 2018 Intel Corporation
> + */
> +#include <string.h>

Space here

> +#include <rte_common.h>
> +#include <rte_mempool.h>
> +#include <rte_mbuf.h>
> +#include <rte_ethdev.h>
> +#include <rte_eventdev.h>
> +#include <rte_bus_vdev.h>
> +#include <rte_eth_ring.h>
> +#include <rte_service.h>
> +#include <rte_event_eth_tx_adapter.h>

Sort it in alphabetical order.

> +
> +#include "test.h"
> +
> +
> +static inline int
> +port_init(uint8_t port, struct rte_mempool *mp)
> +{
> +       struct rte_eth_conf conf = { 0 };

Some old compiler had issue with above declaration,
Can you use memset instead here another instance of this file.

> +       return port_init_common(port, &conf, mp);
> +}
> +
> +#define RING_NAME_LEN  20
> +#define DEV_NAME_LEN   20
> +

With above changes:
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>