From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <jackmin@mellanox.com>
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
(mail-eopbgr80045.outbound.protection.outlook.com [40.107.8.45])
by dpdk.org (Postfix) with ESMTP id 842981559
for <dev@dpdk.org>; Tue, 18 Sep 2018 09:56:32 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;
s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=PKHbhKksBbH+REFsyFywP8j+65feTmcATmlrqRiYic8=;
b=OFWPLXQHbzNaMG8UEcKduAv3y/RyZHcDX7Lw3rwGHVPBJV36x14U76vBDOf6Zb1e09/MgO/d98CsCVomv+A2m8ZV/Y35VCDWYrWHDsk986c1cfhuPzm0n3UwXRtRhykr4y+nfO8s6kFmaFm7/4A2DxOWOBcwaIq+bxLXomHXo7A=
Authentication-Results: spf=none (sender IP is )
smtp.mailfrom=jackmin@mellanox.com;
Received: from MTBC-JACKMIN.mtl.com (61.173.0.173) by
DB6PR0501MB2023.eurprd05.prod.outlook.com (2603:10a6:4:6::17) with Microsoft
SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.20.1143.15; Tue, 18 Sep 2018 07:56:28 +0000
Date: Tue, 18 Sep 2018 15:56:06 +0800
From: Xiaoyu Min <jackmin@mellanox.com>
To: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Cc: dev@dpdk.org, shaguna@chelsio.com, nirranjan@chelsio.com,
indranil@chelsio.com
Message-ID: <20180918075606.edfevp3iuibozmsu@MTBC-JACKMIN.mtl.com>
References: <cover.1534166371.git.rahul.lakkireddy@chelsio.com>
<a557e0cd6b46e742b4bd1feb8067c87e23939ff3.1534166371.git.rahul.lakkireddy@chelsio.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a557e0cd6b46e742b4bd1feb8067c87e23939ff3.1534166371.git.rahul.lakkireddy@chelsio.com>
User-Agent: NeoMutt/20180716
X-Originating-IP: [61.173.0.173]
X-ClientProxiedBy: HK0PR01CA0037.apcprd01.prod.exchangelabs.com
(2603:1096:203:3e::25) To DB6PR0501MB2023.eurprd05.prod.outlook.com
(2603:10a6:4:6::17)
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c98fcc84-b07a-47f8-b6a4-08d61d3c3ef8
X-MS-Office365-Filtering-HT: Tenant
X-Microsoft-Antispam: BCL:0; PCL:0;
RULEID:(7020095)(4652040)(8989299)(4534165)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020);
SRVR:DB6PR0501MB2023;
X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2023;
3:yfD+nhryLQilewCXTkE7KU6foiSyGOjj4ko78SVrMqZ82X4Uvv87UlASlPQz9bxlb3KYAiO15n9KPhwD2vjEIP6OM9+66HD+GZoYJOaf/xlipNEKXv4HpupovjZaaOBm4AnI4Ur1aGd9txaF0jW1UZaEpDZ6LidJI8Lxf2dI+BQ3R7R0MrcU7Fknu4q2DdPzLalBsaw3LMAQpMZYDhv7xBaYJXLpiOuoxn5NKDUhceiBjN5A9yM7ij/ryaTILOyD;
25:IgPh0331c7jl1FVjmkiW6dGvRFiEJcOPvpRwtiM6Fu1DYTFuPcmr2c8gIzIkwS5nFJqMfT0JOBxwkttLY7D+daCyDTClKgkVegGoX6MyNRlXSxHkx2LLoDsnJLk2xj05pA/0g6JUyA1SiNGnLajL5JwHR9KHDbDjByKOeMBR4G14L98n6Evt0uxzqy6SL89vcgOTmbDNsl8DBUOopdJS2vsygiUSpt+U1tW+XnZC667+c2MFZOMlEFqAq535FDVI5EvqqAnCqffAI8Km7OrhsyUZyu8r6SuUwE4kcWE/1PMewjTYjX00tvjyW34AoiDwyrtvQtHfX6eEhlr/+o6JeA==;
31:0bABppNtMkLhg0/IgUYzBwfUzpnwcxrWTi5PNTZ92wIM3w7gNXYl3ZlH7+oiEWAjMczGNvdjJqg0uC6n+6tDrpm+V0TxCBoAnvDh5G0cAW6FcBBzbtOQbKtNqbn752nZ2MS2uFXEgWB56zrbx++gX76w0AH0NGSQNwmPv7ayuyXkyuyh6Bhn/ib0ZYNGnQOsMdF9ctYc3aee8ruMDyU5WQ/GxMNOYeyZ1uEhngGHTiQ=
X-MS-TrafficTypeDiagnostic: DB6PR0501MB2023:
X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2023;
20:ExZlIzY7ijtwZsc0Hh1DcbxhNOjI/wAvLcRi8LUD6JVxPctk7qWaXGdI8GvrmvX1B2bozxauRx4TqDuxg0cfP3gzSpS1z9qLfgPcIHMY0ej+Pm0UmpXwCHuJaKvIdJXGgjft/J4pZNYkaflj2zlmU2LMV70gK67jCkqRYEmE6NnQ+bI/gwGJ18HD3xHyYTrQ1YvVvtiOaFx9bscuv4HXcV+7nyMQmgiZyuSjubIRjcpwVH8mebIF7mxEEmVhCz+NNFRZyR3IT+GRTPMNSNyB8xv1VLozxrl9NrQMPTsGwe6mozIyWTVQga0gotFw5Ez3C9CgH80+c+DQrzykl4Ufiugq9zCGclGFcgVM16EcCU/4Jxy4X3DFFsil9XemHlfJXZo0rGlgKj4ikJMjzv/fbUMW2Maz6Kjez8iPHmtaG4SfTgHlrUZET+mFqdxYIqA7+KDhkZm4RZ2/c0p3+UxRNVLghCpQfc3IWJW9QCneQ4ZBLqTXpUuwEgiqm+LJxt7D;
4:u3uysLyb3Ret6NhPQJI86OeN9UrmK/dMeEWTs8ZAtiE3YHqkXWYwnkJ8PuqeOE3vrtuRsFbsOUmj1xKR7nhvWsMfRu3tvICAi3F8XCY82zf7dA1ZWT0EgHEI6Q9Tjukkx2Mi25pCthiiWScAOgiRWvFKckIIc1BfhX6QE82JcANjq25O1sKOyt3uspzKbWTuIWqunFxrk14rtcmzilhEXQrIq9hPi7+4cClWaEaHAAKt3C6rpmhWDIdrl4Zgrx77Z52N7OSY7M0AVCxacxfbhfkDZTBcZFiinAg0MhY08sMkow6XdbAkXj4q/ZhjcJu0
X-Microsoft-Antispam-PRVS: <DB6PR0501MB202394658530CCDB1B721FC9CC1D0@DB6PR0501MB2023.eurprd05.prod.outlook.com>
X-Exchange-Antispam-Report-Test: UriScan:(163750095850);
X-MS-Exchange-SenderADCheck: 1
X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0;
RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231355)(944501410)(52105095)(93006095)(93001095)(3002001)(10201501046)(6055026)(149027)(150027)(6041310)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123560045)(201708071742011)(7699050);
SRVR:DB6PR0501MB2023; BCL:0; PCL:0; RULEID:; SRVR:DB6PR0501MB2023;
X-Forefront-PRVS: 0799B1B2D7
X-Forefront-Antispam-Report: SFV:NSPM;
SFS:(10009020)(376002)(366004)(136003)(396003)(346002)(39860400002)(189003)(199004)(66066001)(7696005)(53416004)(76176011)(6246003)(6916009)(229853002)(81166006)(105586002)(55016002)(6666003)(68736007)(9686003)(5660300001)(4326008)(53936002)(47776003)(52116002)(106356001)(81156014)(305945005)(7736002)(58126008)(8676002)(25786009)(316002)(16586007)(478600001)(26005)(186003)(97736004)(2906002)(8936002)(50466002)(23726003)(16526019)(11346002)(6116002)(476003)(6506007)(1076002)(86362001)(3846002)(956004)(386003)(446003)(486006);
DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0501MB2023; H:MTBC-JACKMIN.mtl.com; FPR:;
SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
Received-SPF: None (protection.outlook.com: mellanox.com does not designate
permitted sender hosts)
X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB6PR0501MB2023;
23:RMocFBFdlxdtcdm3bcuIU7pjEx8tCXIg35GChHY?=
=?us-ascii?Q?K7byK5lNW/WuRKjLM9cL/vA0w9g/zSBjEi7q5fGOV4CE4syiAGs19V4kTZIE?=
=?us-ascii?Q?V7kA/tCH15VqZ8MyFHOMjXGsFXUwrSS5ZNxVZlm9jTUsKzUPZrvRh3HMe+LF?=
=?us-ascii?Q?4v0tnY3fPnxBQIdYBHRGzrK/0oJXnXerALnQ70LfnW7kv0GdxDXOlo/eC4UZ?=
=?us-ascii?Q?J7ExaKrD4ot2t9TCMWqILshVpRnu+UOad81Ytz9oz+CXP8VlsTh5v8PwD9PX?=
=?us-ascii?Q?dFiMUMQGrFzVUxeAa3Baxh1QxHPsdbGvBmcTz91rNpi9lG+qwBzHXKi7f/BX?=
=?us-ascii?Q?cn0vsgtDaJlZDXn+wa0WkweAC3TWoWHyAcemoU+2PbRTY/0ctMTtA2ujbOFz?=
=?us-ascii?Q?OVaBFEO7x75H4NJbUyJKl7PpPSJbwCfqic8TprOylE8bot75TTyJwieV00xb?=
=?us-ascii?Q?q9pDwvVX6uiWrcAHJRruso4tHj8Myj5mkEJj/VxBQetCmel5ETeO715PMvSY?=
=?us-ascii?Q?iYHumf40bYL7BXYMGNDaiiMuVH09vKyiC4lix1ai/ZPRpZ1fJwZyXDV1aJ8C?=
=?us-ascii?Q?usG4phqugYOD/C+tpaV097DLC0SZ3gHtrCiJCM7XnsJsggKBYV6py5xndWYm?=
=?us-ascii?Q?Y6aRbDskoyUz54f6Wpin1x38HJhjeIk9YRVNAfcq0qQq82NBBTuYMvfRAbE1?=
=?us-ascii?Q?a2rHAgaMwlL5x0vIHn2GZNcM+iu6Uojem8P+t8bE0a53nQEHGhmk20djZ7wy?=
=?us-ascii?Q?oDPQ+5mrvspWIgm8KJR3Gqa4GIxZ82aGMKlCvQITmrhi1dJ6k0pj31b4RUh6?=
=?us-ascii?Q?nvccyiYSiGbB7JEC57G0GnKsmmIVCM8pgr3+SSh4CJOZ6ROQQrm4ECC4QTHG?=
=?us-ascii?Q?+UWgFMIUQ3wPGV97ZQrJt+E1KjT22gWpcWSdXb1B6EDLI5m9DurOxLa2qYVy?=
=?us-ascii?Q?7jODsl723gGC1DPpu4m8VjjztII/wOtH0+ReZzqogk0+XFsGEyIGq03oFdu3?=
=?us-ascii?Q?w7CFF3h0JPVkywckSKy8JLwgRSBfF/yE8FYteztYSKCZStV0i2p+C4YLe7FA?=
=?us-ascii?Q?9/+etmNTpb3oy4d7msWAEWGrJEXxs82TdUky6tmZiwq+63k5MLXA/Gps1fM7?=
=?us-ascii?Q?8Uv9nrJbej25WoWDe0GX07g0NXVBfDItZapW1KRVkfouUYhghhVXWz8qKIrs?=
=?us-ascii?Q?DAuCLMhMOoGh49XT7g2UImD7YyV/+Z9zAgsMP?=
X-Microsoft-Antispam-Message-Info: UBbUEfXPvtB3BELYNshVF77Mg6c/09YBkMVGEOClAJHhE/n1QuNPiyBLHypsmYh7K068TzHuHjDD3wYK50uxCLTdhoWzq+RwuomXhMlwmdbXumYHDyznRYwAKrmdqKRVNFUTGco122Ly+OsdHMHqIg90yUUJ8viCf6fhZmrOboCKUl8x1TjLYLY6gOJJ+1SQnEvSE4iEkkxMXYgCp3+sJfgs8mOgmz6WnlnBRaCECPu2tskoAjp7oUavu9+VSCUx1yQWK91pQau1Zsh/La52TrT65j2RrJsrs36wJrbZLDR1joE8/z3LGhG59iThIiWVV/KEIMYF+/j0hs+w0DBnbaojw2qqOQFYFiv6TeTika0=
X-Microsoft-Exchange-Diagnostics: 1; DB6PR0501MB2023;
6:9ACRFV+DVWPlZtX+AY9ku8KPGSFRY+PoNH8/K/7Up8Rxx5jMO+IhnBjv2mM6+42nl4ZF60uD6jx4A1TWXBg5sFEfnGRdFNH738//oUujv4zLrMGieezs1beYIZ5P9yBnTWits/zznHmy9+uCBD2TDq+AgS4rXtqDMK0pQ2yS2VzPDDgt34pDftlTv7RI4YiZSArC4pX0UoiRfG10OLZaydxZiPekKPyyhypk/KWa88vRzBG10v6MWGk7u5w8JsVptFKZ4n1jZHlgiUpefPubIdaNG1ch4x5ktlcEPdJXkB80Chltt9HEgQNrykkImOgdcjtDaWuVU/6tCrcZcFpgjvVe7+GW33Ci4jnbS5wcO0wc1Gsd3z4RlDZEZb/GIDOsegHrORaHfVxMY4560CNhbn6SJi6/R/rc23owwZtNnAdRbCFFxyJD/ExbNCVpa0/70WPmBO8vkqov6AxCcpNQ8Q==;
5:hxYMGwmtfuel6aZo1CorHNzG/qIh43hw3P1sOAefXCmfwuX93+bwB0SC+SwR311Vym8OXuO8fSsfO0J4p77BIWpxsYHrOSBbqNp0VXB7sWsVd3ReZ1Q01Rdqb3oTqj4AIODI1d1IseGAlzD9u1uvfvcnZ1XavwP/GpGLKSAFFs8=;
7:DSkKUDHoICFfm131TPT3JGVdhIIB0ChifrDK7AUfhj1SOVTR2X0mkrpmNUWT8cOBZOS1muIf31c4fDDFpwbfZXwBOBML8vwbJWg2199xKFMKgK9xr15/sdUTEsrYgFRT7BLniBxJ4osjHcERC545tTYauOqGFN/5OSNJ0fQu1JTGfpeIpPEeci3QToz0RTX7+jp5LodLtY+ej6+1aeBtxXgbmpI0TiL7hvVt4XdFZIt2OA51fAWvUb9Yat1BdWL4
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-OriginatorOrg: Mellanox.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Sep 2018 07:56:28.9201 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: c98fcc84-b07a-47f8-b6a4-08d61d3c3ef8
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0501MB2023
Subject: Re: [dpdk-dev] [RFC v2 1/3] ethdev: add flow api actions to modify
IP addresses
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Sep 2018 07:56:32 -0000
>
> static int
> diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h
> index f8ba71cdb..48c3c606e 100644
> --- a/lib/librte_ethdev/rte_flow.h
> +++ b/lib/librte_ethdev/rte_flow.h
> @@ -1505,6 +1505,34 @@ enum rte_flow_action_type {
> * error.
> */
> RTE_FLOW_ACTION_TYPE_NVGRE_DECAP,
> +
> + /**
> + * Modify IPv4 source address
> + *
> + * See struct rte_flow_action_set_ipv4.
> + */
> + RTE_FLOW_ACTION_TYPE_SET_IPV4_SRC,
> +
> + /**
> + * Modify IPv4 destination address
> + *
> + * See struct rte_flow_action_set_ipv4.
> + */
> + RTE_FLOW_ACTION_TYPE_SET_IPV4_DST,
> +
> + /**
> + * Modify IPv6 source address
> + *
> + * See struct rte_flow_action_set_ipv6.
> + */
> + RTE_FLOW_ACTION_TYPE_SET_IPV6_SRC,
> +
> + /**
> + * Modify IPv6 destination address
> + *
> + * See struct rte_flow_action_set_ipv6.
> + */
> + RTE_FLOW_ACTION_TYPE_SET_IPV6_DST,
> };
Hey Rahul,
Sorry for the late response. Just a small comment:
We would need the corresponding RTE_FLOW_ITEM_TYPE_* specified in pattern.
i.e RTE_FLOW_ITEM_TYPE_IPV6 must be in pattern for action RTE_FLOW_ACTION_TYPE_SET_IPV6_SRC
otherwise RTE_FLOW_ERROR_TYPE_ACTION return.
Would be better to document this in comments and __rte_flow.rst__
What do you think?
-Jack